fix(web-components): dont ship non production assets to npm registry#26854
Merged
Hotell merged 2 commits intoFeb 15, 2023
Merged
Conversation
Hotell
changed the title
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ae03f3eec389aca7e15fde295868aacd51eb1822 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d6259c0:
|
Hotell
force-pushed
the
hotell/wc/improve-npm-public-api
branch
from
February 15, 2023 10:32
137a65d to
d6259c0
Compare
Collaborator
📊 Bundle size report🤖 This report was generated against e1be11888330811efdbf51f3fd4682dd9f0b804c |
Hotell
marked this pull request as ready for review
February 15, 2023 10:38
| temp | ||
| temp/ | ||
| etc/ | ||
| CHANGELOG.json |
Member
There was a problem hiding this comment.
Not sure about this one.
Contributor
Author
There was a problem hiding this comment.
there is no purpose to ship metadata json to registry, but it turns out that even ignore wont work on this one. Im aware that you cannot ignore Readme.md and Changelog.md but this is a bit mystery to me heh
miroslavstastny
approved these changes
Feb 15, 2023
chrisdholt
pushed a commit
that referenced
this pull request
Apr 29, 2024
…26854) * fix(web-components): dont ship non production assets to npm registry * generate change file
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
…icrosoft#26854) * fix(web-components): dont ship non production assets to npm registry * generate change file
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
…icrosoft#26854) * fix(web-components): dont ship non production assets to npm registry * generate change file
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 30, 2024
…icrosoft#26854) * fix(web-components): dont ship non production assets to npm registry * generate change file
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
…26854) * fix(web-components): dont ship non production assets to npm registry * generate change file
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
…26854) * fix(web-components): dont ship non production assets to npm registry * generate change file
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
…26854) * fix(web-components): dont ship non production assets to npm registry * generate change file
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
…26854) * fix(web-components): dont ship non production assets to npm registry * generate change file
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
…26854) * fix(web-components): dont ship non production assets to npm registry * generate change file
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
…26854) * fix(web-components): dont ship non production assets to npm registry * generate change file
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
…26854) * fix(web-components): dont ship non production assets to npm registry * generate change file
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
…26854) * fix(web-components): dont ship non production assets to npm registry * generate change file
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
…26854) * fix(web-components): dont ship non production assets to npm registry * generate change file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
stories and other metadata/assets are no longer shipped to npm
helpers.ts moved to
helpers.stories.tsto match proper domain and remove from npm registrytweak of script aliases to align more with repo nomenclature
Generate api.md changes
Related Issue(s)