Skip to content

fix: Updating peer dependencies of react-virtualizer to support React 18#26866

Merged
micahgodbolt merged 3 commits into
microsoft:masterfrom
micahgodbolt:virtualizer-peer-deps
Feb 15, 2023
Merged

fix: Updating peer dependencies of react-virtualizer to support React 18#26866
micahgodbolt merged 3 commits into
microsoft:masterfrom
micahgodbolt:virtualizer-peer-deps

Conversation

@micahgodbolt

Copy link
Copy Markdown
Member

fixes #26859

Comment thread change/@fluentui-react-virtualizer-f4f74084-b93e-4113-8e45-29229d62546e.json Outdated
@khmakoto khmakoto changed the title React Virtualizer React 18 peer dependencies fix: Updating peer dependencies of react-virtualizer to support React 18 Feb 15, 2023
…29d62546e.json

Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
@micahgodbolt
micahgodbolt enabled auto-merge (squash) February 15, 2023 22:01
@size-auditor

size-auditor Bot commented Feb 15, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2a39824231365b95ba70991285301a6b83b4f107 (build)

@fabricteam

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
64.09 kB
17.544 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
201.941 kB
56.241 kB
react-components
react-components: FluentProvider & webLightTheme
35.049 kB
11.533 kB
react-portal-compat
PortalCompatProvider
6.324 kB
2.129 kB
🤖 This report was generated against 2a39824231365b95ba70991285301a6b83b4f107

@fabricteam

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1287 1283 5000
Button mount 919 941 5000
Field mount 1948 1904 5000
FluentProvider mount 1512 1521 5000
FluentProviderWithTheme mount 565 573 10
FluentProviderWithTheme virtual-rerender 551 540 10
FluentProviderWithTheme virtual-rerender-with-unmount 569 570 10
InfoButton mount 515 531 5000
MakeStyles mount 1958 1958 50000
Persona mount 2828 2816 5000
SpinButton mount 2340 2346 5000

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e247fc3:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@micahgodbolt
micahgodbolt merged commit 4af9156 into microsoft:master Feb 15, 2023
@micahgodbolt
micahgodbolt deleted the virtualizer-peer-deps branch February 15, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: fluent-ui v9 peer dependency warnings

4 participants