Skip to content

MenuPopover should have overflow styles when using autoSize#26922

Closed
ling1726 wants to merge 1 commit into
microsoft:masterfrom
ling1726:feat/autosize-overflow
Closed

MenuPopover should have overflow styles when using autoSize#26922
ling1726 wants to merge 1 commit into
microsoft:masterfrom
ling1726:feat/autosize-overflow

Conversation

@ling1726

Copy link
Copy Markdown
Contributor

Previous Behavior

New Behavior

Related Issue(s)

  • Fixes #

@size-auditor

size-auditor Bot commented Feb 20, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2958df9fc9f756e4b9c42f41b4678810b83ab903 (build)

@fabricteam

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-menu
Menu (including children components)
126.501 kB
38.723 kB
126.718 kB
38.816 kB
217 B
93 B
react-menu
Menu (including selectable components)
129.57 kB
39.237 kB
129.787 kB
39.329 kB
217 B
92 B

🤖 This report was generated against 2958df9fc9f756e4b9c42f41b4678810b83ab903

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit da482ae:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1662 1663 5000
Button mount 1133 1190 5000
Field mount 2737 2559 5000
FluentProvider mount 2116 1992 5000
FluentProviderWithTheme mount 721 701 10
FluentProviderWithTheme virtual-rerender 711 680 10
FluentProviderWithTheme virtual-rerender-with-unmount 696 770 10
InfoButton mount 637 622 5000
MakeStyles mount 2290 2245 50000
Persona mount 4041 3950 5000
SpinButton mount 3249 3241 5000

@fabricteam

Copy link
Copy Markdown
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@ling1726

Copy link
Copy Markdown
Contributor Author

Closing in favour of #26868

@ling1726 ling1726 closed this Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants