feat: Add infoButton slot to Field (discarded implementation option)#27032
Closed
behowell wants to merge 1 commit into
Closed
feat: Add infoButton slot to Field (discarded implementation option)#27032behowell wants to merge 1 commit into
behowell wants to merge 1 commit into
Conversation
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: c97e8d336e193c45189b4b7bcbdb599bde24d669 (build) |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7a8bb38:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1324 | 1316 | 5000 | |
| Button | mount | 960 | 952 | 5000 | |
| Field | mount | 2063 | 2080 | 5000 | |
| FluentProvider | mount | 1611 | 1656 | 5000 | |
| FluentProviderWithTheme | mount | 641 | 632 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 599 | 602 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 630 | 625 | 10 | |
| InfoButton | mount | 570 | 573 | 5000 | |
| MakeStyles | mount | 1896 | 1914 | 50000 | |
| Persona | mount | 3036 | 3012 | 5000 | |
| SpinButton | mount | 2474 | 2439 | 5000 |
fabricteam
reviewed
Mar 2, 2023
| @@ -109,6 +109,44 @@ storiesOf('Field', module) | |||
| <Checkbox label="Checkbox in a horizontal field" /> | |||
Collaborator
There was a problem hiding this comment.
🕵 fluentuiv9 Open the Visual Regressions report to inspect the 7 screenshots
✅ There was 7 screenshots added, 0 screenshots removed, 1862 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.
unknown 7 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Field.infoButton+horizontal.default.chromium.png | 0 | Added |
| Field.infoButton+longLabel.default.chromium.png | 0 | Added |
| Field.infoButton+noLabel.default.chromium.png | 0 | Added |
| Field.infoButton+required.default.chromium.png | 0 | Added |
| Field.infoButton+size-large.default.chromium.png | 0 | Added |
| Field.infoButton+size-small.default.chromium.png | 0 | Added |
| Field.infoButton.default.chromium.png | 0 | Added |
Contributor
Author
|
Abandoning in favor of the approach used in #27030, due to the bundle size cost of referencing the InfoButton component directly from Field. |
behowell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Related Issue(s)