fix: Make border around Avatar's badge transparent, not a solid color#27292
Closed
behowell wants to merge 3 commits into
Closed
fix: Make border around Avatar's badge transparent, not a solid color#27292behowell wants to merge 3 commits into
behowell wants to merge 3 commits into
Conversation
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 77bb9ec1eeedef91315dee3750bd06b15168c693 (build) |
fabricteam
reviewed
Mar 22, 2023
| @@ -0,0 +1,7 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
🕵 fluentuiv9 Open the Visual Regressions report to inspect the 163 screenshots
✅ There was 0 screenshots added, 0 screenshots removed, 1740 screenshots unchanged, 0 screenshots with different dimensions and 163 screenshots with visible difference.
unknown 163 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.basic - Dark Mode.normal.chromium.png | 3 | Changed |
| Avatar Converged.basic - High Contrast.normal.chromium.png | 9 | Changed |
| Avatar Converged.basic - RTL.normal.chromium.png | 34 | Changed |
| Avatar Converged.basic.normal.chromium.png | 6 | Changed |
| Avatar Converged.customSize+name+badge.normal.chromium.png | 83 | Changed |
| Avatar Converged.size+icon+badge+square.normal.chromium.png | 47 | Changed |
| Avatar Converged.size+image+badge.normal.chromium.png | 70 | Changed |
| Avatar Converged.size+inactive+badge.normal.chromium.png | 43 | Changed |
| Persona Converged.basic - Dark Mode.normal.chromium.png | 1 | Changed |
| Persona Converged.basic - High Contrast.normal.chromium.png | 5 | Changed |
| Persona Converged.basic - RTL.normal.chromium.png | 2 | Changed |
| Persona Converged.basic.normal.chromium.png | 3 | Changed |
| Persona Converged.textWrap.normal.chromium.png | 3 | Changed |
| Table flex - subtle selection.rest.chromium.png | 9 | Changed |
| Table flex - subtle selection.rest.hover unselected row.chromium.png | 9 | Changed |
| Table layout flex - cell actions.always visible - Dark Mode.chromium.png | 6 | Changed |
| Table layout flex - cell actions.always visible - Dark Mode.hover row.chromium.png | 7 | Changed |
| Table layout flex - cell actions.always visible - High Contrast.chromium.png | 19 | Changed |
| Table layout flex - cell actions.always visible - High Contrast.hover row.chromium.png | 33 | Changed |
| Table layout flex - cell actions.always visible - RTL.chromium.png | 9 | Changed |
| Table layout flex - cell actions.always visible - RTL.hover row.chromium.png | 8 | Changed |
| Table layout flex - cell actions.always visible.chromium.png | 9 | Changed |
| Table layout flex - cell actions.always visible.hover row.chromium.png | 9 | Changed |
| Table layout flex - cell actions.default - Dark Mode.chromium.png | 6 | Changed |
| Table layout flex - cell actions.default - Dark Mode.hover row.chromium.png | 7 | Changed |
| Table layout flex - cell actions.default - High Contrast.chromium.png | 19 | Changed |
| Table layout flex - cell actions.default - High Contrast.hover row.chromium.png | 33 | Changed |
| Table layout flex - cell actions.default - RTL.chromium.png | 9 | Changed |
| Table layout flex - cell actions.default - RTL.hover row.chromium.png | 8 | Changed |
| Table layout flex - cell actions.default.chromium.png | 9 | Changed |
| Table layout flex - cell actions.default.hover row.chromium.png | 9 | Changed |
| Table layout flex - cell actions.in header cell.chromium.png | 9 | Changed |
| Table layout flex - cell actions.in header cell.hover row.chromium.png | 9 | Changed |
| Table layout flex - headers.sortable - Dark Mode.chromium.png | 6 | Changed |
| Table layout flex - headers.sortable - Dark Mode.hover header.chromium.png | 6 | Changed |
| Table layout flex - headers.sortable - Dark Mode.press header.chromium.png | 6 | Changed |
| Table layout flex - headers.sortable - High Contrast.chromium.png | 19 | Changed |
| Table layout flex - headers.sortable - High Contrast.hover header.chromium.png | 19 | Changed |
| Table layout flex - headers.sortable - High Contrast.press header.chromium.png | 19 | Changed |
| Table layout flex - headers.sortable.chromium.png | 9 | Changed |
| Table layout flex - headers.sortable.hover header.chromium.png | 9 | Changed |
| Table layout flex - headers.sortable.press header.chromium.png | 9 | Changed |
| Table layout flex - truncate.default (disabled).chromium.png | 9 | Changed |
| Table layout flex - truncate.false.chromium.png | 9 | Changed |
| Table layout flex - truncate.true.chromium.png | 9 | Changed |
| Table layout flex.multiselect (checked) - brand - Dark Mode.chromium.png | 8 | Changed |
| Table layout flex.multiselect (checked) - brand - High Contrast.chromium.png | 111 | Changed |
| Table layout flex.multiselect (checked) - brand - RTL.chromium.png | 7 | Changed |
| Table layout flex.multiselect (checked) - brand.chromium.png | 11 | Changed |
| Table layout flex.multiselect (checked) - neutral - Dark Mode.chromium.png | 5 | Changed |
| Table layout flex.multiselect (checked) - neutral - High Contrast.chromium.png | 76 | Changed |
| Table layout flex.multiselect (checked) - neutral - RTL.chromium.png | 8 | Changed |
| Table layout flex.multiselect (checked) - neutral.chromium.png | 13 | Changed |
| Table layout flex.multiselect (mixed) - brand - Dark Mode.chromium.png | 7 | Changed |
| Table layout flex.multiselect (mixed) - brand - High Contrast.chromium.png | 65 | Changed |
| Table layout flex.multiselect (mixed) - brand - RTL.chromium.png | 8 | Changed |
| Table layout flex.multiselect (mixed) - brand.chromium.png | 10 | Changed |
| Table layout flex.multiselect (mixed) - neutral - Dark Mode.chromium.png | 6 | Changed |
| Table layout flex.multiselect (mixed) - neutral - High Contrast.chromium.png | 48 | Changed |
| Table layout flex.multiselect (mixed) - neutral - RTL.chromium.png | 9 | Changed |
| Table layout flex.multiselect (mixed) - neutral.chromium.png | 11 | Changed |
| Table layout flex.multiselect - Dark Mode.chromium.png | 6 | Changed |
| Table layout flex.multiselect - High Contrast.chromium.png | 19 | Changed |
| Table layout flex.multiselect - RTL.chromium.png | 9 | Changed |
| Table layout flex.multiselect.chromium.png | 9 | Changed |
| Table layout flex.primary cell.chromium.png | 9 | Changed |
| Table layout flex.single select (checked) - Dark Mode.chromium.png | 6 | Changed |
| Table layout flex.single select (checked) - High Contrast.chromium.png | 19 | Changed |
| Table layout flex.single select (checked) - RTL.chromium.png | 9 | Changed |
| Table layout flex.single select (checked) - brand - Dark Mode.chromium.png | 7 | Changed |
| Table layout flex.single select (checked) - brand - High Contrast.chromium.png | 42 | Changed |
| Table layout flex.single select (checked) - brand - RTL.chromium.png | 9 | Changed |
| Table layout flex.single select (checked) - brand.chromium.png | 10 | Changed |
| Table layout flex.single select (checked) - neutral - Dark Mode.chromium.png | 6 | Changed |
| Table layout flex.single select (checked) - neutral - High Contrast.chromium.png | 33 | Changed |
| Table layout flex.single select (checked) - neutral - RTL.chromium.png | 9 | Changed |
| Table layout flex.single select (checked) - neutral.chromium.png | 10 | Changed |
| Table layout flex.single select (checked).chromium.png | 9 | Changed |
| Table layout flex.single select - Dark Mode.chromium.png | 6 | Changed |
| Table layout flex.single select - High Contrast.chromium.png | 19 | Changed |
| Table layout flex.single select - RTL.chromium.png | 9 | Changed |
| Table layout flex.single select.chromium.png | 9 | Changed |
| Table layout flex.size - extra small.chromium.png | 7 | Changed |
| Table layout flex.size - medium - Dark Mode.chromium.png | 6 | Changed |
| Table layout flex.size - medium - High Contrast.chromium.png | 19 | Changed |
| Table layout flex.size - medium - RTL.chromium.png | 9 | Changed |
| Table layout flex.size - medium.chromium.png | 9 | Changed |
| Table layout flex.size - small.chromium.png | 7 | Changed |
| Table layout table - cell actions.always visible - Dark Mode.chromium.png | 6 | Changed |
| Table layout table - cell actions.always visible - Dark Mode.hover row.chromium.png | 7 | Changed |
| Table layout table - cell actions.always visible - High Contrast.chromium.png | 19 | Changed |
| Table layout table - cell actions.always visible - High Contrast.hover row.chromium.png | 33 | Changed |
| Table layout table - cell actions.always visible - RTL.chromium.png | 9 | Changed |
| Table layout table - cell actions.always visible - RTL.hover row.chromium.png | 8 | Changed |
| Table layout table - cell actions.always visible.chromium.png | 9 | Changed |
| Table layout table - cell actions.always visible.hover row.chromium.png | 9 | Changed |
| Table layout table - cell actions.default - Dark Mode.chromium.png | 6 | Changed |
| Table layout table - cell actions.default - Dark Mode.hover row.chromium.png | 7 | Changed |
| Table layout table - cell actions.default - High Contrast.chromium.png | 19 | Changed |
| Table layout table - cell actions.default - High Contrast.hover row.chromium.png | 33 | Changed |
| Table layout table - cell actions.default - RTL.chromium.png | 9 | Changed |
| Table layout table - cell actions.default - RTL.hover row.chromium.png | 8 | Changed |
| Table layout table - cell actions.default.chromium.png | 9 | Changed |
| Table layout table - cell actions.default.hover row.chromium.png | 9 | Changed |
| Table layout table - cell actions.in header cell.chromium.png | 9 | Changed |
| Table layout table - cell actions.in header cell.hover row.chromium.png | 9 | Changed |
| Table layout table - headers.sortable - Dark Mode.chromium.png | 6 | Changed |
| Table layout table - headers.sortable - Dark Mode.hover header.chromium.png | 6 | Changed |
| Table layout table - headers.sortable - Dark Mode.press header.chromium.png | 6 | Changed |
| Table layout table - headers.sortable - High Contrast.chromium.png | 19 | Changed |
| Table layout table - headers.sortable - High Contrast.hover header.chromium.png | 19 | Changed |
| Table layout table - headers.sortable - High Contrast.press header.chromium.png | 19 | Changed |
| Table layout table - headers.sortable.chromium.png | 9 | Changed |
| Table layout table - headers.sortable.hover header.chromium.png | 9 | Changed |
| Table layout table - headers.sortable.press header.chromium.png | 9 | Changed |
| Table layout table - truncate.default (disabled).chromium.png | 9 | Changed |
| Table layout table - truncate.false.chromium.png | 9 | Changed |
| Table layout table - truncate.true.chromium.png | 9 | Changed |
| Table layout table.multiselect (checked) - brand - Dark Mode.chromium.png | 8 | Changed |
| Table layout table.multiselect (checked) - brand - High Contrast.chromium.png | 111 | Changed |
| Table layout table.multiselect (checked) - brand - RTL.chromium.png | 7 | Changed |
| Table layout table.multiselect (checked) - brand.chromium.png | 11 | Changed |
| Table layout table.multiselect (checked) - neutral - Dark Mode.chromium.png | 5 | Changed |
| Table layout table.multiselect (checked) - neutral - High Contrast.chromium.png | 76 | Changed |
| Table layout table.multiselect (checked) - neutral - RTL.chromium.png | 8 | Changed |
| Table layout table.multiselect (checked) - neutral.chromium.png | 13 | Changed |
| Table layout table.multiselect (mixed) - brand - Dark Mode.chromium.png | 7 | Changed |
| Table layout table.multiselect (mixed) - brand - High Contrast.chromium.png | 65 | Changed |
| Table layout table.multiselect (mixed) - brand - RTL.chromium.png | 8 | Changed |
| Table layout table.multiselect (mixed) - brand.chromium.png | 10 | Changed |
| Table layout table.multiselect (mixed) - neutral - Dark Mode.chromium.png | 6 | Changed |
| Table layout table.multiselect (mixed) - neutral - High Contrast.chromium.png | 48 | Changed |
| Table layout table.multiselect (mixed) - neutral - RTL.chromium.png | 9 | Changed |
| Table layout table.multiselect (mixed) - neutral.chromium.png | 11 | Changed |
| Table layout table.multiselect - Dark Mode.chromium.png | 6 | Changed |
| Table layout table.multiselect - High Contrast.chromium.png | 19 | Changed |
| Table layout table.multiselect - RTL.chromium.png | 9 | Changed |
| Table layout table.multiselect.chromium.png | 9 | Changed |
| Table layout table.primary cell.chromium.png | 9 | Changed |
| Table layout table.single select (checked) - Dark Mode.chromium.png | 6 | Changed |
| Table layout table.single select (checked) - High Contrast.chromium.png | 19 | Changed |
| Table layout table.single select (checked) - RTL.chromium.png | 9 | Changed |
| Table layout table.single select (checked) - brand - Dark Mode.chromium.png | 7 | Changed |
| Table layout table.single select (checked) - brand - High Contrast.chromium.png | 42 | Changed |
| Table layout table.single select (checked) - brand - RTL.chromium.png | 9 | Changed |
| Table layout table.single select (checked) - brand.chromium.png | 10 | Changed |
| Table layout table.single select (checked) - neutral - Dark Mode.chromium.png | 6 | Changed |
| Table layout table.single select (checked) - neutral - High Contrast.chromium.png | 33 | Changed |
| Table layout table.single select (checked) - neutral - RTL.chromium.png | 9 | Changed |
| Table layout table.single select (checked) - neutral.chromium.png | 10 | Changed |
| Table layout table.single select (checked).chromium.png | 9 | Changed |
| Table layout table.single select - Dark Mode.chromium.png | 6 | Changed |
| Table layout table.single select - High Contrast.chromium.png | 19 | Changed |
| Table layout table.single select - RTL.chromium.png | 9 | Changed |
| Table layout table.single select.chromium.png | 9 | Changed |
| Table layout table.size - extra small.chromium.png | 7 | Changed |
| Table layout table.size - medium - Dark Mode.chromium.png | 6 | Changed |
| Table layout table.size - medium - High Contrast.chromium.png | 19 | Changed |
| Table layout table.size - medium - RTL.chromium.png | 9 | Changed |
| Table layout table.size - medium.chromium.png | 9 | Changed |
| Table layout table.size - small.chromium.png | 7 | Changed |
| Table table - subtle selection.rest.chromium.png | 9 | Changed |
| Table table - subtle selection.rest.hover unselected row.chromium.png | 9 | Changed |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5a89239:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1078 | 1108 | 5000 | |
| Button | mount | 694 | 680 | 5000 | |
| Field | mount | 1956 | 1948 | 5000 | |
| FluentProvider | mount | 1371 | 1416 | 5000 | |
| FluentProviderWithTheme | mount | 383 | 381 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 290 | 278 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 356 | 342 | 10 | |
| InfoButton | mount | 249 | 257 | 5000 | |
| MakeStyles | mount | 1552 | 1576 | 50000 | |
| Persona | mount | 2664 | 2708 | 5000 | |
| SpinButton | mount | 2326 | 2397 | 5000 |
Contributor
Author
|
Abandoning in favor of #27527 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Previous Behavior
New Behavior
Related Issue(s)