chore: Update Field's VR tests to test changes from FieldContext#27400
Merged
Conversation
Collaborator
📊 Bundle size report🤖 This report was generated against 1071a2a382741b1328228b336c2a94de388a3963 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: af3c827937dcb0a32f52ef8a93b91c1276956b56 (build) |
fabricteam
reviewed
Mar 31, 2023
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b80c80e:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 887 | 881 | 5000 | |
| Button | mount | 586 | 590 | 5000 | |
| Field | mount | 1556 | 1477 | 5000 | |
| FluentProvider | mount | 1095 | 1086 | 5000 | |
| FluentProviderWithTheme | mount | 290 | 296 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 275 | 272 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 293 | 285 | 10 | |
| InfoButton | mount | 203 | 206 | 5000 | |
| MakeStyles | mount | 1382 | 1401 | 50000 | |
| Persona | mount | 2155 | 2056 | 5000 | |
| SpinButton | mount | 1820 | 1871 | 5000 |
behowell
force-pushed
the
field/context-vr
branch
from
April 4, 2023 21:33
b437719 to
7290fd8
Compare
github-actions
Bot
modified the milestones:
March Project Cycle Q1 2023,
April Project Cycle Q2 2023
behowell
force-pushed
the
field/context-vr
branch
from
April 5, 2023 19:21
6c5b618 to
c66ea07
Compare
sopranopillow
approved these changes
Apr 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Field VR tests weren't sufficiently testing the new behavior as of:
New Behavior
sizevia the context.