fix(scripts-storybook): make sure to exclude our custom v9 babel preset from storybook babel-loader#27417
Merged
Hotell merged 2 commits intoApr 5, 2023
Conversation
…et from storybook babel-loader
…bdox mapping and refactor outside react suite aliases
Hotell
changed the title
Hotell
marked this pull request as ready for review
April 3, 2023 16:57
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit df37136:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 8c1140461454f55359a4d329f376e8f5bc401e02 (build) |
fabricteam
reviewed
Apr 3, 2023
Collaborator
📊 Bundle size report🤖 This report was generated against 8c1140461454f55359a4d329f376e8f5bc401e02 |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Collaborator
🕵 FluentUI-v0 No visual regressions between this PR and main |
tudorpopams
self-requested a review
April 4, 2023 12:13
TristanWatanabe
approved these changes
Apr 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Introduction of
extendswith custom v9 preset withinbabelrcconfigs broke_processBabelLoaderOptions, thus griffel preset was used during storybook builds. While on pure v9 packages, things mostly still worked as expected cross project storybooks stopped working triggering following build errors:Failure for
@fluentui/react-migration-v8-v9:New Behavior
'@fluentui/scripts-babel/preset-v9'for storybookbabel-loader. This mitigates any issuesRelated Issue(s)