fix(react-skeleton): Stories should import from react-components#27498
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 57ae5e1:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: b0084da016954e9a15e0355f1b5521914d736ecd (build) |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 681 | 676 | 5000 | |
| Button | mount | 365 | 372 | 5000 | |
| Field | mount | 1259 | 1223 | 5000 | |
| FluentProvider | mount | 881 | 890 | 5000 | |
| FluentProviderWithTheme | mount | 112 | 122 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 93 | 102 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 113 | 105 | 10 | |
| InfoButton | mount | 21 | 17 | 5000 | |
| MakeStyles | mount | 1132 | 1116 | 50000 | |
| Persona | mount | 1960 | 1957 | 5000 | |
| SpinButton | mount | 1576 | 1573 | 5000 |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
behowell
marked this pull request as ready for review
April 10, 2023 08:34
…keleton/fix-story-imports
behowell
commented
Apr 10, 2023
spmonahan
approved these changes
Apr 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Skeleton stories import directly from individual packages: react-skeleton and react-field.
New Behavior
Change Skeleton stories to import from react-components instead of individual packages.
Related Issue(s)
Similar fix in react-progress: #27497