chore(react-menu): adopt custom JSX pragma#27544
Merged
bsunderhus merged 1 commit intoApr 15, 2023
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4427a81:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: bb758eb9091e5c53f8d1d58baf50505aa2aa34cc (build) |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 18 | 18 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 711 | 718 | 5000 | |
| Button | mount | 398 | 415 | 5000 | |
| Field | mount | 1256 | 1262 | 5000 | |
| FluentProvider | mount | 795 | 763 | 5000 | |
| FluentProviderWithTheme | mount | 107 | 110 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 90 | 95 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 100 | 104 | 10 | |
| InfoButton | mount | 18 | 18 | 5000 | Possible regression |
| MakeStyles | mount | 1228 | 1179 | 50000 | |
| Persona | mount | 1932 | 1899 | 5000 | |
| SpinButton | mount | 1508 | 1514 | 5000 |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
bsunderhus
marked this pull request as ready for review
April 13, 2023 12:51
bsunderhus
force-pushed
the
react-menu/feat--adopt-custom-jsx-pragma
branch
from
April 14, 2023 09:00
c36650d to
4ddd5a1
Compare
layershifter
approved these changes
Apr 14, 2023
Contributor
Author
|
I'll be waiting for #27571 before merging this PR |
bsunderhus
force-pushed
the
react-menu/feat--adopt-custom-jsx-pragma
branch
from
April 15, 2023 09:07
4ddd5a1 to
4427a81
Compare
bsunderhus
enabled auto-merge (squash)
April 15, 2023 09:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Behavior
Adopts
react-jsx-runtimecustom pragma onreact-menu.