Skip to content

chore(react-data-grid-react-window): adopt custom JSX pragma#27552

Merged
bsunderhus merged 1 commit into
microsoft:masterfrom
bsunderhus:react-data-grid-react-window/chore--adopt-custom-JSX-pragma
Apr 17, 2023
Merged

chore(react-data-grid-react-window): adopt custom JSX pragma#27552
bsunderhus merged 1 commit into
microsoft:masterfrom
bsunderhus:react-data-grid-react-window/chore--adopt-custom-JSX-pragma

Conversation

@bsunderhus

Copy link
Copy Markdown
Contributor

New Behavior

  1. Adopts react-jsx-runtime custom pragma on react-data-grid-react-window
  2. adds resolveShorthand to all slots (some root slots were missing it)

@fabricteam

fabricteam commented Apr 13, 2023

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against 2e1cf8928df3e4f0b64b7390408374db94ae9e2c

@codesandbox-ci

codesandbox-ci Bot commented Apr 13, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a335944:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor

size-auditor Bot commented Apr 13, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: bb758eb9091e5c53f8d1d58baf50505aa2aa34cc (build)

@bsunderhus
bsunderhus force-pushed the react-data-grid-react-window/chore--adopt-custom-JSX-pragma branch from d93f045 to f284168 Compare April 14, 2023 09:18
@bsunderhus

Copy link
Copy Markdown
Contributor Author

I'll be waiting for #27571 before merging this PR

@bsunderhus bsunderhus added the Status: Blocked Resolution blocked by another issue label Apr 14, 2023
@bsunderhus
bsunderhus force-pushed the react-data-grid-react-window/chore--adopt-custom-JSX-pragma branch from f284168 to a335944 Compare April 15, 2023 09:05
@bsunderhus bsunderhus removed the Status: Blocked Resolution blocked by another issue label Apr 15, 2023
@bsunderhus
bsunderhus merged commit aed714a into microsoft:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants