chore(react-avatar): Reduce bundle size by refactoring styles#27572
Closed
behowell wants to merge 5 commits into
Closed
chore(react-avatar): Reduce bundle size by refactoring styles#27572behowell wants to merge 5 commits into
behowell wants to merge 5 commits into
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 27fe5de:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 97a9295c30393b604cf3c57923334a9b10d3b7d3 (build) |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 19 | 23 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 700 | 710 | 5000 | |
| Button | mount | 400 | 409 | 5000 | |
| Field | mount | 1269 | 1233 | 5000 | |
| FluentProvider | mount | 791 | 787 | 5000 | |
| FluentProviderWithTheme | mount | 110 | 111 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 90 | 98 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 95 | 102 | 10 | |
| InfoButton | mount | 19 | 23 | 5000 | Possible regression |
| MakeStyles | mount | 1171 | 1183 | 50000 | |
| Persona | mount | 1966 | 1909 | 5000 | |
| SpinButton | mount | 1502 | 1489 | 5000 |
fabricteam
reviewed
Apr 14, 2023
| @@ -2,6 +2,7 @@ import { storiesOf } from '@storybook/react'; | |||
| import * as React from 'react'; | |||
Collaborator
There was a problem hiding this comment.
🕵 fluentuiv9 Open the Visual Regressions report to inspect the 74 screenshots
✅ There was 2 screenshots added, 0 screenshots removed, 1859 screenshots unchanged, 0 screenshots with different dimensions and 72 screenshots with visible difference.
unknown 74 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.basic - Dark Mode.normal.chromium.png | 9 | Changed |
| Avatar Converged.basic - High Contrast.normal.chromium.png | 13 | Changed |
| Avatar Converged.basic - RTL.normal.chromium.png | 14 | Changed |
| Avatar Converged.basic.normal.chromium.png | 14 | Changed |
| Avatar Converged.customSize+icon+active.normal.chromium.png | 716 | Changed |
| Avatar Converged.customSize+name+badge.normal.chromium.png | 10 | Changed |
| Avatar Converged.size+image+badge.normal.chromium.png | 182 | Changed |
| Avatar Converged.size+inactive+badge.normal.chromium.png | 119 | Changed |
| AvatarGroup Converged.layoutStack - High Contrast.default.chromium.png | 7 | Changed |
| Persona Converged.basic - High Contrast.normal.chromium.png | 6 | Changed |
| Table layout flex - cell actions.always visible - Dark Mode.hover row.chromium.png | 1 | Changed |
| Table layout flex - cell actions.always visible - High Contrast.chromium.png | 25 | Changed |
| Table layout flex - cell actions.always visible - High Contrast.hover row.chromium.png | 51 | Changed |
| Table layout flex - cell actions.default - Dark Mode.hover row.chromium.png | 1 | Changed |
| Table layout flex - cell actions.default - High Contrast.chromium.png | 25 | Changed |
| Table layout flex - cell actions.default - High Contrast.hover row.chromium.png | 51 | Changed |
| Table layout flex - headers.sortable - High Contrast.chromium.png | 25 | Changed |
| Table layout flex - headers.sortable - High Contrast.hover header.chromium.png | 25 | Changed |
| Table layout flex - headers.sortable - High Contrast.press header.chromium.png | 25 | Changed |
| Table layout flex.multiselect (checked) - brand - Dark Mode.chromium.png | 3 | Changed |
| Table layout flex.multiselect (checked) - brand - High Contrast.chromium.png | 201 | Changed |
| Table layout flex.multiselect (checked) - brand - RTL.chromium.png | 3 | Changed |
| Table layout flex.multiselect (checked) - brand.chromium.png | 3 | Changed |
| Table layout flex.multiselect (checked) - neutral - High Contrast.chromium.png | 128 | Changed |
| Table layout flex.multiselect (checked) - neutral - RTL.chromium.png | 7 | Changed |
| Table layout flex.multiselect (checked) - neutral.chromium.png | 7 | Changed |
| Table layout flex.multiselect (mixed) - brand - Dark Mode.chromium.png | 2 | Changed |
| Table layout flex.multiselect (mixed) - brand - High Contrast.chromium.png | 113 | Changed |
| Table layout flex.multiselect (mixed) - brand - RTL.chromium.png | 1 | Changed |
| Table layout flex.multiselect (mixed) - brand.chromium.png | 1 | Changed |
| Table layout flex.multiselect (mixed) - neutral - High Contrast.chromium.png | 77 | Changed |
| Table layout flex.multiselect (mixed) - neutral - RTL.chromium.png | 4 | Changed |
| Table layout flex.multiselect (mixed) - neutral.chromium.png | 4 | Changed |
| Table layout flex.multiselect - High Contrast.chromium.png | 25 | Changed |
| Table layout flex.single select (checked) - High Contrast.chromium.png | 25 | Changed |
| Table layout flex.single select (checked) - brand - High Contrast.chromium.png | 69 | Changed |
| Table layout flex.single select (checked) - neutral - High Contrast.chromium.png | 51 | Changed |
| Table layout flex.single select (checked) - neutral - RTL.chromium.png | 2 | Changed |
| Table layout flex.single select (checked) - neutral.chromium.png | 2 | Changed |
| Table layout flex.single select - High Contrast.chromium.png | 25 | Changed |
| Table layout flex.size - medium - High Contrast.chromium.png | 25 | Changed |
| Table layout table - cell actions.always visible - Dark Mode.hover row.chromium.png | 1 | Changed |
| Table layout table - cell actions.always visible - High Contrast.chromium.png | 25 | Changed |
| Table layout table - cell actions.always visible - High Contrast.hover row.chromium.png | 51 | Changed |
| Table layout table - cell actions.default - Dark Mode.hover row.chromium.png | 1 | Changed |
| Table layout table - cell actions.default - High Contrast.chromium.png | 25 | Changed |
| Table layout table - cell actions.default - High Contrast.hover row.chromium.png | 51 | Changed |
| Table layout table - headers.sortable - High Contrast.chromium.png | 25 | Changed |
| Table layout table - headers.sortable - High Contrast.hover header.chromium.png | 25 | Changed |
| Table layout table - headers.sortable - High Contrast.press header.chromium.png | 25 | Changed |
| Table layout table.multiselect (checked) - brand - Dark Mode.chromium.png | 3 | Changed |
| Table layout table.multiselect (checked) - brand - High Contrast.chromium.png | 201 | Changed |
| Table layout table.multiselect (checked) - brand - RTL.chromium.png | 3 | Changed |
| Table layout table.multiselect (checked) - brand.chromium.png | 3 | Changed |
| Table layout table.multiselect (checked) - neutral - High Contrast.chromium.png | 128 | Changed |
| Table layout table.multiselect (checked) - neutral - RTL.chromium.png | 7 | Changed |
| Table layout table.multiselect (checked) - neutral.chromium.png | 7 | Changed |
| Table layout table.multiselect (mixed) - brand - Dark Mode.chromium.png | 2 | Changed |
| Table layout table.multiselect (mixed) - brand - High Contrast.chromium.png | 113 | Changed |
| Table layout table.multiselect (mixed) - brand - RTL.chromium.png | 1 | Changed |
| Table layout table.multiselect (mixed) - brand.chromium.png | 1 | Changed |
| Table layout table.multiselect (mixed) - neutral - High Contrast.chromium.png | 77 | Changed |
| Table layout table.multiselect (mixed) - neutral - RTL.chromium.png | 4 | Changed |
| Table layout table.multiselect (mixed) - neutral.chromium.png | 4 | Changed |
| Table layout table.multiselect - High Contrast.chromium.png | 25 | Changed |
| Table layout table.single select (checked) - High Contrast.chromium.png | 25 | Changed |
| Table layout table.single select (checked) - brand - High Contrast.chromium.png | 69 | Changed |
| Table layout table.single select (checked) - neutral - High Contrast.chromium.png | 51 | Changed |
| Table layout table.single select (checked) - neutral - RTL.chromium.png | 2 | Changed |
| Table layout table.single select (checked) - neutral.chromium.png | 2 | Changed |
| Table layout table.single select - High Contrast.chromium.png | 25 | Changed |
| Table layout table.size - medium - High Contrast.chromium.png | 25 | Changed |
| Avatar Converged.badgeMask - RTL.normal.chromium.png | 0 | Added |
| Avatar Converged.badgeMask.normal.chromium.png | 0 | Added |
Contributor
Author
|
Merged this PR into #27527 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Related Issue(s)