Skip to content

fix: Scale pulse animation with percentages and flip wave animation's direction #27654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomi-msft merged 7 commits into from
May 4, 2023
Merged

fix: Scale pulse animation with percentages and flip wave animation's direction #27654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
34a93b5
add pulse using scale
tomi-msft Apr 21, 2023
0da3be8
change file
tomi-msft Apr 21, 2023
ebc407c
update pulse animation
tomi-msft May 4, 2023
26cafd6
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
tomi-msft May 4, 2023
b17bba5
update pulse animation
tomi-msft May 4, 2023
d92d390
Merge branch 'master' into skeleton-pulse
tomi-msft May 4, 2023
d8c377d
Update change/@fluentui-react-skeleton-9e800ca2-9155-4112-9add-68393d…
tomi-msft May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-skeleton-9e800ca2-9155-4112-9add-68393df30fe7.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "fix: Scale pulse animation with percentages and flip wave animation's direction.",
"packageName": "@fluentui/react-skeleton",
"email": "ololubek@microsoft.com",
"dependentChangeType": "patch"
}
20 changes: 16 additions & 4 deletions ...act-components/react-skeleton/src/components/SkeletonItem/useSkeletonItemStyles.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export const skeletonItemClassNames: SlotClassNames<SkeletonItemSlots> = {
root: 'fui-SkeletonItem',
};

const skeletonWaveAnimationRTL = {
const skeletonWaveAnimation = {
Comment thread
sopranopillow marked this conversation as resolved.
from: {
backgroundPositionX: '300% /* @noflip */',
},
Expand All @@ -17,7 +17,7 @@ const skeletonWaveAnimationRTL = {
},
};

const skeletonWaveAnimation = {
const skeletonWaveAnimationRTL = {
from: {
backgroundPositionX: '0% /* @noflip */',
},
Expand All @@ -27,12 +27,15 @@ const skeletonWaveAnimation = {
};

const skeletonPulseAnimation = {
from: {
'0%': {
opacity: '1',
},
to: {
'50%': {
opacity: '0.4',
},
'100%': {
opacity: '1',
},
};

/**
Expand Down Expand Up @@ -63,9 +66,18 @@ const useStyles = makeStyles({
},
waveRtl: {
animationName: skeletonWaveAnimationRTL,
backgroundImage: `linear-gradient(
to right,
${tokens.colorNeutralStencil1} 0%,
${tokens.colorNeutralStencil2} 50%,
${tokens.colorNeutralStencil1} 100%)`,
'@media screen and (forced-colors: active)': {
backgroundColor: 'WindowText',
},
},
pulse: {
animationName: skeletonPulseAnimation,
animationDuration: '1s',
backgroundColor: tokens.colorNeutralStencil1,
},
translucent: {
Expand Down