chore: add test-ssr script to v9 packages#27690
Merged
layershifter merged 1 commit intoMay 16, 2023
Merged
Conversation
layershifter
marked this pull request as ready for review
April 25, 2023 14:56
layershifter
requested review from
a team,
GeoffCoxMSFT,
Mitch-At-Work,
TristanWatanabe,
behowell,
chpalac,
khmakoto,
ling1726,
micahgodbolt,
ms-acalzaretto,
smhigley,
sopranopillow,
spmonahan and
tomi-msft
as code owners
April 25, 2023 14:56
layershifter
marked this pull request as draft
April 25, 2023 14:57
layershifter
commented
Apr 25, 2023
layershifter
commented
Apr 25, 2023
layershifter
commented
Apr 25, 2023
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4d2cc0c:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 322ee9ad8bbd87f7721068f664bfb530baf56623 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 826 | 808 | 5000 | |
| Button | mount | 450 | 449 | 5000 | |
| Field | mount | 1527 | 1487 | 5000 | |
| FluentProvider | mount | 1041 | 1143 | 5000 | |
| FluentProviderWithTheme | mount | 136 | 143 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 111 | 120 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 126 | 127 | 10 | |
| InfoButton | mount | 20 | 23 | 5000 | |
| MakeStyles | mount | 1350 | 1338 | 50000 | |
| Persona | mount | 2411 | 2357 | 5000 | |
| SpinButton | mount | 1932 | 1888 | 5000 |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| IconMinimalPerf.default | 497 | 455 | 1.09:1 |
| AccordionMinimalPerf.default | 107 | 100 | 1.07:1 |
| ListNestedPerf.default | 416 | 391 | 1.06:1 |
| AvatarMinimalPerf.default | 138 | 132 | 1.05:1 |
| GridMinimalPerf.default | 250 | 239 | 1.05:1 |
| HeaderMinimalPerf.default | 269 | 256 | 1.05:1 |
| TextMinimalPerf.default | 247 | 236 | 1.05:1 |
| TreeWith60ListItems.default | 106 | 101 | 1.05:1 |
| AttachmentMinimalPerf.default | 102 | 98 | 1.04:1 |
| BoxMinimalPerf.default | 252 | 243 | 1.04:1 |
| ReactionMinimalPerf.default | 273 | 262 | 1.04:1 |
| RefMinimalPerf.default | 140 | 135 | 1.04:1 |
| TableMinimalPerf.default | 299 | 287 | 1.04:1 |
| ButtonMinimalPerf.default | 112 | 109 | 1.03:1 |
| ButtonOverridesMissPerf.default | 843 | 820 | 1.03:1 |
| CardMinimalPerf.default | 382 | 372 | 1.03:1 |
| LabelMinimalPerf.default | 289 | 281 | 1.03:1 |
| ListWith60ListItems.default | 475 | 463 | 1.03:1 |
| ProviderMinimalPerf.default | 276 | 267 | 1.03:1 |
| ChatMinimalPerf.default | 541 | 532 | 1.02:1 |
| DropdownMinimalPerf.default | 1851 | 1807 | 1.02:1 |
| FlexMinimalPerf.default | 202 | 198 | 1.02:1 |
| InputMinimalPerf.default | 725 | 712 | 1.02:1 |
| ListMinimalPerf.default | 384 | 378 | 1.02:1 |
| SkeletonMinimalPerf.default | 260 | 254 | 1.02:1 |
| TreeMinimalPerf.default | 600 | 587 | 1.02:1 |
| DatepickerMinimalPerf.default | 4518 | 4470 | 1.01:1 |
| HeaderSlotsPerf.default | 582 | 577 | 1.01:1 |
| MenuButtonMinimalPerf.default | 1253 | 1245 | 1.01:1 |
| PopupMinimalPerf.default | 454 | 448 | 1.01:1 |
| ProviderMergeThemesPerf.default | 988 | 980 | 1.01:1 |
| SplitButtonMinimalPerf.default | 3023 | 2997 | 1.01:1 |
| TableManyItemsPerf.default | 1436 | 1422 | 1.01:1 |
| TextAreaMinimalPerf.default | 352 | 348 | 1.01:1 |
| ToolbarMinimalPerf.default | 671 | 666 | 1.01:1 |
| AnimationMinimalPerf.default | 366 | 365 | 1:1 |
| AttachmentSlotsPerf.default | 832 | 835 | 1:1 |
| DialogMinimalPerf.default | 574 | 572 | 1:1 |
| DropdownManyItemsPerf.default | 489 | 487 | 1:1 |
| EmbedMinimalPerf.default | 2374 | 2376 | 1:1 |
| MenuMinimalPerf.default | 621 | 623 | 1:1 |
| RosterPerf.default | 1821 | 1828 | 1:1 |
| PortalMinimalPerf.default | 119 | 119 | 1:1 |
| TooltipMinimalPerf.default | 1635 | 1639 | 1:1 |
| CarouselMinimalPerf.default | 347 | 349 | 0.99:1 |
| CheckboxMinimalPerf.default | 1554 | 1570 | 0.99:1 |
| DividerMinimalPerf.default | 260 | 263 | 0.99:1 |
| ItemLayoutMinimalPerf.default | 897 | 903 | 0.99:1 |
| LoaderMinimalPerf.default | 241 | 243 | 0.99:1 |
| SliderMinimalPerf.default | 911 | 916 | 0.99:1 |
| CustomToolbarPrototype.default | 1885 | 1898 | 0.99:1 |
| AlertMinimalPerf.default | 198 | 202 | 0.98:1 |
| ChatDuplicateMessagesPerf.default | 192 | 196 | 0.98:1 |
| ImageMinimalPerf.default | 273 | 278 | 0.98:1 |
| VideoMinimalPerf.default | 520 | 530 | 0.98:1 |
| ButtonSlotsPerf.default | 391 | 402 | 0.97:1 |
| ChatWithPopoverPerf.default | 238 | 245 | 0.97:1 |
| LayoutMinimalPerf.default | 256 | 264 | 0.97:1 |
| ListCommonPerf.default | 489 | 504 | 0.97:1 |
| RadioGroupMinimalPerf.default | 331 | 340 | 0.97:1 |
| FormMinimalPerf.default | 272 | 283 | 0.96:1 |
| SegmentMinimalPerf.default | 249 | 259 | 0.96:1 |
| StatusMinimalPerf.default | 494 | 515 | 0.96:1 |
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
🕵 FluentUI-v0 No visual regressions between this PR and main |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 808 | 821 | 5000 | |
| Breadcrumb | mount | 2264 | 2288 | 1000 | |
| Checkbox | mount | 2171 | 2192 | 5000 | |
| CheckboxBase | mount | 1911 | 1948 | 5000 | |
| ChoiceGroup | mount | 3727 | 3782 | 5000 | |
| ComboBox | mount | 892 | 900 | 1000 | |
| CommandBar | mount | 8294 | 8336 | 1000 | |
| ContextualMenu | mount | 20320 | 20852 | 1000 | |
| DefaultButton | mount | 985 | 993 | 5000 | |
| DetailsRow | mount | 2939 | 2918 | 5000 | |
| DetailsRowFast | mount | 2914 | 2967 | 5000 | |
| DetailsRowNoStyles | mount | 2708 | 2690 | 5000 | |
| Dialog | mount | 3469 | 3458 | 1000 | |
| DocumentCardTitle | mount | 315 | 324 | 1000 | |
| Dropdown | mount | 2571 | 2554 | 5000 | |
| FocusTrapZone | mount | 1491 | 1506 | 5000 | |
| FocusZone | mount | 1468 | 1437 | 5000 | |
| GroupedList | mount | 50804 | 59163 | 2 | |
| GroupedList | virtual-rerender | 24431 | 24448 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 76058 | 75418 | 2 | |
| GroupedListV2 | mount | 316 | 324 | 2 | |
| GroupedListV2 | virtual-rerender | 314 | 313 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 320 | 329 | 2 | |
| IconButton | mount | 1423 | 1425 | 5000 | |
| Label | mount | 454 | 462 | 5000 | |
| Layer | mount | 3580 | 3594 | 5000 | |
| Link | mount | 545 | 530 | 5000 | |
| MenuButton | mount | 1246 | 1233 | 5000 | |
| MessageBar | mount | 29103 | 28871 | 5000 | |
| Nav | mount | 2544 | 2524 | 1000 | |
| OverflowSet | mount | 1013 | 1011 | 5000 | |
| Panel | mount | 2325 | 2266 | 1000 | |
| Persona | mount | 996 | 978 | 1000 | |
| Pivot | mount | 1167 | 1192 | 1000 | |
| PrimaryButton | mount | 1098 | 1103 | 5000 | |
| Rating | mount | 5869 | 5835 | 5000 | |
| SearchBox | mount | 1159 | 1150 | 5000 | |
| Shimmer | mount | 2403 | 2343 | 5000 | |
| Slider | mount | 1730 | 1731 | 5000 | |
| SpinButton | mount | 3700 | 3753 | 5000 | |
| Spinner | mount | 514 | 517 | 5000 | |
| SplitButton | mount | 2446 | 2427 | 5000 | |
| Stack | mount | 537 | 540 | 5000 | |
| StackWithIntrinsicChildren | mount | 1140 | 1131 | 5000 | |
| StackWithTextChildren | mount | 3235 | 3245 | 5000 | |
| SwatchColorPicker | mount | 8193 | 8123 | 5000 | |
| TagPicker | mount | 1976 | 2023 | 5000 | |
| Text | mount | 498 | 504 | 5000 | |
| TextField | mount | 1208 | 1219 | 5000 | |
| ThemeProvider | mount | 1142 | 1140 | 5000 | |
| ThemeProvider | virtual-rerender | 788 | 778 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1735 | 1740 | 5000 | |
| Toggle | mount | 803 | 802 | 5000 | |
| buttonNative | mount | 281 | 285 | 5000 |
layershifter
marked this pull request as ready for review
April 25, 2023 16:08
sopranopillow
approved these changes
Apr 26, 2023
ling1726
approved these changes
Apr 27, 2023
Hotell
approved these changes
Apr 27, 2023
layershifter
force-pushed
the
chore/add-test-ssr-script
branch
from
May 16, 2023 12:05
e07fd16 to
819cd2d
Compare
github-actions
Bot
modified the milestones:
April Project Cycle Q2 2023,
May Project Cycle Q2 2023
layershifter
force-pushed
the
chore/add-test-ssr-script
branch
from
May 16, 2023 12:07
819cd2d to
d436f08
Compare
layershifter
force-pushed
the
chore/add-test-ssr-script
branch
from
May 16, 2023 12:13
d436f08 to
4d2cc0c
Compare
Member
Author
|
CI is passing ✅ Force merged as it does not affect published packages and I have enough approvals from the team. |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 18, 2023
* master: (24 commits) chore(react-tabster): upgrade tabster to v4.4.2 (microsoft#27540) feat(react-tags): Add TagGroup with context (microsoft#27886) applying package updates fix(react-infobutton): Add aria-owns to InfoLabel (microsoft#27834) fix(recipes-react-components): Add a FluentProvider to the local storybook (microsoft#27746) chore: update RFC template (microsoft#27880) applying package updates feat: implement Toaster offset (microsoft#27854) feat(react-drawer): create DrawerFooter component (microsoft#27583) Make getKey and selection props mutually exclusive (microsoft#24048) Added MIGRATION.md to the Breadcrumb (microsoft#27846) update Github CODEOWNERS file (microsoft#27849) feat(react-tags): make basic Tag a button instead of div (microsoft#27858) chore: add test-ssr script to v9 packages (microsoft#27690) chore(react-tree): exports TreeItemAside unstable (microsoft#27856) bugfix(react-dialog): removes unnecessary grid gaps (microsoft#27845) applying package updates fix(react-textarea): Don't remove outline when filled and disabled and apply correct disabled color to text (microsoft#27837) feat: Implement limit for toast stacking (microsoft#27848) Update README.md for fluent 2 theme to include import instructions (microsoft#27847) ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 18, 2023
* feat/drawer-header: (24 commits) chore(react-tabster): upgrade tabster to v4.4.2 (microsoft#27540) feat(react-tags): Add TagGroup with context (microsoft#27886) applying package updates fix(react-infobutton): Add aria-owns to InfoLabel (microsoft#27834) fix(recipes-react-components): Add a FluentProvider to the local storybook (microsoft#27746) chore: update RFC template (microsoft#27880) applying package updates feat: implement Toaster offset (microsoft#27854) feat(react-drawer): create DrawerFooter component (microsoft#27583) Make getKey and selection props mutually exclusive (microsoft#24048) fix: move style override to outside the component Added MIGRATION.md to the Breadcrumb (microsoft#27846) update Github CODEOWNERS file (microsoft#27849) feat(react-tags): make basic Tag a button instead of div (microsoft#27858) chore: add test-ssr script to v9 packages (microsoft#27690) chore(react-tree): exports TreeItemAside unstable (microsoft#27856) bugfix(react-dialog): removes unnecessary grid gaps (microsoft#27845) applying package updates fix(react-textarea): Don't remove outline when filled and disabled and apply correct disabled color to text (microsoft#27837) feat: Implement limit for toast stacking (microsoft#27848) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Behavior
This PR adds
test-ssrscript to v9 packages.Change files have "none" change type as artifacts will not be affected.
Related Issue(s)
Previous PRs: #27444, #27463
Next steps:
test-ssr@fluentui/scripts-test-ssr@fluentui/ssr-tests-v9