chore(react-utilities): updates useControllableState comments#27754
Merged
bsunderhus merged 1 commit intoMay 3, 2023
Conversation
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 21 | 19 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 710 | 712 | 5000 | |
| Button | mount | 376 | 370 | 5000 | |
| Field | mount | 1271 | 1244 | 5000 | |
| FluentProvider | mount | 919 | 919 | 5000 | |
| FluentProviderWithTheme | mount | 120 | 120 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 96 | 99 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 108 | 110 | 10 | |
| InfoButton | mount | 21 | 19 | 5000 | Possible regression |
| MakeStyles | mount | 1128 | 1128 | 50000 | |
| Persona | mount | 2029 | 1955 | 5000 | |
| SpinButton | mount | 1553 | 1549 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 34773da:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 43d6e99d28aa0e7bd7111f1043348683646eaa5b (build) |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Member
|
Can you please also apply comments from the previous PR #27702 (review)? 🙏 |
layershifter
approved these changes
May 3, 2023
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Contributor
Author
The follow up on that is here: #27717 |
bsunderhus
deleted the
react-utilities/chore--updates-useControllableState-comments
branch
May 3, 2023 12:59
Collaborator
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Behavior
Improves documentation for
useControllableStateto ensure a better understanding of how the hook properly operates.Related Issue(s)
useControllableStateis not able to sync internal state with incoming state #25748