Skip to content

Expose getFileTypeIconAsURL helper for react-file-type-icons#27940

Open
NotWoods wants to merge 5 commits into
microsoft:masterfrom
NotWoods:file-icon-url
Open

Expose getFileTypeIconAsURL helper for react-file-type-icons#27940
NotWoods wants to merge 5 commits into
microsoft:masterfrom
NotWoods:file-icon-url

Conversation

@NotWoods

Copy link
Copy Markdown
Contributor

Previous Behavior

File Type Icons can't be used with Fluent 9 unless you import Fluent 8 <Icon /> or use React to dangerously set inner HTML.

New Behavior

Expose a new helper method so Fluent 9 code can use <img src={getFileTypeIconAsURL()} />.

Related Issue(s)

  • Fixes #

@fabricteam

fabricteam commented May 22, 2023

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against c0214bcb7d9369db75eb842adf4253893bc0e160

@paulgildea
paulgildea requested a review from behowell May 22, 2023 20:08
@paulgildea

Copy link
Copy Markdown
Member

cc: @behowell for visibility

@size-auditor

size-auditor Bot commented May 22, 2023

Copy link
Copy Markdown

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: ab90189

Possible causes

  • The baseline build ab90189 is broken
  • The Size Auditor run for the baseline build ab90189 was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@codesandbox-ci

codesandbox-ci Bot commented May 22, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit acf0be6:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@NotWoods
NotWoods marked this pull request as ready for review May 30, 2023 23:12
@NotWoods
NotWoods requested review from a team, Jahnp and bigbadcapers as code owners May 30, 2023 23:12
@paulgildea

Copy link
Copy Markdown
Member

@micahgodbolt is this something to help with while Ben is oof? cc: @grace-zou

@tomi-msft tomi-msft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. we should have a convo about how to support file-type icons within v9 for the future.

@micahgodbolt

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 4 pipeline(s).

@tomi-msft

Copy link
Copy Markdown
Contributor

I have approved and merged this PR: #27336. Can you pull from master and update this PR?

@layershifter layershifter removed their assignment Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants