Skip to content

Update AdvancedConfiguration.stories.mdx#28041

Merged
layershifter merged 4 commits into
microsoft:masterfrom
PauwelsYoran:patch-1
Jun 2, 2023
Merged

Update AdvancedConfiguration.stories.mdx#28041
layershifter merged 4 commits into
microsoft:masterfrom
PauwelsYoran:patch-1

Conversation

@PauwelsYoran

@PauwelsYoran PauwelsYoran commented May 30, 2023

Copy link
Copy Markdown

added IdPrefixProvider to documentation for problems that can be caused by fluentprovider interop

Previous Behavior

New Behavior

Related Issue(s)

[](#27976)

  • Fixes #

added IdPrefixProvider to documentation for problems that can be caused by fluentprovider interop
@codesandbox-ci

codesandbox-ci Bot commented May 30, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 14add1f:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam

fabricteam commented May 30, 2023

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against 0f5a9008e78d8a3e89ebdecb26c48694b30d35f4

@tudorpopams
tudorpopams self-requested a review May 30, 2023 12:14
Comment thread apps/public-docsite-v9/src/Concepts/AdvancedConfiguration.stories.mdx Outdated
@size-auditor

size-auditor Bot commented May 31, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 0f5a9008e78d8a3e89ebdecb26c48694b30d35f4 (build)

@PauwelsYoran

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@layershifter

Copy link
Copy Markdown
Member

/azp run

@layershifter
layershifter enabled auto-merge (squash) June 1, 2023 09:16
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 4 pipeline(s).

@ling1726

ling1726 commented Jun 1, 2023

Copy link
Copy Markdown
Contributor

/azp run Fluent UI React - PR and CI

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@layershifter
layershifter merged commit d77c620 into microsoft:master Jun 2, 2023
@msft-fluent-ui-bot

Copy link
Copy Markdown
Collaborator

🎉@fluentui/react-docsite-components@v8.12.17 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot

Copy link
Copy Markdown
Collaborator

🎉@fluentui/react-monaco-editor@v1.7.94 has been released which incorporates this pull request.:tada:

Handy links:

@1hw7

1hw7 commented Aug 11, 2023

Copy link
Copy Markdown

Hi @layershifter, I'm wondering if it might be a good idea to move this to the introduction section of the docs? Or somewhere more likely for all users to see? We spent quite a while debugging this on my team. We use fluent v9, while a npm package we consume also uses fluent v9 and neither of us were aware of this and the issue was quite hard to track down.

I wonder if this was moved to the introduction section, if others might be less likely to spend as long on this! On that note though, so grateful docs were added on this otherwise we may have still have been trying to figure it out :D

@layershifter

Copy link
Copy Markdown
Member

@1hw7 while this issue appears, it does not like a goto option for all audience 🤔

FYI: #28670 added new behavior, newer versions of Fluent will notify you if the problem exists and link to this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants