Skip to content

fix(react-datepicker-compat): Remove focus function from the deps to avoid constant move of focus #28053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopranopillow merged 2 commits into from
May 30, 2023
Merged

fix(react-datepicker-compat): Remove focus function from the deps to avoid constant move of focus #28053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c34f95
fix: Remove focus function from the deps to avoid constant move of fo…
sopranopillow May 30, 2023
3acf9da
change file
sopranopillow May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-datepicker-compat-f276a459-aa9c-4f3b-bb52-ac556558e5ec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: Remove focus function from the deps to avoid constant move of focus.",
"packageName": "@fluentui/react-datepicker-compat",
"email": "esteban.230@hotmail.com",
"dependentChangeType": "patch"
}
4 changes: 3 additions & 1 deletion ...ages/react-components/react-datepicker-compat/src/components/DatePicker/useDatePicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,9 @@ export const useDatePicker_unstable = (props: DatePickerProps, ref: React.Ref<HT
if (!open && !props.disabled) {
focus();
}
}, [open, props.disabled, focus]);
// Focus function keeps changing, so we need to skip it in the deps
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [open, props.disabled]);

const calendarShorthand = resolveShorthand(props.calendar, {
required: true,
Expand Down