feat(test-bundles): make the bundle-size flow generic to simplify local DX but most importantly CI#28210
Merged
Hotell merged 6 commits intoJun 15, 2023
Conversation
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 583 | 570 | 5000 | |
| Button | mount | 315 | 304 | 5000 | |
| Field | mount | 1037 | 1004 | 5000 | |
| FluentProvider | mount | 644 | 645 | 5000 | |
| FluentProviderWithTheme | mount | 70 | 82 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 71 | 69 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 73 | 76 | 10 | |
| InfoButton | mount | 12 | 16 | 5000 | |
| MakeStyles | mount | 863 | 853 | 50000 | |
| Persona | mount | 1586 | 1542 | 5000 | |
| SpinButton | mount | 1282 | 1254 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| PortalMinimalPerf.default | 99 | 83 | 1.19:1 |
| RefMinimalPerf.default | 119 | 108 | 1.1:1 |
| AccordionMinimalPerf.default | 87 | 80 | 1.09:1 |
| ListWith60ListItems.default | 380 | 353 | 1.08:1 |
| DropdownManyItemsPerf.default | 403 | 378 | 1.07:1 |
| TreeWith60ListItems.default | 89 | 83 | 1.07:1 |
| ListNestedPerf.default | 336 | 318 | 1.06:1 |
| DialogMinimalPerf.default | 463 | 442 | 1.05:1 |
| HeaderSlotsPerf.default | 482 | 460 | 1.05:1 |
| LayoutMinimalPerf.default | 208 | 199 | 1.05:1 |
| IconMinimalPerf.default | 376 | 358 | 1.05:1 |
| TextMinimalPerf.default | 202 | 193 | 1.05:1 |
| BoxMinimalPerf.default | 195 | 188 | 1.04:1 |
| LoaderMinimalPerf.default | 192 | 185 | 1.04:1 |
| TableMinimalPerf.default | 241 | 231 | 1.04:1 |
| TextAreaMinimalPerf.default | 291 | 280 | 1.04:1 |
| AvatarMinimalPerf.default | 117 | 114 | 1.03:1 |
| InputMinimalPerf.default | 547 | 531 | 1.03:1 |
| ListCommonPerf.default | 399 | 387 | 1.03:1 |
| SkeletonMinimalPerf.default | 201 | 195 | 1.03:1 |
| CustomToolbarPrototype.default | 1521 | 1474 | 1.03:1 |
| TreeMinimalPerf.default | 491 | 475 | 1.03:1 |
| ChatDuplicateMessagesPerf.default | 152 | 149 | 1.02:1 |
| CheckboxMinimalPerf.default | 1149 | 1132 | 1.02:1 |
| PopupMinimalPerf.default | 354 | 347 | 1.02:1 |
| ToolbarMinimalPerf.default | 547 | 534 | 1.02:1 |
| DatepickerMinimalPerf.default | 3621 | 3586 | 1.01:1 |
| HeaderMinimalPerf.default | 208 | 206 | 1.01:1 |
| RadioGroupMinimalPerf.default | 266 | 264 | 1.01:1 |
| AnimationMinimalPerf.default | 293 | 294 | 1:1 |
| ButtonOverridesMissPerf.default | 636 | 635 | 1:1 |
| CardMinimalPerf.default | 314 | 314 | 1:1 |
| CarouselMinimalPerf.default | 258 | 259 | 1:1 |
| DividerMinimalPerf.default | 207 | 207 | 1:1 |
| ItemLayoutMinimalPerf.default | 730 | 728 | 1:1 |
| LabelMinimalPerf.default | 217 | 218 | 1:1 |
| ListMinimalPerf.default | 311 | 311 | 1:1 |
| StatusMinimalPerf.default | 401 | 402 | 1:1 |
| DropdownMinimalPerf.default | 1422 | 1440 | 0.99:1 |
| EmbedMinimalPerf.default | 1865 | 1884 | 0.99:1 |
| MenuButtonMinimalPerf.default | 949 | 961 | 0.99:1 |
| RosterPerf.default | 1525 | 1539 | 0.99:1 |
| SliderMinimalPerf.default | 747 | 756 | 0.99:1 |
| SplitButtonMinimalPerf.default | 2235 | 2268 | 0.99:1 |
| TableManyItemsPerf.default | 1105 | 1112 | 0.99:1 |
| TooltipMinimalPerf.default | 1247 | 1265 | 0.99:1 |
| ButtonSlotsPerf.default | 308 | 313 | 0.98:1 |
| MenuMinimalPerf.default | 491 | 499 | 0.98:1 |
| ProviderMergeThemesPerf.default | 649 | 659 | 0.98:1 |
| ProviderMinimalPerf.default | 197 | 201 | 0.98:1 |
| ReactionMinimalPerf.default | 214 | 218 | 0.98:1 |
| SegmentMinimalPerf.default | 197 | 202 | 0.98:1 |
| AttachmentSlotsPerf.default | 622 | 638 | 0.97:1 |
| ChatWithPopoverPerf.default | 181 | 186 | 0.97:1 |
| GridMinimalPerf.default | 185 | 190 | 0.97:1 |
| ImageMinimalPerf.default | 220 | 227 | 0.97:1 |
| VideoMinimalPerf.default | 428 | 440 | 0.97:1 |
| AlertMinimalPerf.default | 155 | 162 | 0.96:1 |
| ChatMinimalPerf.default | 421 | 439 | 0.96:1 |
| FlexMinimalPerf.default | 151 | 157 | 0.96:1 |
| ButtonMinimalPerf.default | 85 | 90 | 0.94:1 |
| FormMinimalPerf.default | 221 | 237 | 0.93:1 |
| AttachmentMinimalPerf.default | 80 | 87 | 0.92:1 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f9167c2:
|
Hotell
force-pushed
the
hotell/ci/fix-size-auditor-pipelines-v2
branch
from
June 13, 2023 14:28
29b1731 to
c527826
Compare
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
🕵 FluentUI-v0 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 607 | 621 | 5000 | |
| Breadcrumb | mount | 1667 | 1627 | 1000 | |
| Checkbox | mount | 1642 | 1675 | 5000 | |
| CheckboxBase | mount | 1497 | 1470 | 5000 | |
| ChoiceGroup | mount | 2870 | 2883 | 5000 | |
| ComboBox | mount | 642 | 644 | 1000 | |
| CommandBar | mount | 6116 | 6107 | 1000 | |
| ContextualMenu | mount | 11374 | 11616 | 1000 | |
| DefaultButton | mount | 719 | 744 | 5000 | |
| DetailsRow | mount | 2188 | 2138 | 5000 | |
| DetailsRowFast | mount | 2136 | 2147 | 5000 | |
| DetailsRowNoStyles | mount | 1989 | 1967 | 5000 | |
| Dialog | mount | 2734 | 2640 | 1000 | |
| DocumentCardTitle | mount | 221 | 212 | 1000 | |
| Dropdown | mount | 1936 | 1957 | 5000 | |
| FocusTrapZone | mount | 1109 | 1118 | 5000 | |
| FocusZone | mount | 1077 | 1046 | 5000 | |
| GroupedList | mount | 40819 | 40917 | 2 | |
| GroupedList | virtual-rerender | 19807 | 19412 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 52436 | 49933 | 2 | |
| GroupedListV2 | mount | 217 | 222 | 2 | |
| GroupedListV2 | virtual-rerender | 196 | 206 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 225 | 225 | 2 | |
| IconButton | mount | 1076 | 1095 | 5000 | |
| Label | mount | 329 | 329 | 5000 | |
| Layer | mount | 2691 | 2733 | 5000 | |
| Link | mount | 392 | 389 | 5000 | |
| MenuButton | mount | 922 | 914 | 5000 | |
| MessageBar | mount | 21296 | 21164 | 5000 | |
| Nav | mount | 1945 | 1902 | 1000 | |
| OverflowSet | mount | 774 | 751 | 5000 | |
| Panel | mount | 2034 | 1759 | 1000 | |
| Persona | mount | 732 | 735 | 1000 | |
| Pivot | mount | 864 | 841 | 1000 | |
| PrimaryButton | mount | 818 | 834 | 5000 | |
| Rating | mount | 4563 | 4636 | 5000 | |
| SearchBox | mount | 900 | 935 | 5000 | |
| Shimmer | mount | 1857 | 1924 | 5000 | |
| Slider | mount | 1286 | 1307 | 5000 | |
| SpinButton | mount | 2827 | 2882 | 5000 | |
| Spinner | mount | 370 | 394 | 5000 | |
| SplitButton | mount | 1774 | 1808 | 5000 | |
| Stack | mount | 396 | 398 | 5000 | |
| StackWithIntrinsicChildren | mount | 854 | 873 | 5000 | |
| StackWithTextChildren | mount | 2588 | 2575 | 5000 | |
| SwatchColorPicker | mount | 5974 | 5956 | 5000 | |
| TagPicker | mount | 1447 | 1411 | 5000 | |
| Text | mount | 374 | 379 | 5000 | |
| TextField | mount | 909 | 936 | 5000 | |
| ThemeProvider | mount | 808 | 826 | 5000 | |
| ThemeProvider | virtual-rerender | 570 | 583 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1275 | 1279 | 5000 | |
| Toggle | mount | 591 | 614 | 5000 | |
| buttonNative | mount | 187 | 183 | 5000 |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Hotell
changed the title
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d33397e28ac542798cfdc4a7b917f1d27db9ed63 (build) |
Hotell
marked this pull request as ready for review
June 13, 2023 17:28
sopranopillow
approved these changes
Jun 13, 2023
Hotell
commented
Jun 14, 2023
Hotell
force-pushed
the
hotell/ci/fix-size-auditor-pipelines-v2
branch
from
June 14, 2023 11:46
c13b1ec to
a17b841
Compare
tudorpopams
self-requested a review
June 14, 2023 12:15
Hotell
force-pushed
the
hotell/ci/fix-size-auditor-pipelines-v2
branch
from
June 14, 2023 12:23
a17b841 to
d033f08
Compare
TristanWatanabe
approved these changes
Jun 15, 2023
TristanWatanabe
added a commit
to TristanWatanabe/fluentui
that referenced
this pull request
Jun 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
affectedapproach on CI ( run only if PR changes are affecting particular package )Related Issue(s)