feat (web-components-v3): Add dedicated vr-tests package and integrate with Visual Regression Pipelines#28222
Merged
TristanWatanabe merged 28 commits intoJun 26, 2023
Conversation
Collaborator
📊 Bundle size reportUnchanged fixtures
|
fabricteam
reviewed
Jun 15, 2023
| @@ -0,0 +1,11 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
🕵 FluentUI-web-components Open the Visual Regressions report to inspect the 4 screenshots
✅ There was 2 screenshots added, 2 screenshots removed, 2 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.
unknown 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Accordion.Accordion With Custom Icons RTL.normal.chromium.png | 0 | Added |
| Accordion.Accordion With Custom Icons.normal.chromium.png | 0 | Added |
| Accordion.Accordion With Custom Icons RTL.chromium.png | 0 | Removed |
| Accordion.Accordion With Custom Icons.chromium.png | 0 | Removed |
Member
Author
There was a problem hiding this comment.
These results of two added and two removed is expected because I ran the baseline pipeline before this PR and i've made changes to the PR examples since then
TristanWatanabe
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1ca3e02:
|
Member
Author
|
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e5d434edb3568ec73d3e18d500169a2ab80cb952 (build) |
TristanWatanabe
marked this pull request as ready for review
June 23, 2023 23:24
TristanWatanabe
requested review from
a team,
JustSlone,
jurokapsiar and
tudorpopams
as code owners
June 23, 2023 23:24
layershifter
approved these changes
Jun 26, 2023
Hotell
approved these changes
Jun 26, 2023
21 tasks
chrisdholt
pushed a commit
that referenced
this pull request
Apr 29, 2024
…e with Visual Regression Pipelines (#28222)
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
…e with Visual Regression Pipelines (microsoft#28222)
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
…e with Visual Regression Pipelines (microsoft#28222)
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 30, 2024
…e with Visual Regression Pipelines (microsoft#28222)
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
…e with Visual Regression Pipelines (#28222)
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
…e with Visual Regression Pipelines (#28222)
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
…e with Visual Regression Pipelines (#28222)
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
…e with Visual Regression Pipelines (#28222)
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
…e with Visual Regression Pipelines (#28222)
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
…e with Visual Regression Pipelines (#28222)
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
…e with Visual Regression Pipelines (#28222)
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
…e with Visual Regression Pipelines (#28222)
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
…e with Visual Regression Pipelines (#28222)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
vr-tests-web-componentspackage similar to v0,v8 and v9. This also runs with@storybook/reactin order to work withStoryWright.Related Issue(s)