bugfix: converts value to be a string instead of a generic value#28257
Merged
bsunderhus merged 2 commits intoJun 26, 2023
Conversation
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender-with-unmount | 69 | 77 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 598 | 588 | 5000 | |
| Button | mount | 296 | 297 | 5000 | |
| Field | mount | 1090 | 1117 | 5000 | |
| FluentProvider | mount | 664 | 665 | 5000 | |
| FluentProviderWithTheme | mount | 77 | 80 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 65 | 62 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 69 | 77 | 10 | Possible regression |
| InfoButton | mount | 13 | 14 | 5000 | |
| MakeStyles | mount | 840 | 843 | 50000 | |
| Persona | mount | 1691 | 1588 | 5000 | |
| SpinButton | mount | 1321 | 1319 | 5000 |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit db3084d:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: df30429eb72b85251e03c5123625820cc8a8b147 (build) |
bsunderhus
marked this pull request as ready for review
June 19, 2023 20:37
bsunderhus
marked this pull request as draft
June 20, 2023 08:45
bsunderhus
force-pushed
the
react-tree/bugfix--ensures-createFlatTreeItems-consistency
branch
2 times, most recently
from
June 20, 2023 09:38
bcd206c to
a8bf1df
Compare
bsunderhus
changed the title
bsunderhus
marked this pull request as ready for review
June 20, 2023 09:48
bsunderhus
force-pushed
the
react-tree/bugfix--ensures-createFlatTreeItems-consistency
branch
from
June 20, 2023 10:11
a8bf1df to
b06d661
Compare
bsunderhus
marked this pull request as draft
June 20, 2023 10:45
bsunderhus
force-pushed
the
react-tree/bugfix--ensures-createFlatTreeItems-consistency
branch
4 times, most recently
from
June 22, 2023 11:53
850b419 to
b0037f3
Compare
bsunderhus
force-pushed
the
react-tree/bugfix--ensures-createFlatTreeItems-consistency
branch
from
June 23, 2023 11:44
b0037f3 to
5c206f2
Compare
bsunderhus
marked this pull request as ready for review
June 23, 2023 18:44
bsunderhus
changed the title
layershifter
approved these changes
Jun 26, 2023
bsunderhus
enabled auto-merge (squash)
June 26, 2023 10:33
bsunderhus
deleted the
react-tree/bugfix--ensures-createFlatTreeItems-consistency
branch
June 26, 2023 11:01
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
createFlatTreeItemswould return a non shallow equivalent value due to the presence of a reference objectcreateFlatTreeItemsNew Behavior
value: string | numberto simplify internals mechanisms, ensuring same accessibility behaviours with a less convoluted code base.createFlatTreeItemsRelated Issue(s)
Fixes issues introduced by #27642, where a reference for each parent tree item was kept.