feat(tools): implement normalize-package-dependencies generator#28382
Merged
Hotell merged 10 commits intoJul 4, 2023
Conversation
Hotell
changed the title
Asset size changes
Baseline commit: 0ff654afb908d00834e2908d0b5daa16856f89a9 (build) |
Collaborator
📊 Bundle size report🤖 This report was generated against 0ff654afb908d00834e2908d0b5daa16856f89a9 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e23ee5e:
|
… installed from npm
… installed from npm
Hotell
marked this pull request as ready for review
July 4, 2023 07:59
Hotell
commented
Jul 4, 2023
ling1726
reviewed
Jul 4, 2023
ling1726
reviewed
Jul 4, 2023
ling1726
reviewed
Jul 4, 2023
ling1726
reviewed
Jul 4, 2023
ling1726
reviewed
Jul 4, 2023
ling1726
approved these changes
Jul 4, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Behavior
new generator implemented with 2 main features:
*as version for inner monorepo dependencies*as version for inner monorepo dependenciesNOTE: a follow up PR will be created that will use this generator to update all apps to use
*for inner workspace deps. Also check will be added to CI to prevent any violations.Why:
no application is being published to npm ever (all application are private), thus there is no reason to provide exact versions for inner workspace dependencies, which creates unnecessary churn and bugs when various libraries are published within monorepo.
NOTE 💡:
*for inner monorepo deps as well some time agoRelated Issue(s)
*#28461