chore(fluent-accordion): Add screenshot tests#28441
Merged
miroslavstastny merged 6 commits intoAug 5, 2023
Merged
Conversation
fabricteam
reviewed
Jul 6, 2023
| @@ -1,3 +1,5 @@ | |||
| import { WCThemeDecorator } from '../src/utilities/WCThemeDecorator' | |||
Collaborator
There was a problem hiding this comment.
🕵 FluentUI-web-components Open the Visual Regressions report to inspect the 15 screenshots
✅ There was 11 screenshots added, 3 screenshots removed, 0 screenshots unchanged, 0 screenshots with different dimensions and 1 screenshots with visible difference.
unknown 15 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Accordion.Accordion With Custom Icons.normal.chromium.png | 1439 | Changed |
| Accordion.Accordion With Custom Icons - Dark Mode.normal.chromium.png | 0 | Added |
| Accordion.Accordion With Custom Icons - RTL.normal.chromium.png | 0 | Added |
| Accordion.Disabled - Dark Mode.normal.chromium.png | 0 | Added |
| Accordion.Disabled - RTL.normal.chromium.png | 0 | Added |
| Accordion.Disabled.normal.chromium.png | 0 | Added |
| Accordion.Expand Icon Position End - Dark Mode.normal.chromium.png | 0 | Added |
| Accordion.Expand Icon Position End - RTL.normal.chromium.png | 0 | Added |
| Accordion.Expand Icon Position End.normal.chromium.png | 0 | Added |
| Accordion.Size - Dark Mode.normal.chromium.png | 0 | Added |
| Accordion.Size - RTL.normal.chromium.png | 0 | Added |
| Accordion.Size.normal.chromium.png | 0 | Added |
| Accordion.Accordion With Custom Icons RTL.normal.chromium.png | 0 | Removed |
| Accordion.Accordion With Custom Icons RTL.opened.chromium.png | 0 | Removed |
| Accordion.Accordion With Custom Icons.opened.chromium.png | 0 | Removed |
Collaborator
📊 Bundle size report🤖 This report was generated against a457b72a901f51caaabceb4e0e32ed98ad559e90 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a457b72a901f51caaabceb4e0e32ed98ad559e90 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4f79a23:
|
levithomason
reviewed
Aug 1, 2023
| }; | ||
|
|
||
| const add20Filled = `<svg width="20" height="20" viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
| const add20Filled = `<svg width="20" height="20" viewBox="0 0 20 20" xmlns="http://www.w3.org/2000/svg" style="fill: currentColor;"> |
Contributor
There was a problem hiding this comment.
This should probably be reverted to match the storybook story?
levithomason
reviewed
Aug 1, 2023
| xmlns="http://www.w3.org/2000/svg" | ||
| style="fill: currentColor;" | ||
| > | ||
| <rect x="3" y="9.25" width="14" height="1.5" rx="0.75" fill="#212121" /> |
levithomason
approved these changes
Aug 1, 2023
miroslavstastny
force-pushed
the
chore/accordion-vr
branch
from
August 5, 2023 05:04
4579573 to
4f79a23
Compare
github-actions
Bot
modified the milestones:
July Project Cycle Q3 2023,
August Project Cycle Q4 2023
fabricteam
reviewed
Aug 5, 2023
| @@ -1,3 +1,5 @@ | |||
| import { WCThemeDecorator } from '../src/utilities/WCThemeDecorator' | |||
Collaborator
There was a problem hiding this comment.
🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots
Accordion 15 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Accordion.Accordion With Custom Icons.normal.chromium.png | 1447 | Changed |
| Accordion.Accordion With Custom Icons - Dark Mode.normal.chromium.png | 0 | Added |
| Accordion.Accordion With Custom Icons - RTL.normal.chromium.png | 0 | Added |
| Accordion.Disabled - Dark Mode.normal.chromium.png | 0 | Added |
| Accordion.Disabled - RTL.normal.chromium.png | 0 | Added |
| Accordion.Disabled.normal.chromium.png | 0 | Added |
| Accordion.Expand Icon Position End - Dark Mode.normal.chromium.png | 0 | Added |
| Accordion.Expand Icon Position End - RTL.normal.chromium.png | 0 | Added |
| Accordion.Expand Icon Position End.normal.chromium.png | 0 | Added |
| Accordion.Size - Dark Mode.normal.chromium.png | 0 | Added |
| Accordion.Size - RTL.normal.chromium.png | 0 | Added |
| Accordion.Size.normal.chromium.png | 0 | Added |
| Accordion.Accordion With Custom Icons RTL.normal.chromium.png | 0 | Removed |
| Accordion.Accordion With Custom Icons RTL.opened.chromium.png | 0 | Removed |
| Accordion.Accordion With Custom Icons.opened.chromium.png | 0 | Removed |
chrisdholt
pushed a commit
that referenced
this pull request
Apr 29, 2024
* chore(fluent-accordion): Add screenshot tests * remove step * add basic support for scoped theming * rewrite the theme decorator to WC * change file * update the vr story to match component story
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* chore(fluent-accordion): Add screenshot tests * remove step * add basic support for scoped theming * rewrite the theme decorator to WC * change file * update the vr story to match component story
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* chore(fluent-accordion): Add screenshot tests * remove step * add basic support for scoped theming * rewrite the theme decorator to WC * change file * update the vr story to match component story
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 30, 2024
* chore(fluent-accordion): Add screenshot tests * remove step * add basic support for scoped theming * rewrite the theme decorator to WC * change file * update the vr story to match component story
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
* chore(fluent-accordion): Add screenshot tests * remove step * add basic support for scoped theming * rewrite the theme decorator to WC * change file * update the vr story to match component story
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* chore(fluent-accordion): Add screenshot tests * remove step * add basic support for scoped theming * rewrite the theme decorator to WC * change file * update the vr story to match component story
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* chore(fluent-accordion): Add screenshot tests * remove step * add basic support for scoped theming * rewrite the theme decorator to WC * change file * update the vr story to match component story
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* chore(fluent-accordion): Add screenshot tests * remove step * add basic support for scoped theming * rewrite the theme decorator to WC * change file * update the vr story to match component story
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
* chore(fluent-accordion): Add screenshot tests * remove step * add basic support for scoped theming * rewrite the theme decorator to WC * change file * update the vr story to match component story
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* chore(fluent-accordion): Add screenshot tests * remove step * add basic support for scoped theming * rewrite the theme decorator to WC * change file * update the vr story to match component story
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* chore(fluent-accordion): Add screenshot tests * remove step * add basic support for scoped theming * rewrite the theme decorator to WC * change file * update the vr story to match component story
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
* chore(fluent-accordion): Add screenshot tests * remove step * add basic support for scoped theming * rewrite the theme decorator to WC * change file * update the vr story to match component story
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
* chore(fluent-accordion): Add screenshot tests * remove step * add basic support for scoped theming * rewrite the theme decorator to WC * change file * update the vr story to match component story
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds VR tests for
fluent-accordionWC.Adds Story decorator which sets light/dark theme and LTR/RTL direction for the story.