Export react-search to unstable#28467
Closed
emmayjiang wants to merge 5 commits into
Closed
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1d971e9:
|
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: c10400fdaf7ff1beef85051ce38b2c6c52b4e2e2 (build) |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
🕵 FluentUI-v0 No visual regressions between this PR and main |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
ling1726
suggested changes
Jul 10, 2023
Contributor
There was a problem hiding this comment.
Please follow the new release process - i.e. in this case publish a package called react-search-preview https://github.com/microsoft/fluentui/wiki/new-release-process---v9-packages#new-processlife-cycle-flow
FYI @Hotell
emmayjiang
requested review from
a team,
JustSlone,
jurokapsiar and
tudorpopams
as code owners
July 10, 2023 17:07
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | mount | 75 | 78 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 68 | 67 | 10 | Possible regression |
| InfoButton | mount | 15 | 12 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 606 | 582 | 5000 | |
| Button | mount | 294 | 307 | 5000 | |
| Field | mount | 1058 | 1050 | 5000 | |
| FluentProvider | mount | 654 | 635 | 5000 | |
| FluentProviderWithTheme | mount | 75 | 78 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 61 | 68 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 68 | 67 | 10 | Possible regression |
| InfoButton | mount | 15 | 12 | 5000 | Possible regression |
| MakeStyles | mount | 855 | 848 | 50000 | |
| Persona | mount | 1664 | 1602 | 5000 | |
| SpinButton | mount | 1332 | 1313 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| RefMinimalPerf.default | 115 | 104 | 1.11:1 |
| ListWith60ListItems.default | 396 | 363 | 1.09:1 |
| AccordionMinimalPerf.default | 83 | 77 | 1.08:1 |
| ImageMinimalPerf.default | 241 | 223 | 1.08:1 |
| PortalMinimalPerf.default | 92 | 85 | 1.08:1 |
| SplitButtonMinimalPerf.default | 2348 | 2217 | 1.06:1 |
| ButtonSlotsPerf.default | 324 | 308 | 1.05:1 |
| LabelMinimalPerf.default | 223 | 213 | 1.05:1 |
| TextAreaMinimalPerf.default | 299 | 285 | 1.05:1 |
| AttachmentSlotsPerf.default | 662 | 637 | 1.04:1 |
| ChatMinimalPerf.default | 442 | 423 | 1.04:1 |
| FlexMinimalPerf.default | 149 | 143 | 1.04:1 |
| FormMinimalPerf.default | 230 | 221 | 1.04:1 |
| HeaderMinimalPerf.default | 209 | 201 | 1.04:1 |
| HeaderSlotsPerf.default | 486 | 474 | 1.03:1 |
| SegmentMinimalPerf.default | 201 | 195 | 1.03:1 |
| SkeletonMinimalPerf.default | 214 | 208 | 1.03:1 |
| TextMinimalPerf.default | 192 | 187 | 1.03:1 |
| CustomToolbarPrototype.default | 1505 | 1461 | 1.03:1 |
| AnimationMinimalPerf.default | 295 | 290 | 1.02:1 |
| CardMinimalPerf.default | 312 | 306 | 1.02:1 |
| ChatDuplicateMessagesPerf.default | 154 | 151 | 1.02:1 |
| CheckboxMinimalPerf.default | 1161 | 1138 | 1.02:1 |
| ListNestedPerf.default | 328 | 320 | 1.02:1 |
| RosterPerf.default | 1540 | 1509 | 1.02:1 |
| TableManyItemsPerf.default | 1130 | 1107 | 1.02:1 |
| ChatWithPopoverPerf.default | 200 | 198 | 1.01:1 |
| DropdownManyItemsPerf.default | 393 | 391 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 706 | 696 | 1.01:1 |
| MenuButtonMinimalPerf.default | 966 | 953 | 1.01:1 |
| TooltipMinimalPerf.default | 1281 | 1271 | 1.01:1 |
| DropdownMinimalPerf.default | 1437 | 1437 | 1:1 |
| EmbedMinimalPerf.default | 1869 | 1865 | 1:1 |
| InputMinimalPerf.default | 536 | 535 | 1:1 |
| LayoutMinimalPerf.default | 201 | 202 | 1:1 |
| ListMinimalPerf.default | 311 | 311 | 1:1 |
| ProviderMergeThemesPerf.default | 664 | 664 | 1:1 |
| IconMinimalPerf.default | 377 | 376 | 1:1 |
| ToolbarMinimalPerf.default | 528 | 529 | 1:1 |
| BoxMinimalPerf.default | 195 | 196 | 0.99:1 |
| ButtonOverridesMissPerf.default | 651 | 658 | 0.99:1 |
| CarouselMinimalPerf.default | 256 | 259 | 0.99:1 |
| DatepickerMinimalPerf.default | 3631 | 3667 | 0.99:1 |
| DividerMinimalPerf.default | 212 | 214 | 0.99:1 |
| SliderMinimalPerf.default | 732 | 736 | 0.99:1 |
| StatusMinimalPerf.default | 386 | 388 | 0.99:1 |
| TreeMinimalPerf.default | 476 | 481 | 0.99:1 |
| ButtonMinimalPerf.default | 90 | 92 | 0.98:1 |
| DialogMinimalPerf.default | 450 | 459 | 0.98:1 |
| GridMinimalPerf.default | 187 | 191 | 0.98:1 |
| PopupMinimalPerf.default | 349 | 356 | 0.98:1 |
| RadioGroupMinimalPerf.default | 258 | 262 | 0.98:1 |
| VideoMinimalPerf.default | 426 | 435 | 0.98:1 |
| AvatarMinimalPerf.default | 104 | 107 | 0.97:1 |
| ListCommonPerf.default | 375 | 385 | 0.97:1 |
| MenuMinimalPerf.default | 482 | 499 | 0.97:1 |
| ReactionMinimalPerf.default | 204 | 211 | 0.97:1 |
| TableMinimalPerf.default | 226 | 233 | 0.97:1 |
| ProviderMinimalPerf.default | 203 | 214 | 0.95:1 |
| AlertMinimalPerf.default | 152 | 161 | 0.94:1 |
| TreeWith60ListItems.default | 78 | 83 | 0.94:1 |
| LoaderMinimalPerf.default | 175 | 190 | 0.92:1 |
| AttachmentMinimalPerf.default | 75 | 84 | 0.89:1 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 618 | 634 | 5000 | |
| Breadcrumb | mount | 1662 | 1649 | 1000 | |
| Checkbox | mount | 1654 | 1670 | 5000 | |
| CheckboxBase | mount | 1505 | 1484 | 5000 | |
| ChoiceGroup | mount | 2903 | 2898 | 5000 | |
| ComboBox | mount | 642 | 636 | 1000 | |
| CommandBar | mount | 6100 | 6186 | 1000 | |
| ContextualMenu | mount | 11724 | 11742 | 1000 | |
| DefaultButton | mount | 740 | 728 | 5000 | |
| DetailsRow | mount | 2117 | 2139 | 5000 | |
| DetailsRowFast | mount | 2160 | 2151 | 5000 | |
| DetailsRowNoStyles | mount | 2003 | 1988 | 5000 | |
| Dialog | mount | 2715 | 2739 | 1000 | |
| DocumentCardTitle | mount | 223 | 227 | 1000 | |
| Dropdown | mount | 1986 | 1919 | 5000 | |
| FocusTrapZone | mount | 1096 | 1142 | 5000 | |
| FocusZone | mount | 1029 | 1038 | 5000 | |
| GroupedList | mount | 41097 | 40806 | 2 | |
| GroupedList | virtual-rerender | 19836 | 19615 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 49927 | 50066 | 2 | |
| GroupedListV2 | mount | 223 | 223 | 2 | |
| GroupedListV2 | virtual-rerender | 209 | 205 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 218 | 226 | 2 | |
| IconButton | mount | 1111 | 1062 | 5000 | |
| Label | mount | 339 | 338 | 5000 | |
| Layer | mount | 2696 | 2719 | 5000 | |
| Link | mount | 380 | 384 | 5000 | |
| MenuButton | mount | 925 | 926 | 5000 | |
| MessageBar | mount | 21723 | 21366 | 5000 | |
| Nav | mount | 1896 | 1906 | 1000 | |
| OverflowSet | mount | 780 | 770 | 5000 | |
| Panel | mount | 1775 | 1750 | 1000 | |
| Persona | mount | 747 | 735 | 1000 | |
| Pivot | mount | 870 | 872 | 1000 | |
| PrimaryButton | mount | 850 | 820 | 5000 | |
| Rating | mount | 4537 | 4524 | 5000 | |
| SearchBox | mount | 906 | 880 | 5000 | |
| Shimmer | mount | 1852 | 1838 | 5000 | |
| Slider | mount | 1318 | 1298 | 5000 | |
| SpinButton | mount | 2831 | 2836 | 5000 | |
| Spinner | mount | 371 | 374 | 5000 | |
| SplitButton | mount | 1787 | 1812 | 5000 | |
| Stack | mount | 410 | 410 | 5000 | |
| StackWithIntrinsicChildren | mount | 856 | 859 | 5000 | |
| StackWithTextChildren | mount | 2572 | 2600 | 5000 | |
| SwatchColorPicker | mount | 5986 | 6024 | 5000 | |
| TagPicker | mount | 1394 | 1450 | 5000 | |
| Text | mount | 362 | 366 | 5000 | |
| TextField | mount | 963 | 1160 | 5000 | |
| ThemeProvider | mount | 828 | 824 | 5000 | |
| ThemeProvider | virtual-rerender | 583 | 594 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1291 | 1274 | 5000 | |
| Toggle | mount | 605 | 607 | 5000 | |
| buttonNative | mount | 198 | 191 | 5000 |
Contributor
Author
| import { Steps, StoryWright } from 'storywright'; | ||
| import { storiesOf } from '@storybook/react'; | ||
| import { SearchBox } from '@fluentui/react-search'; | ||
| import { SearchBox } from '@fluentui/react-search-preview'; |
Member
There was a problem hiding this comment.
I didn't think we changed the package name for preview. Rather we export it from the unstable part of react-components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exports react-search to unstable, as part of #26648.