Skip to content

Made BreadcrumbButton consistent with Item and Link#28672

Merged
ValentinaKozlova merged 2 commits into
microsoft:masterfrom
ValentinaKozlova:fix/breadcrumb-button-width
Aug 3, 2023
Merged

Made BreadcrumbButton consistent with Item and Link#28672
ValentinaKozlova merged 2 commits into
microsoft:masterfrom
ValentinaKozlova:fix/breadcrumb-button-width

Conversation

@ValentinaKozlova

@ValentinaKozlova ValentinaKozlova commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

Previous Behavior

image

New Behavior

image

@codesandbox-ci

codesandbox-ci Bot commented Jul 28, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b5dfe9c:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam

fabricteam commented Jul 28, 2023

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against 495a08579f2d16f082f2b18c299f1a647906b236

@size-auditor

size-auditor Bot commented Jul 28, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ede28fe6d1d1ce394c6f019bd424ec8b14ca9d12 (build)

@ValentinaKozlova
ValentinaKozlova force-pushed the fix/breadcrumb-button-width branch from 01ba7c4 to b5dfe9c Compare August 2, 2023 15:02
@ValentinaKozlova
ValentinaKozlova marked this pull request as ready for review August 2, 2023 15:03
@ValentinaKozlova
ValentinaKozlova requested a review from a team as a code owner August 2, 2023 15:03
@tudorpopams
tudorpopams requested a review from marcosmoura August 3, 2023 12:21
@ValentinaKozlova
ValentinaKozlova merged commit d445789 into microsoft:master Aug 3, 2023
@ValentinaKozlova
ValentinaKozlova deleted the fix/breadcrumb-button-width branch August 3, 2023 16:29
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Aug 7, 2023
* master:
  chore(cxe-prg): migrate to new slot API (microsoft#28752)
  chore(teams-prg): migrate to new slot API (microsoft#28751)
  chore: re-export slot and assertSlots methods (microsoft#28755)
  Docs(react-tree): Improve docs and stories (microsoft#28741)
  feat: implements nested tree selection (microsoft#28668)
  applying package updates
  applying package updates
  feature(react-utilities): implements new slot methods (`slot` and `assertSlots`) (microsoft#28373)
  fix(TimePicker): Selection now works in locales that don't use "am"/"pm" in their time format (microsoft#28469)
  bugfix: ensures controlled state works properly + (microsoft#28665)
  feat(tokens): Add status color tokens (microsoft#28006)
  feat(tokens): Add colorBrandStroke2Contrast and colorNeutralStrokeAlpha2 (microsoft#28638)
  Made BreadcrumbButton consistent with Item and Link (microsoft#28672)
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Aug 7, 2023
* master:
  chore(cxe-prg): migrate to new slot API (microsoft#28752)
  chore(teams-prg): migrate to new slot API (microsoft#28751)
  chore: re-export slot and assertSlots methods (microsoft#28755)
  Docs(react-tree): Improve docs and stories (microsoft#28741)
  feat: implements nested tree selection (microsoft#28668)
  applying package updates
  applying package updates
  feature(react-utilities): implements new slot methods (`slot` and `assertSlots`) (microsoft#28373)
  fix(TimePicker): Selection now works in locales that don't use "am"/"pm" in their time format (microsoft#28469)
  bugfix: ensures controlled state works properly + (microsoft#28665)
  feat(tokens): Add status color tokens (microsoft#28006)
  feat(tokens): Add colorBrandStroke2Contrast and colorNeutralStrokeAlpha2 (microsoft#28638)
  Made BreadcrumbButton consistent with Item and Link (microsoft#28672)
  fix(EventListener): do not use `defaultProps` (microsoft#28725)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants