chore(menu-list): Add screenshot tests#28864
Merged
miroslavstastny merged 2 commits intoAug 22, 2023
Merged
Conversation
21 tasks
fabricteam
reviewed
Aug 15, 2023
| @@ -0,0 +1,194 @@ | |||
| import * as React from 'react'; | |||
Collaborator
There was a problem hiding this comment.
🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots
MenuList 47 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| MenuList.Checkbox - Dark Mode.1st selected.chromium.png | 0 | Added |
| MenuList.Checkbox - Dark Mode.2nd selected.chromium.png | 0 | Added |
| MenuList.Checkbox - Dark Mode.normal.chromium.png | 0 | Added |
| MenuList.Checkbox - RTL.1st selected.chromium.png | 0 | Added |
| MenuList.Checkbox - RTL.2nd selected.chromium.png | 0 | Added |
| MenuList.Checkbox - RTL.normal.chromium.png | 0 | Added |
| MenuList.Checkbox With Icons - RTL.1st selected.chromium.png | 0 | Added |
| MenuList.Checkbox With Icons - RTL.2nd selected.chromium.png | 0 | Added |
| MenuList.Checkbox With Icons - RTL.normal.chromium.png | 0 | Added |
| MenuList.Checkbox With Icons.1st selected.chromium.png | 0 | Added |
| MenuList.Checkbox With Icons.2nd selected.chromium.png | 0 | Added |
| MenuList.Checkbox With Icons.normal.chromium.png | 0 | Added |
| MenuList.Checkbox.1st selected.chromium.png | 0 | Added |
| MenuList.Checkbox.2nd selected.chromium.png | 0 | Added |
| MenuList.Checkbox.normal.chromium.png | 0 | Added |
| MenuList.Default - Dark Mode.hover menuitem.chromium.png | 0 | Added |
| MenuList.Default - Dark Mode.normal.chromium.png | 0 | Added |
| MenuList.Default - RTL.hover menuitem.chromium.png | 0 | Added |
| MenuList.Default - RTL.normal.chromium.png | 0 | Added |
| MenuList.Default.hover menuitem.chromium.png | 0 | Added |
| MenuList.Default.normal.chromium.png | 0 | Added |
| MenuList.Radio - Dark Mode.1st selected.chromium.png | 0 | Added |
| MenuList.Radio - Dark Mode.2nd selected.chromium.png | 0 | Added |
| MenuList.Radio - Dark Mode.normal.chromium.png | 0 | Added |
| MenuList.Radio - RTL.1st selected.chromium.png | 0 | Added |
| MenuList.Radio - RTL.2nd selected.chromium.png | 0 | Added |
| MenuList.Radio - RTL.normal.chromium.png | 0 | Added |
| MenuList.Radio With Icons - RTL.1st selected.chromium.png | 0 | Added |
| MenuList.Radio With Icons - RTL.2nd selected.chromium.png | 0 | Added |
| MenuList.Radio With Icons - RTL.normal.chromium.png | 0 | Added |
| MenuList.Radio With Icons.1st selected.chromium.png | 0 | Added |
| MenuList.Radio With Icons.2nd selected.chromium.png | 0 | Added |
| MenuList.Radio With Icons.normal.chromium.png | 0 | Added |
| MenuList.Radio.1st selected.chromium.png | 0 | Added |
| MenuList.Radio.2nd selected.chromium.png | 0 | Added |
| MenuList.Radio.normal.chromium.png | 0 | Added |
| MenuList.With Icons.hover menuitem.chromium.png | 0 | Added |
| MenuList.With Icons.normal.chromium.png | 0 | Added |
| MenuList.With Submenu - Dark Mode.1st selected.chromium.png | 0 | Added |
| MenuList.With Submenu - Dark Mode.2nd selected.chromium.png | 0 | Added |
| MenuList.With Submenu - Dark Mode.normal.chromium.png | 0 | Added |
| MenuList.With Submenu - RTL.1st selected.chromium.png | 0 | Added |
| MenuList.With Submenu - RTL.2nd selected.chromium.png | 0 | Added |
| MenuList.With Submenu - RTL.normal.chromium.png | 0 | Added |
| MenuList.With Submenu.1st selected.chromium.png | 0 | Added |
| MenuList.With Submenu.2nd selected.chromium.png | 0 | Added |
| MenuList.With Submenu.normal.chromium.png | 0 | Added |
Collaborator
📊 Bundle size report🤖 This report was generated against 6532f2f144aa098478278dee3ee83c8150cb688e |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 78c032fdc0ba9a2d96d3e15683506b66d53d0a08 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9c2ac3a:
|
miroslavstastny
force-pushed
the
chore/vr-menu-list
branch
from
August 21, 2023 23:37
2ceb389 to
9c2ac3a
Compare
Member
Author
|
Incorrect position of a submenu on first render in RTL: #28936 |
chrisdholt
pushed a commit
that referenced
this pull request
Apr 29, 2024
* chore(menu-list): Add screenshot tests * node16 module resolution
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* chore(menu-list): Add screenshot tests * node16 module resolution
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* chore(menu-list): Add screenshot tests * node16 module resolution
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 30, 2024
* chore(menu-list): Add screenshot tests * node16 module resolution
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
* chore(menu-list): Add screenshot tests * node16 module resolution
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* chore(menu-list): Add screenshot tests * node16 module resolution
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* chore(menu-list): Add screenshot tests * node16 module resolution
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* chore(menu-list): Add screenshot tests * node16 module resolution
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
* chore(menu-list): Add screenshot tests * node16 module resolution
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* chore(menu-list): Add screenshot tests * node16 module resolution
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* chore(menu-list): Add screenshot tests * node16 module resolution
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
* chore(menu-list): Add screenshot tests * node16 module resolution
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
* chore(menu-list): Add screenshot tests * node16 module resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add screenshot tests for
fluent-menu-list