Skip to content

chore(react-nav-preview): migrates to use new slot API#28917

Merged
bsunderhus merged 1 commit into
microsoft:masterfrom
bsunderhus:react-nav-preview/chore--migrates-to-use-new-slot-API
Aug 22, 2023
Merged

chore(react-nav-preview): migrates to use new slot API#28917
bsunderhus merged 1 commit into
microsoft:masterfrom
bsunderhus:react-nav-preview/chore--migrates-to-use-new-slot-API

Conversation

@bsunderhus

@bsunderhus bsunderhus commented Aug 21, 2023

Copy link
Copy Markdown
Contributor

Previous Behavior

New Behavior

Seems like this package has been scaffolded after the new slot API has been implemented, but before updating the scaffolding tools 🙈 (#28916)

  1. migrates to use the new slot API

Related Issue(s)

  • Fixes #

@bsunderhus bsunderhus self-assigned this Aug 21, 2023
@github-actions github-actions Bot added this to the August Project Cycle Q4 2023 milestone Aug 21, 2023
@fabricteam

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against 768de13c5e30222f64b2cc453bc4b134a6e90712

@bsunderhus
bsunderhus marked this pull request as ready for review August 21, 2023 09:19
@bsunderhus
bsunderhus requested review from a team and mltejera as code owners August 21, 2023 09:19
@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 01f21f4:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor

size-auditor Bot commented Aug 21, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 768de13c5e30222f64b2cc453bc4b134a6e90712 (build)

@bsunderhus
bsunderhus merged commit d0e65ba into microsoft:master Aug 22, 2023
@bsunderhus
bsunderhus deleted the react-nav-preview/chore--migrates-to-use-new-slot-API branch August 22, 2023 07:18
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Aug 22, 2023
* master:
  chore: updates generator to use new slot API (microsoft#28916)
  chore: bumps version of esbuild-loader to v3.2.0 (microsoft#28878)
  chore(react-nav-preview): migrates to use new slot API (microsoft#28917)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants