chore: migrate to use JSX importSource#28943
Closed
bsunderhus wants to merge 1 commit into
Closed
Conversation
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 624 | 629 | 5000 | |
| Button | mount | 315 | 312 | 5000 | |
| Field | mount | 1114 | 1126 | 5000 | |
| FluentProvider | mount | 688 | 695 | 5000 | |
| FluentProviderWithTheme | mount | 83 | 79 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 68 | 64 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 80 | 81 | 10 | |
| InfoButton | mount | 16 | 11 | 5000 | |
| MakeStyles | mount | 857 | 866 | 50000 | |
| Persona | mount | 1715 | 1685 | 5000 | |
| SpinButton | mount | 1327 | 1347 | 5000 |
Collaborator
📊 Bundle size report
🤖 This report was generated against f94b6d05d7642563cb96e2718402fbbbab65cbbc |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
bsunderhus
force-pushed
the
react-dialog/chore--migrate-to-use-jsx-import-source
branch
from
August 23, 2023 11:48
98389f3 to
2438cb8
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Previously
@fluentui/react-dialogused to use classic pragma instead of JSX importSourceNew Behavior
Related Issue(s)