Skip to content

Exported DataGridContextProvider and useDataGridContext_unstable hook#28945

Closed
jvince wants to merge 1 commit into
microsoft:masterfrom
jvince:feature/export-datagrid-context
Closed

Exported DataGridContextProvider and useDataGridContext_unstable hook#28945
jvince wants to merge 1 commit into
microsoft:masterfrom
jvince:feature/export-datagrid-context

Conversation

@jvince

@jvince jvince commented Aug 22, 2023

Copy link
Copy Markdown

Exported DataGridContextProvider and useDataGridContext_unstable hook.

Previous Behavior

The library didn't export the context provider and its associated hooks.

New Behavior

The library exports the context provider and its associated hooks.

Related Issue(s)

@jvince
jvince requested a review from a team as a code owner August 22, 2023 13:10
@ling1726

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 4 pipeline(s).

@fabricteam

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme mount 73 75 10 Possible regression
InfoButton mount 12 12 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 606 646 5000
Button mount 337 312 5000
Field mount 1126 1126 5000
FluentProvider mount 685 697 5000
FluentProviderWithTheme mount 73 75 10 Possible regression
FluentProviderWithTheme virtual-rerender 65 64 10
FluentProviderWithTheme virtual-rerender-with-unmount 74 75 10
InfoButton mount 12 12 5000 Possible regression
MakeStyles mount 874 892 50000
Persona mount 1732 1670 5000
SpinButton mount 1413 1394 5000

@fabricteam

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against bf1049c8e38e7b11f6f042fdccf0f16746b4b6b7

@fabricteam

Copy link
Copy Markdown
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@jvince

jvince commented Aug 23, 2023

Copy link
Copy Markdown
Author

Fixed by #28955

@jvince jvince closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Export DataGrid context.

3 participants