Adjusting Azure Colors to address DetailsList, Spinner, and Link#29133
Merged
Conversation
…t fix and address spinner bug in light theme only
Collaborator
📊 Bundle size report🤖 This report was generated against d58a480cbe6de091979c053daaa1c4853a734498 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit eef9195:
|
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Jacqueline-ms
commented
Sep 12, 2023
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d58a480cbe6de091979c053daaa1c4853a734498 (build) |
…ft/fluentui into jackieg/spinner_link_fix
spmonahan
approved these changes
Sep 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swapping accent and focus values for control outlines to address bugs in DetailsList (maintaining fix from previous PR) and Spinner.
Previous Behavior
Fix from #28966 resulted in the following bug for spinner.
New Behavior
Spinner was not included in our storybook, I have since added and will be auditing other possible missing controls to avoid introducing bugs in the future.
Maintained previous PR fix for focus row in DetailsList
#29133
themePrimary is back to Azure blue.