A11y: Fix aria attribute for page number and add correct role#29154
Closed
amreladawy wants to merge 12 commits into
Closed
A11y: Fix aria attribute for page number and add correct role#29154amreladawy wants to merge 12 commits into
amreladawy wants to merge 12 commits into
Conversation
aria-selected is a wrong attribute for button. The correct attribute is aria-checked. Also, added role radio to reflect the correct role of this pagination.
Update PageNumber.tsx
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 76c0926:
|
amreladawy
changed the title
behowell
approved these changes
Sep 29, 2023
add role="radiogroup" to parent of PageNumber
Contributor
Author
|
Updated the parent control and added role="radiogroup" |
behowell
enabled auto-merge (squash)
September 29, 2023 22:09
auto-merge was automatically disabled
September 29, 2023 22:15
Head branch was pushed to by a user without write access
Contributor
Author
|
Closed and raised another PR #29349 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run FastPass on Paginating control.
It will report an error that aria-selected is a wrong attribute for page number button. The correct attribute is aria-checked. Also, added role radio to reflect the correct role of this pagination.
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-selected
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-checked
Previous Behavior
The pagination buttons have the wrong aria attribute and fail a11y test tool by Microsoft.
New Behavior
The buttons have the correct aria-checked and correct role
Related Issue(s)