Skip to content

docs(react-drawer): update description on how to prevent drawer from closing#29218

Merged
marcosmoura merged 3 commits into
microsoft:masterfrom
marcosmoura:docs/react-drawer/add-better-explanation-for-always-open-drawer
Sep 25, 2023
Merged

docs(react-drawer): update description on how to prevent drawer from closing#29218
marcosmoura merged 3 commits into
microsoft:masterfrom
marcosmoura:docs/react-drawer/add-better-explanation-for-always-open-drawer

Conversation

@marcosmoura

Copy link
Copy Markdown
Contributor

@marcosmoura
marcosmoura requested a review from a team as a code owner September 21, 2023 13:44
@marcosmoura marcosmoura self-assigned this Sep 21, 2023
@marcosmoura marcosmoura added the Component: Drawer The Fluent v9 Drawer component label Sep 21, 2023
@fabricteam

fabricteam commented Sep 21, 2023

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 621 642 5000
Button mount 317 308 5000
Field mount 1078 1137 5000
FluentProvider mount 688 718 5000
FluentProviderWithTheme mount 80 82 10
FluentProviderWithTheme virtual-rerender 64 59 10
FluentProviderWithTheme virtual-rerender-with-unmount 86 69 10
InfoButton mount 13 15 5000
MakeStyles mount 854 866 50000
Persona mount 1765 1730 5000
SpinButton mount 1371 1357 5000

@codesandbox-ci

codesandbox-ci Bot commented Sep 21, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9b2beb9:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam

fabricteam commented Sep 21, 2023

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.572 kB
19.658 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
208.688 kB
59.552 kB
react-components
react-components: FluentProvider & webLightTheme
40.966 kB
13.569 kB
react-portal-compat
PortalCompatProvider
6.541 kB
2.227 kB
🤖 This report was generated against c9b7dde0872c3fe5a639165a8f507b6099daed7f

@size-auditor

size-auditor Bot commented Sep 21, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: c9b7dde0872c3fe5a639165a8f507b6099daed7f (build)

@marcosmoura
marcosmoura enabled auto-merge (squash) September 22, 2023 12:48
@marcosmoura
marcosmoura merged commit 3056ec3 into microsoft:master Sep 25, 2023
@marcosmoura
marcosmoura deleted the docs/react-drawer/add-better-explanation-for-always-open-drawer branch September 25, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Drawer The Fluent v9 Drawer component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drawer with modalType="alert" should be dismissible with Escape

3 participants