fix(react-tags-preview): remove disabled InteractionTag hover color under WHCM#29275
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7b5e285:
|
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a56c408d4ed860a48e22780289e5c4a00ebec6c4 (build) |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
ling1726
approved these changes
Sep 25, 2023
YuanboXue-Amber
force-pushed
the
tag-hc
branch
from
September 25, 2023 12:44
538bf50 to
cb6dfbf
Compare
YuanboXue-Amber
removed
Area: Build System
Component: Pivot
Component: Pickers
Component: Button
Component: Checkbox
Component: Toggle
Component: Slider
Package: charting
Area: Website
Component: Link
Package: experiments
Area: Icons
Package: date-time
Package: styling
PR: API Modified
Package: react-monaco-editor
web-components
Component: Avatar
Fluent UI react-northstar
Component: $1
labels
YuanboXue-Amber
enabled auto-merge (squash)
September 25, 2023 13:14
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 25, 2023
…l-to-composition * master: feat: FlatTree supports navigation without useHeadlessFlatTree (microsoft#29091) fix(react-card): sync controllable state for selectable cards (microsoft#29276) fix (microsoft#29275)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #29224.
PR #29035 added WHCM background color on hover to InteractionTag, increasing its contrast. However it changed disabled InteractionTag as well.
This PR removes hover background for disabled InteractionTag, and keep the hover background only for normal InteractionTag.
Before:
After (no hover style):
Normal InteractionTag stays the same:
