chore: use TsconfigPathsPlugin in cypress test config#29327
Merged
Conversation
Cypress test config previously did not use TsConfigPathsPlugin so it relied on code being built in CI. However there is an edge case encountered in microsoft#29313. Lage will run the cypress tests of depednencies which *_can depend on depedencies not in the package.json tree_* 💣💣 ``` - react-message-bar-preview - react-button - react-tabster - react-provider (not in package.json, but used in cypress test) ```
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender-with-unmount | 73 | 76 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 611 | 613 | 5000 | |
| Button | mount | 291 | 320 | 5000 | |
| Field | mount | 1111 | 1084 | 5000 | |
| FluentProvider | mount | 683 | 691 | 5000 | |
| FluentProviderWithTheme | mount | 80 | 77 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 67 | 70 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 73 | 76 | 10 | Possible regression |
| InfoButton | mount | 11 | 12 | 5000 | |
| MakeStyles | mount | 827 | 845 | 50000 | |
| Persona | mount | 1671 | 1659 | 5000 | |
| SpinButton | mount | 1354 | 1345 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 70bd763:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 22f66ce91e429a1a2d31e0a9138715711fe9210d (build) |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
TristanWatanabe
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cypress test config previously did not use TsConfigPathsPlugin so it relied on code being built in CI. This is a similar approach to our storybook config
However there is an edge case encountered in #29313. Lage will run the cypress tests of depednencies which can depend on depedencies not in the package.json tree 💣💣