fix(CI): increase pipeline agent timeout threshold #29710
Merged
TristanWatanabe merged 4 commits intoNov 1, 2023
Merged
Conversation
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 648 | 631 | 5000 | |
| Button | mount | 321 | 317 | 5000 | |
| Field | mount | 1138 | 1140 | 5000 | |
| FluentProvider | mount | 730 | 722 | 5000 | |
| FluentProviderWithTheme | mount | 75 | 84 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 68 | 61 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 77 | 10 | |
| MakeStyles | mount | 855 | 860 | 50000 | |
| Persona | mount | 1777 | 1775 | 5000 | |
| SpinButton | mount | 1386 | 1344 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5a50dfb:
|
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| AttachmentMinimalPerf.default | 81 | 76 | 1.07:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| VideoMinimalPerf.default | 446 | 407 | 1.1:1 |
| LoaderMinimalPerf.default | 203 | 186 | 1.09:1 |
| RosterPerf.default | 1616 | 1492 | 1.08:1 |
| CardMinimalPerf.default | 320 | 298 | 1.07:1 |
| PortalMinimalPerf.default | 91 | 85 | 1.07:1 |
| RadioGroupMinimalPerf.default | 264 | 246 | 1.07:1 |
| CarouselMinimalPerf.default | 269 | 254 | 1.06:1 |
| ListNestedPerf.default | 326 | 308 | 1.06:1 |
| ButtonMinimalPerf.default | 88 | 84 | 1.05:1 |
| DividerMinimalPerf.default | 203 | 193 | 1.05:1 |
| SkeletonMinimalPerf.default | 200 | 191 | 1.05:1 |
| ButtonSlotsPerf.default | 315 | 302 | 1.04:1 |
| GridMinimalPerf.default | 187 | 179 | 1.04:1 |
| TableMinimalPerf.default | 232 | 223 | 1.04:1 |
| ButtonOverridesMissPerf.default | 662 | 640 | 1.03:1 |
| LabelMinimalPerf.default | 220 | 213 | 1.03:1 |
| StatusMinimalPerf.default | 405 | 393 | 1.03:1 |
| IconMinimalPerf.default | 400 | 388 | 1.03:1 |
| TextMinimalPerf.default | 191 | 185 | 1.03:1 |
| AnimationMinimalPerf.default | 297 | 290 | 1.02:1 |
| AttachmentSlotsPerf.default | 640 | 629 | 1.02:1 |
| BoxMinimalPerf.default | 191 | 187 | 1.02:1 |
| ChatDuplicateMessagesPerf.default | 154 | 151 | 1.02:1 |
| CheckboxMinimalPerf.default | 1137 | 1113 | 1.02:1 |
| DropdownManyItemsPerf.default | 395 | 388 | 1.02:1 |
| ListMinimalPerf.default | 318 | 312 | 1.02:1 |
| TooltipMinimalPerf.default | 1291 | 1262 | 1.02:1 |
| DatepickerMinimalPerf.default | 3612 | 3574 | 1.01:1 |
| EmbedMinimalPerf.default | 1900 | 1876 | 1.01:1 |
| FormMinimalPerf.default | 222 | 219 | 1.01:1 |
| ProviderMergeThemesPerf.default | 631 | 626 | 1.01:1 |
| SegmentMinimalPerf.default | 196 | 194 | 1.01:1 |
| SliderMinimalPerf.default | 722 | 716 | 1.01:1 |
| TableManyItemsPerf.default | 1111 | 1098 | 1.01:1 |
| TextAreaMinimalPerf.default | 283 | 279 | 1.01:1 |
| HeaderSlotsPerf.default | 458 | 460 | 1:1 |
| ImageMinimalPerf.default | 220 | 221 | 1:1 |
| InputMinimalPerf.default | 545 | 545 | 1:1 |
| ItemLayoutMinimalPerf.default | 729 | 730 | 1:1 |
| ListWith60ListItems.default | 358 | 358 | 1:1 |
| MenuMinimalPerf.default | 496 | 497 | 1:1 |
| ToolbarMinimalPerf.default | 529 | 529 | 1:1 |
| DialogMinimalPerf.default | 436 | 439 | 0.99:1 |
| ListCommonPerf.default | 385 | 387 | 0.99:1 |
| PopupMinimalPerf.default | 345 | 349 | 0.99:1 |
| SplitButtonMinimalPerf.default | 2198 | 2219 | 0.99:1 |
| CustomToolbarPrototype.default | 1492 | 1501 | 0.99:1 |
| DropdownMinimalPerf.default | 1411 | 1440 | 0.98:1 |
| MenuButtonMinimalPerf.default | 948 | 968 | 0.98:1 |
| TreeMinimalPerf.default | 474 | 486 | 0.98:1 |
| AlertMinimalPerf.default | 155 | 159 | 0.97:1 |
| FlexMinimalPerf.default | 154 | 158 | 0.97:1 |
| AccordionMinimalPerf.default | 76 | 79 | 0.96:1 |
| ChatMinimalPerf.default | 430 | 447 | 0.96:1 |
| LayoutMinimalPerf.default | 193 | 201 | 0.96:1 |
| TreeWith60ListItems.default | 82 | 85 | 0.96:1 |
| ChatWithPopoverPerf.default | 180 | 189 | 0.95:1 |
| RefMinimalPerf.default | 105 | 110 | 0.95:1 |
| HeaderMinimalPerf.default | 208 | 221 | 0.94:1 |
| ReactionMinimalPerf.default | 214 | 227 | 0.94:1 |
| AvatarMinimalPerf.default | 108 | 116 | 0.93:1 |
| ProviderMinimalPerf.default | 187 | 203 | 0.92:1 |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 88574cc717e7bffe6f8f0f5fce191350066e7a62 (build) |
khmakoto
approved these changes
Oct 31, 2023
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 636 | 632 | 5000 | |
| Breadcrumb | mount | 1659 | 1663 | 1000 | |
| Checkbox | mount | 1692 | 1677 | 5000 | |
| CheckboxBase | mount | 1428 | 1502 | 5000 | |
| ChoiceGroup | mount | 2949 | 2926 | 5000 | |
| ComboBox | mount | 644 | 677 | 1000 | |
| CommandBar | mount | 6179 | 6196 | 1000 | |
| ContextualMenu | mount | 11862 | 12064 | 1000 | |
| DefaultButton | mount | 745 | 741 | 5000 | |
| DetailsRow | mount | 2180 | 2186 | 5000 | |
| DetailsRowFast | mount | 2171 | 2191 | 5000 | |
| DetailsRowNoStyles | mount | 2056 | 1998 | 5000 | |
| Dialog | mount | 2767 | 2642 | 1000 | |
| DocumentCardTitle | mount | 229 | 236 | 1000 | |
| Dropdown | mount | 1954 | 2004 | 5000 | |
| FocusTrapZone | mount | 1129 | 1116 | 5000 | |
| FocusZone | mount | 1080 | 1057 | 5000 | |
| GroupedList | mount | 41145 | 41686 | 2 | |
| GroupedList | virtual-rerender | 19832 | 19946 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51056 | 50619 | 2 | |
| GroupedListV2 | mount | 226 | 233 | 2 | |
| GroupedListV2 | virtual-rerender | 214 | 209 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 242 | 216 | 2 | |
| IconButton | mount | 1067 | 1092 | 5000 | |
| Label | mount | 346 | 337 | 5000 | |
| Layer | mount | 2717 | 2777 | 5000 | |
| Link | mount | 398 | 394 | 5000 | |
| MenuButton | mount | 962 | 965 | 5000 | |
| MessageBar | mount | 21573 | 21566 | 5000 | |
| Nav | mount | 1924 | 1947 | 1000 | |
| OverflowSet | mount | 784 | 787 | 5000 | |
| Panel | mount | 1837 | 1820 | 1000 | |
| Persona | mount | 733 | 740 | 1000 | |
| Pivot | mount | 902 | 879 | 1000 | |
| PrimaryButton | mount | 846 | 839 | 5000 | |
| Rating | mount | 4604 | 4681 | 5000 | |
| SearchBox | mount | 961 | 905 | 5000 | |
| Shimmer | mount | 1868 | 1866 | 5000 | |
| Slider | mount | 1349 | 1324 | 5000 | |
| SpinButton | mount | 2927 | 2867 | 5000 | |
| Spinner | mount | 382 | 407 | 5000 | |
| SplitButton | mount | 1852 | 1844 | 5000 | |
| Stack | mount | 400 | 419 | 5000 | |
| StackWithIntrinsicChildren | mount | 854 | 841 | 5000 | |
| StackWithTextChildren | mount | 2623 | 2619 | 5000 | |
| SwatchColorPicker | mount | 6210 | 6111 | 5000 | |
| TagPicker | mount | 1456 | 1489 | 5000 | |
| Text | mount | 371 | 382 | 5000 | |
| TextField | mount | 942 | 946 | 5000 | |
| ThemeProvider | mount | 813 | 830 | 5000 | |
| ThemeProvider | virtual-rerender | 593 | 585 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1269 | 1272 | 5000 | |
| Toggle | mount | 633 | 633 | 5000 | |
| buttonNative | mount | 194 | 197 | 5000 |
Hotell
reviewed
Nov 1, 2023
Hotell
approved these changes
Nov 1, 2023
TristanWatanabe
commented
Nov 1, 2023
TristanWatanabe
commented
Nov 1, 2023
github-actions
Bot
modified the milestones:
October Project Cycle Q4 2023,
November Project Cycle Q1 2024
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Nov 2, 2023
* master: breaking(react-drawer): open now only accepts a boolean instead of MotionShorthand (microsoft#29736) fix (breadcrumb): Overflow examples refactoring (microsoft#29723) refactor(tools): replace deprecated apis (microsoft#29624) [Part 3] Update documentation content for all charts (microsoft#29727) chore: throws if FlatTree is used as a subtree (microsoft#29729) feat(react-storybook-addon-export-to-sandbox): make addon generic so it can be published and use by others (microsoft#29674) chore(TimePicker-compat): add bundle size fixture (microsoft#29717) applying package updates Move CredScanSuppression file to root so 1ESPT output task picks it up (microsoft#29722) fix(CI): increase pipeline agent timeout threshold to 90 minutes (microsoft#29710) fix(breadcrumb): examples and styles (microsoft#29679) chore(react-tree): stop unnecessary re-rendering when no actions are available (microsoft#29694) applying package updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Previous Behavior
New Behavior