Skip to content

fix(react-list-preview): update package setup to be compliant with our standards#29792

Merged
Hotell merged 2 commits into
microsoft:masterfrom
Hotell:react-list-preview-files-fix
Nov 8, 2023
Merged

fix(react-list-preview): update package setup to be compliant with our standards#29792
Hotell merged 2 commits into
microsoft:masterfrom
Hotell:react-list-preview-files-fix

Conversation

@Hotell

@Hotell Hotell commented Nov 8, 2023

Copy link
Copy Markdown
Contributor

blocked by #29793

Previous Behavior

New Behavior

Looks like the initial PR was a bad copy paste instead of running create-package generator

  • added codeowners
  • updated files pattern

Related Issue(s)

@Hotell Hotell changed the title fix(react-list-preview): udpate files declaration to be compliant wit… fix(react-list-preview): udpate files declaration to be compliant with patterns we use to ship to npm Nov 8, 2023
@Hotell Hotell changed the title fix(react-list-preview): udpate files declaration to be compliant with patterns we use to ship to npm fix(react-list-preview): update package setup to be compliant with our standards Nov 8, 2023
@fabricteam

fabricteam commented Nov 8, 2023

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against baa8387b51ae5e028dd7c2f98827ab9bd749f90e

@Hotell
Hotell requested review from a team and george-cz November 8, 2023 16:13
@Hotell
Hotell marked this pull request as ready for review November 8, 2023 16:14
@codesandbox-ci

codesandbox-ci Bot commented Nov 8, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0364b9a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor

size-auditor Bot commented Nov 8, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b511b46fe362c9fe05451d452cf51045c2b32cbf (build)

@Hotell
Hotell force-pushed the react-list-preview-files-fix branch from d25d676 to 0364b9a Compare November 8, 2023 17:06
@Hotell
Hotell enabled auto-merge (squash) November 8, 2023 17:06
@Hotell
Hotell merged commit 5709bde into microsoft:master Nov 8, 2023
@Hotell
Hotell deleted the react-list-preview-files-fix branch November 9, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants