Disallow window and document access in @fluentui/react-components

apps/perf-test-react-components/.eslintrc.json

@@ -3,6 +3,7 @@
   "root": true,
   "rules": {
     "@griffel/styles-file": "off",
-    "no-console": "off"
+    "no-console": "off",
+    "no-restricted-globals": "off"
   }
 }

apps/public-docsite-v9/.eslintrc.json

@@ -5,6 +5,7 @@
     "@typescript-eslint/no-explicit-any": "off",
     "@typescript-eslint/jsx-no-bind": "off",
     "deprecation/deprecation": "off",
-    "import/no-extraneous-dependencies": ["error", { "packageDir": [".", "../.."] }]
+    "import/no-extraneous-dependencies": ["error", { "packageDir": [".", "../.."] }],
+    "no-restricted-globals": "off"
   }
 }

apps/react-18-tests-v8/.eslintrc.json

@@ -1,5 +1,7 @@
 {
   "extends": ["plugin:@fluentui/eslint-plugin/react"],
   "root": true,
-  "rules": {}
+  "rules": {
+    "no-restricted-globals": "off"
+  }
 }

apps/react-18-tests-v9/.eslintrc.json

@@ -1,5 +1,7 @@
 {
   "extends": ["plugin:@fluentui/eslint-plugin/react"],
   "root": true,
-  "rules": {}
+  "rules": {
+    "no-restricted-globals": "off"
+  }
 }

apps/recipes-react-components/.eslintrc.json

@@ -7,6 +7,7 @@
     "@typescript-eslint/no-explicit-any": "off",
     "@typescript-eslint/jsx-no-bind": "off",
     "deprecation/deprecation": "off",
-    "import/no-extraneous-dependencies": ["error", { "packageDir": [".", "../.."] }]
+    "import/no-extraneous-dependencies": ["error", { "packageDir": [".", "../.."] }],
+    "no-restricted-globals": "off"
   }
 }

apps/ssr-tests-v9/.eslintrc.json

@@ -2,6 +2,7 @@
   "extends": ["plugin:@fluentui/eslint-plugin/node"],
   "root": true,
   "rules": {
-    "import/no-extraneous-dependencies": ["error", { "packageDir": ["../../", "./"] }]
+    "import/no-extraneous-dependencies": ["error", { "packageDir": ["../../", "./"] }],
+    "no-restricted-globals": "off"
   }
 }

apps/stress-test/.eslintrc.json

@@ -2,6 +2,7 @@
   "extends": ["plugin:@fluentui/eslint-plugin/node"],
   "root": true,
   "rules": {
-    "import/no-extraneous-dependencies": ["error", { "packageDir": ["../../", "./"] }]
+    "import/no-extraneous-dependencies": ["error", { "packageDir": ["../../", "./"] }],
+    "no-restricted-globals": "off"
   }
 }

apps/vr-tests-react-components/.eslintrc.json

@@ -8,6 +8,7 @@
     "@typescript-eslint/naming-convention": "off",
     "@typescript-eslint/jsx-no-bind": "off",
     "deprecation/deprecation": "off",
-    "import/no-extraneous-dependencies": ["error", { "packageDir": [".", "../.."] }]
+    "import/no-extraneous-dependencies": ["error", { "packageDir": [".", "../.."] }],
+    "no-restricted-globals": "off"
   }
 }

change/@fluentui-cra-template-49db9598-b35e-4d1c-901b-ead2f5a354e0.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "chore: disallow `window` and `document` access",
+  "packageName": "@fluentui/cra-template",
+  "email": "seanmonahan@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-eslint-plugin-ec3bdd41-2624-4271-bda6-b13ed5f7d0c5.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "chore: disallow `window` and `document` access for @fluentui/react-components",
+  "packageName": "@fluentui/eslint-plugin",
+  "email": "seanmonahan@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-global-context-1e3db17a-f6cc-40b8-a367-feabee08ad3b.json

@@ -0,0 +1,7 @@
+{
+  "type": "prerelease",
+  "comment": "chore: disallow `window` and `document` access",
+  "packageName": "@fluentui/global-context",
+  "email": "seanmonahan@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-calendar-compat-0d185f2c-2c07-45d3-a65a-11a19f4ae6ba.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "chore: disallow `window` and `document` access",
+  "packageName": "@fluentui/react-calendar-compat",
+  "email": "seanmonahan@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-motion-preview-5c6d53e5-4c7e-4418-a389-54ff5bceaf66.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "chore: disallow `window` and `document` access",
+  "packageName": "@fluentui/react-motion-preview",
+  "email": "seanmonahan@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-shared-contexts-a56a4c13-fffd-4819-a2ca-0334abbc53a9.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "chore: disallow `window` and `document` access",
+  "packageName": "@fluentui/react-shared-contexts",
+  "email": "seanmonahan@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-utilities-c5034c4b-aba2-4c9d-b59c-54708e33539c.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "chore: disallow `window` and `document` access",
+  "packageName": "@fluentui/react-utilities",
+  "email": "seanmonahan@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-window-provider-5257f709-976b-4616-9470-013dfe88e991.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "chore: disallow `window` and `document` access",
+  "packageName": "@fluentui/react-window-provider",
+  "email": "seanmonahan@microsoft.com",
+  "dependentChangeType": "patch"
+}

packages/cra-template/template/src/index.tsx

@@ -13,6 +13,7 @@ mergeStyles({
   },
 });
 
+// eslint-disable-next-line no-restricted-globals
 ReactDOM.render(<App />, document.getElementById('root'));
 
 // If you want to start measuring performance in your app, pass a function

packages/eslint-plugin/src/configs/react-config.js

@@ -1,4 +1,5 @@
 const configHelpers = require('../utils/configHelpers');
+const { react: restrictedGlobals } = require('./restricted-globals');
 
 /** @type {import("eslint").Linter.Config} */
 module.exports = {
@@ -28,6 +29,7 @@ module.exports = {
     '@griffel/hook-naming': 'error',
     '@griffel/no-shorthands': 'error',
     '@griffel/styles-file': 'error',
+    'no-restricted-globals': restrictedGlobals,
     /**
      * react eslint rules
      * @see https://github.com/yannickcr/eslint-plugin-react
@@ -122,13 +124,15 @@ module.exports = {
       files: [...configHelpers.testFiles],
       rules: {
         'react/jsx-no-bind': 'off',
+        'no-restricted-globals': 'off',
       },
     },
     {
       files: '**/*.stories.tsx',
       rules: {
         // allow makeStyles calls in stories as examples should be defined in a single file
         '@griffel/styles-file': 'off',
+        'no-restricted-globals': 'off',
         // allow arrow functions in stories for now (may want to change this later since using
         // constantly-mutating functions can be an anti-pattern which we may not want to demonstrate
         // in our converged components docs; it happened to be allowed starting out because .stories

packages/eslint-plugin/src/configs/react-legacy.js

@@ -9,6 +9,7 @@ module.exports = {
   rules: {
     'jsdoc/check-tag-names': 'off',
     '@griffel/no-shorthands': 'off',
+    'no-restricted-globals': 'off',
   },
   overrides: [],
 };