fix: v8 ActivityItem is themeable#30445
Open
smhigley wants to merge 9 commits into
Open
Conversation
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 620 | 622 | 5000 | |
| Breadcrumb | mount | 1737 | 1682 | 1000 | |
| Checkbox | mount | 1657 | 1633 | 5000 | |
| CheckboxBase | mount | 1630 | 1452 | 5000 | |
| ChoiceGroup | mount | 2990 | 2953 | 5000 | |
| ComboBox | mount | 667 | 636 | 1000 | |
| CommandBar | mount | 6232 | 6256 | 1000 | |
| ContextualMenu | mount | 11814 | 12112 | 1000 | |
| DefaultButton | mount | 726 | 738 | 5000 | |
| DetailsRow | mount | 2184 | 2188 | 5000 | |
| DetailsRowFast | mount | 2208 | 2213 | 5000 | |
| DetailsRowNoStyles | mount | 2007 | 2098 | 5000 | |
| Dialog | mount | 2823 | 2652 | 1000 | |
| DocumentCardTitle | mount | 224 | 223 | 1000 | |
| Dropdown | mount | 2014 | 2010 | 5000 | |
| FocusTrapZone | mount | 1138 | 1222 | 5000 | |
| FocusZone | mount | 1151 | 1052 | 5000 | |
| GroupedList | mount | 42267 | 42331 | 2 | |
| GroupedList | virtual-rerender | 17930 | 20150 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51313 | 51477 | 2 | |
| GroupedListV2 | mount | 222 | 223 | 2 | |
| GroupedListV2 | virtual-rerender | 207 | 240 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 220 | 231 | 2 | |
| IconButton | mount | 1094 | 1076 | 5000 | |
| Label | mount | 345 | 327 | 5000 | |
| Layer | mount | 2785 | 2733 | 5000 | |
| Link | mount | 392 | 390 | 5000 | |
| MenuButton | mount | 935 | 950 | 5000 | |
| MessageBar | mount | 21568 | 21524 | 5000 | |
| Nav | mount | 1965 | 1977 | 1000 | |
| OverflowSet | mount | 762 | 784 | 5000 | |
| Panel | mount | 1845 | 1779 | 1000 | |
| Persona | mount | 738 | 746 | 1000 | |
| Pivot | mount | 857 | 874 | 1000 | |
| PrimaryButton | mount | 832 | 822 | 5000 | |
| Rating | mount | 4626 | 4614 | 5000 | |
| SearchBox | mount | 901 | 966 | 5000 | |
| Shimmer | mount | 1851 | 1891 | 5000 | |
| Slider | mount | 1320 | 1322 | 5000 | |
| SpinButton | mount | 2887 | 2913 | 5000 | |
| Spinner | mount | 389 | 376 | 5000 | |
| SplitButton | mount | 1946 | 1820 | 5000 | |
| Stack | mount | 410 | 466 | 5000 | |
| StackWithIntrinsicChildren | mount | 855 | 878 | 5000 | |
| StackWithTextChildren | mount | 2740 | 2550 | 5000 | |
| SwatchColorPicker | mount | 6336 | 6155 | 5000 | |
| TagPicker | mount | 1436 | 1452 | 5000 | |
| Text | mount | 374 | 373 | 5000 | |
| TextField | mount | 907 | 940 | 5000 | |
| ThemeProvider | mount | 829 | 829 | 5000 | |
| ThemeProvider | virtual-rerender | 595 | 578 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1362 | 1290 | 5000 | |
| Toggle | mount | 637 | 604 | 5000 | |
| buttonNative | mount | 190 | 198 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Contributor
|
I think I'd recommend using the styled HOC to address this issue. This is the first time I've seen the oh - I just found this in the markdown, looks like it was removed before my time. fluentui/packages/utilities/CHANGELOG.md Line 1866 in 27ca189 Would this end up being a minor change? Not opposed to it personally. |
smhigley
force-pushed
the
themeable-activityitem
branch
from
March 6, 2024 23:17
ca7a908 to
0934288
Compare
github-actions
Bot
modified the milestones:
January Project Cycle Q1 2024,
March Project Cycle Q1 2024
smhigley
commented
Mar 6, 2024
| justify-content: flex-start; | ||
| } | ||
| { | ||
| align-items: center; |
Contributor
Author
There was a problem hiding this comment.
These changes are because previously the mergeStyles approach would allow users to pass in both root and isCompactRoot, then merge those styles. That's not possible with styled(), so the element in question receives both classNames/style blocks, though the end result is the same.
smhigley
force-pushed
the
themeable-activityitem
branch
from
March 7, 2024 00:06
9ecd5da to
8540cbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
ActivityItem styles used theme tokens, but the component wasn't themeable so it never adopted tokens passed in via ThemeProvider or
props.theme.New Behavior
ActivityItem is a HOC using
styled(). The extra className merging inActivityItem.classNames.tsis because the interface forIActivityItemStyleshas multiple entries for a single element (e.g. bothrootandisCompactRoot).Related Issue(s)