ci: improve v9 type-checking speed by ~80% with imperative ghost dependencies type generation#30577
Closed
Hotell wants to merge 32 commits into
Closed
Conversation
…mponents if any v9 package is affected
…n use cache and /unstable apis work
…rts package that is not a dep nor v9 suite dep
…o be build instead hardcoding strings
…e-generation build
…ncy type-generation build
Hotell
changed the title
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 617 | 645 | 5000 | |
| Button | mount | 308 | 298 | 5000 | |
| Field | mount | 1146 | 1122 | 5000 | |
| FluentProvider | mount | 707 | 709 | 5000 | |
| FluentProviderWithTheme | mount | 75 | 90 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 56 | 59 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 76 | 71 | 10 | |
| MakeStyles | mount | 839 | 849 | 50000 | |
| Persona | mount | 1736 | 1731 | 5000 | |
| SpinButton | mount | 1420 | 1427 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ButtonMinimalPerf.default | 98 | 87 | 1.13:1 |
| FormMinimalPerf.default | 237 | 213 | 1.11:1 |
| AttachmentMinimalPerf.default | 88 | 81 | 1.09:1 |
| ListCommonPerf.default | 398 | 365 | 1.09:1 |
| MenuMinimalPerf.default | 515 | 477 | 1.08:1 |
| IconMinimalPerf.default | 409 | 380 | 1.08:1 |
| VideoMinimalPerf.default | 446 | 414 | 1.08:1 |
| ImageMinimalPerf.default | 234 | 220 | 1.06:1 |
| LoaderMinimalPerf.default | 197 | 188 | 1.05:1 |
| PopupMinimalPerf.default | 355 | 337 | 1.05:1 |
| PortalMinimalPerf.default | 88 | 84 | 1.05:1 |
| AccordionMinimalPerf.default | 84 | 81 | 1.04:1 |
| AvatarMinimalPerf.default | 105 | 101 | 1.04:1 |
| CarouselMinimalPerf.default | 261 | 252 | 1.04:1 |
| ChatWithPopoverPerf.default | 202 | 195 | 1.04:1 |
| InputMinimalPerf.default | 526 | 506 | 1.04:1 |
| LabelMinimalPerf.default | 226 | 218 | 1.04:1 |
| TextMinimalPerf.default | 199 | 192 | 1.04:1 |
| TreeWith60ListItems.default | 84 | 81 | 1.04:1 |
| SliderMinimalPerf.default | 752 | 733 | 1.03:1 |
| TableMinimalPerf.default | 249 | 241 | 1.03:1 |
| AnimationMinimalPerf.default | 300 | 293 | 1.02:1 |
| ListNestedPerf.default | 318 | 312 | 1.02:1 |
| MenuButtonMinimalPerf.default | 965 | 945 | 1.02:1 |
| ReactionMinimalPerf.default | 213 | 208 | 1.02:1 |
| SegmentMinimalPerf.default | 200 | 196 | 1.02:1 |
| TreeMinimalPerf.default | 474 | 463 | 1.02:1 |
| BoxMinimalPerf.default | 192 | 191 | 1.01:1 |
| DatepickerMinimalPerf.default | 3568 | 3539 | 1.01:1 |
| DividerMinimalPerf.default | 205 | 202 | 1.01:1 |
| EmbedMinimalPerf.default | 1863 | 1853 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 715 | 709 | 1.01:1 |
| LayoutMinimalPerf.default | 199 | 197 | 1.01:1 |
| ListMinimalPerf.default | 300 | 298 | 1.01:1 |
| ProviderMinimalPerf.default | 199 | 197 | 1.01:1 |
| SplitButtonMinimalPerf.default | 2231 | 2211 | 1.01:1 |
| CustomToolbarPrototype.default | 1469 | 1453 | 1.01:1 |
| TooltipMinimalPerf.default | 1261 | 1246 | 1.01:1 |
| ChatDuplicateMessagesPerf.default | 153 | 153 | 1:1 |
| DialogMinimalPerf.default | 445 | 445 | 1:1 |
| FlexMinimalPerf.default | 150 | 150 | 1:1 |
| ProviderMergeThemesPerf.default | 653 | 655 | 1:1 |
| StatusMinimalPerf.default | 389 | 389 | 1:1 |
| ButtonOverridesMissPerf.default | 637 | 642 | 0.99:1 |
| ChatMinimalPerf.default | 423 | 429 | 0.99:1 |
| DropdownManyItemsPerf.default | 387 | 390 | 0.99:1 |
| DropdownMinimalPerf.default | 1402 | 1412 | 0.99:1 |
| TableManyItemsPerf.default | 1123 | 1135 | 0.99:1 |
| TextAreaMinimalPerf.default | 288 | 290 | 0.99:1 |
| AttachmentSlotsPerf.default | 624 | 636 | 0.98:1 |
| ButtonSlotsPerf.default | 300 | 306 | 0.98:1 |
| CardMinimalPerf.default | 299 | 305 | 0.98:1 |
| CheckboxMinimalPerf.default | 1123 | 1146 | 0.98:1 |
| ListWith60ListItems.default | 359 | 365 | 0.98:1 |
| RadioGroupMinimalPerf.default | 256 | 260 | 0.98:1 |
| ToolbarMinimalPerf.default | 520 | 529 | 0.98:1 |
| RefMinimalPerf.default | 113 | 116 | 0.97:1 |
| GridMinimalPerf.default | 183 | 191 | 0.96:1 |
| RosterPerf.default | 1580 | 1641 | 0.96:1 |
| AlertMinimalPerf.default | 146 | 154 | 0.95:1 |
| HeaderMinimalPerf.default | 200 | 210 | 0.95:1 |
| HeaderSlotsPerf.default | 465 | 488 | 0.95:1 |
| SkeletonMinimalPerf.default | 192 | 203 | 0.95:1 |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 640 | 641 | 5000 | |
| Breadcrumb | mount | 1737 | 1800 | 1000 | |
| Checkbox | mount | 1723 | 1731 | 5000 | |
| CheckboxBase | mount | 1514 | 1515 | 5000 | |
| ChoiceGroup | mount | 2976 | 3027 | 5000 | |
| ComboBox | mount | 699 | 678 | 1000 | |
| CommandBar | mount | 6543 | 6526 | 1000 | |
| ContextualMenu | mount | 16994 | 16665 | 1000 | |
| DefaultButton | mount | 779 | 776 | 5000 | |
| DetailsRow | mount | 2255 | 2223 | 5000 | |
| DetailsRowFast | mount | 2223 | 2211 | 5000 | |
| DetailsRowNoStyles | mount | 2058 | 2075 | 5000 | |
| Dialog | mount | 2829 | 2823 | 1000 | |
| DocumentCardTitle | mount | 246 | 236 | 1000 | |
| Dropdown | mount | 2038 | 2027 | 5000 | |
| FocusTrapZone | mount | 1179 | 1166 | 5000 | |
| FocusZone | mount | 1090 | 1084 | 5000 | |
| GroupedList | mount | 42730 | 42808 | 2 | |
| GroupedList | virtual-rerender | 20350 | 20481 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51669 | 51701 | 2 | |
| GroupedListV2 | mount | 238 | 237 | 2 | |
| GroupedListV2 | virtual-rerender | 223 | 225 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 226 | 259 | 2 | |
| IconButton | mount | 1100 | 1085 | 5000 | |
| Label | mount | 351 | 339 | 5000 | |
| Layer | mount | 2791 | 2769 | 5000 | |
| Link | mount | 398 | 407 | 5000 | |
| MenuButton | mount | 955 | 967 | 5000 | |
| MessageBar | mount | 22030 | 21863 | 5000 | |
| Nav | mount | 1962 | 1940 | 1000 | |
| OverflowSet | mount | 802 | 788 | 5000 | |
| Panel | mount | 2092 | 1831 | 1000 | |
| Persona | mount | 762 | 732 | 1000 | |
| Pivot | mount | 879 | 909 | 1000 | |
| PrimaryButton | mount | 867 | 904 | 5000 | |
| Rating | mount | 4686 | 4689 | 5000 | |
| SearchBox | mount | 934 | 961 | 5000 | |
| Shimmer | mount | 1941 | 1943 | 5000 | |
| Slider | mount | 1357 | 1353 | 5000 | |
| SpinButton | mount | 2910 | 2919 | 5000 | |
| Spinner | mount | 395 | 398 | 5000 | |
| SplitButton | mount | 1878 | 1880 | 5000 | |
| Stack | mount | 408 | 424 | 5000 | |
| StackWithIntrinsicChildren | mount | 909 | 873 | 5000 | |
| StackWithTextChildren | mount | 2601 | 2620 | 5000 | |
| SwatchColorPicker | mount | 6303 | 6289 | 5000 | |
| TagPicker | mount | 1521 | 1485 | 5000 | |
| Text | mount | 372 | 372 | 5000 | |
| TextField | mount | 962 | 961 | 5000 | |
| ThemeProvider | mount | 848 | 864 | 5000 | |
| ThemeProvider | virtual-rerender | 589 | 589 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1282 | 1269 | 5000 | |
| Toggle | mount | 625 | 609 | 5000 | |
| buttonNative | mount | 197 | 200 | 5000 |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
…k to all v9 packages
…npm task to all v9 packages
…-types npm task to all v9 packages
…sk to depend on build in order to make it work cross framework
…dencies-types npm task to all v9 packages
… no longer issuew with lerna + comment leaking test to unblock MVP testing for type-checking
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
… generate-api task
Member
|
The original issue have been closed, closing for housekeeping 🏡 Feel free to re-open |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
A more deterministic implementation of #28002
Flow:
Before running
type-checkwe rungenerate-circular-dependencies-typeswhich will create dependency list of packages used within stories (ghost circular dependencies), and it will rungenerate-apifor them. After that's done we have 100% guarantees all type definitions exist and we can disable TS path aliases and invoketsc -bwhich will be significantly faster.During 1st invocation there is gonna be huge CPU usage peak as it will the first time when all
react-componentssuite packages will rungenerate-apitask.Related Issue(s)