docs: New workflow doc#30664
Merged
Merged
Conversation
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 637 | 639 | 5000 | |
| Button | mount | 298 | 305 | 5000 | |
| Field | mount | 1102 | 1132 | 5000 | |
| FluentProvider | mount | 692 | 685 | 5000 | |
| FluentProviderWithTheme | mount | 73 | 89 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 62 | 72 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 81 | 10 | |
| MakeStyles | mount | 878 | 857 | 50000 | |
| Persona | mount | 1798 | 1717 | 5000 | |
| SpinButton | mount | 1413 | 1379 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| LayoutMinimalPerf.default | 201 | 203 | 0.99:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| PortalMinimalPerf.default | 95 | 83 | 1.14:1 |
| RefMinimalPerf.default | 116 | 105 | 1.1:1 |
| DividerMinimalPerf.default | 223 | 204 | 1.09:1 |
| AttachmentMinimalPerf.default | 86 | 80 | 1.08:1 |
| LabelMinimalPerf.default | 225 | 209 | 1.08:1 |
| ProviderMinimalPerf.default | 206 | 193 | 1.07:1 |
| SegmentMinimalPerf.default | 204 | 190 | 1.07:1 |
| TextAreaMinimalPerf.default | 295 | 276 | 1.07:1 |
| CarouselMinimalPerf.default | 250 | 239 | 1.05:1 |
| FormMinimalPerf.default | 225 | 214 | 1.05:1 |
| ImageMinimalPerf.default | 220 | 210 | 1.05:1 |
| ListNestedPerf.default | 321 | 306 | 1.05:1 |
| BoxMinimalPerf.default | 200 | 193 | 1.04:1 |
| CardMinimalPerf.default | 302 | 289 | 1.04:1 |
| ChatDuplicateMessagesPerf.default | 151 | 145 | 1.04:1 |
| HeaderSlotsPerf.default | 468 | 450 | 1.04:1 |
| AnimationMinimalPerf.default | 308 | 300 | 1.03:1 |
| ButtonSlotsPerf.default | 327 | 318 | 1.03:1 |
| ItemLayoutMinimalPerf.default | 706 | 683 | 1.03:1 |
| PopupMinimalPerf.default | 354 | 345 | 1.03:1 |
| SkeletonMinimalPerf.default | 200 | 195 | 1.03:1 |
| TextMinimalPerf.default | 193 | 188 | 1.03:1 |
| ToolbarMinimalPerf.default | 548 | 534 | 1.03:1 |
| AlertMinimalPerf.default | 167 | 163 | 1.02:1 |
| AvatarMinimalPerf.default | 110 | 108 | 1.02:1 |
| ButtonOverridesMissPerf.default | 661 | 646 | 1.02:1 |
| CheckboxMinimalPerf.default | 1133 | 1107 | 1.02:1 |
| DatepickerMinimalPerf.default | 3652 | 3588 | 1.02:1 |
| EmbedMinimalPerf.default | 1869 | 1835 | 1.02:1 |
| GridMinimalPerf.default | 185 | 182 | 1.02:1 |
| HeaderMinimalPerf.default | 209 | 204 | 1.02:1 |
| ListCommonPerf.default | 377 | 370 | 1.02:1 |
| ProviderMergeThemesPerf.default | 653 | 638 | 1.02:1 |
| RadioGroupMinimalPerf.default | 258 | 254 | 1.02:1 |
| ReactionMinimalPerf.default | 211 | 207 | 1.02:1 |
| ButtonMinimalPerf.default | 89 | 88 | 1.01:1 |
| ChatMinimalPerf.default | 448 | 443 | 1.01:1 |
| ChatWithPopoverPerf.default | 192 | 191 | 1.01:1 |
| DialogMinimalPerf.default | 446 | 442 | 1.01:1 |
| FlexMinimalPerf.default | 156 | 155 | 1.01:1 |
| MenuMinimalPerf.default | 506 | 499 | 1.01:1 |
| TableMinimalPerf.default | 228 | 225 | 1.01:1 |
| CustomToolbarPrototype.default | 1484 | 1470 | 1.01:1 |
| TooltipMinimalPerf.default | 1288 | 1278 | 1.01:1 |
| TreeWith60ListItems.default | 82 | 81 | 1.01:1 |
| ListMinimalPerf.default | 300 | 300 | 1:1 |
| MenuButtonMinimalPerf.default | 955 | 955 | 1:1 |
| RosterPerf.default | 1528 | 1530 | 1:1 |
| SliderMinimalPerf.default | 733 | 731 | 1:1 |
| AccordionMinimalPerf.default | 82 | 83 | 0.99:1 |
| DropdownManyItemsPerf.default | 396 | 398 | 0.99:1 |
| DropdownMinimalPerf.default | 1412 | 1430 | 0.99:1 |
| InputMinimalPerf.default | 547 | 555 | 0.99:1 |
| LoaderMinimalPerf.default | 192 | 193 | 0.99:1 |
| IconMinimalPerf.default | 363 | 368 | 0.99:1 |
| SplitButtonMinimalPerf.default | 2224 | 2280 | 0.98:1 |
| TableManyItemsPerf.default | 1093 | 1113 | 0.98:1 |
| VideoMinimalPerf.default | 435 | 443 | 0.98:1 |
| AttachmentSlotsPerf.default | 622 | 647 | 0.96:1 |
| StatusMinimalPerf.default | 382 | 399 | 0.96:1 |
| TreeMinimalPerf.default | 478 | 496 | 0.96:1 |
| ListWith60ListItems.default | 347 | 368 | 0.94:1 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
📊 Bundle size report✅ No changes found |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 637 | 608 | 5000 | |
| Breadcrumb | mount | 1683 | 1649 | 1000 | |
| Checkbox | mount | 1668 | 1709 | 5000 | |
| CheckboxBase | mount | 1473 | 1457 | 5000 | |
| ChoiceGroup | mount | 2889 | 2884 | 5000 | |
| ComboBox | mount | 644 | 641 | 1000 | |
| CommandBar | mount | 6228 | 6209 | 1000 | |
| ContextualMenu | mount | 11471 | 11622 | 1000 | |
| DefaultButton | mount | 724 | 746 | 5000 | |
| DetailsRow | mount | 2193 | 2181 | 5000 | |
| DetailsRowFast | mount | 2201 | 2169 | 5000 | |
| DetailsRowNoStyles | mount | 2024 | 1996 | 5000 | |
| Dialog | mount | 2658 | 2687 | 1000 | |
| DocumentCardTitle | mount | 221 | 226 | 1000 | |
| Dropdown | mount | 1963 | 1954 | 5000 | |
| FocusTrapZone | mount | 1167 | 1186 | 5000 | |
| FocusZone | mount | 1091 | 1054 | 5000 | |
| GroupedList | mount | 41039 | 41534 | 2 | |
| GroupedList | virtual-rerender | 19851 | 19923 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50704 | 50561 | 2 | |
| GroupedListV2 | mount | 232 | 229 | 2 | |
| GroupedListV2 | virtual-rerender | 215 | 212 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 222 | 232 | 2 | |
| IconButton | mount | 1059 | 1081 | 5000 | |
| Label | mount | 338 | 329 | 5000 | |
| Layer | mount | 2685 | 2696 | 5000 | |
| Link | mount | 389 | 392 | 5000 | |
| MenuButton | mount | 920 | 946 | 5000 | |
| MessageBar | mount | 21467 | 21245 | 5000 | |
| Nav | mount | 1957 | 1919 | 1000 | |
| OverflowSet | mount | 787 | 763 | 5000 | |
| Panel | mount | 1793 | 1780 | 1000 | |
| Persona | mount | 732 | 752 | 1000 | |
| Pivot | mount | 853 | 857 | 1000 | |
| PrimaryButton | mount | 811 | 850 | 5000 | |
| Rating | mount | 4620 | 4682 | 5000 | |
| SearchBox | mount | 899 | 908 | 5000 | |
| Shimmer | mount | 1849 | 1860 | 5000 | |
| Slider | mount | 1303 | 1302 | 5000 | |
| SpinButton | mount | 2849 | 2852 | 5000 | |
| Spinner | mount | 380 | 378 | 5000 | |
| SplitButton | mount | 1830 | 1789 | 5000 | |
| Stack | mount | 404 | 412 | 5000 | |
| StackWithIntrinsicChildren | mount | 843 | 850 | 5000 | |
| StackWithTextChildren | mount | 2565 | 2579 | 5000 | |
| SwatchColorPicker | mount | 6077 | 6241 | 5000 | |
| TagPicker | mount | 1429 | 1437 | 5000 | |
| Text | mount | 364 | 362 | 5000 | |
| TextField | mount | 953 | 931 | 5000 | |
| ThemeProvider | mount | 845 | 834 | 5000 | |
| ThemeProvider | virtual-rerender | 590 | 579 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1298 | 1276 | 5000 | |
| Toggle | mount | 611 | 599 | 5000 | |
| buttonNative | mount | 184 | 186 | 5000 |
smhigley
reviewed
Feb 29, 2024
smhigley
left a comment
smhigley
left a comment
Contributor
There was a problem hiding this comment.
It looks awesome! Left some minor suggestions, let me know what you think :)
khmakoto
reviewed
Mar 1, 2024
smhigley
approved these changes
Mar 5, 2024
mltejera
force-pushed
the
user/matejera/dev-workflow-doc
branch
from
March 5, 2024 22:24
143d5d7 to
bebfa68
Compare
mltejera
commented
Mar 8, 2024
mltejera
commented
Mar 8, 2024
Contributor
Author
|
Add "if linting/prettier starts taking 3+ seconds, try restarting the TS server to unclog things. In VS Code, hit ctrl+p, type |
mltejera
commented
Mar 19, 2024
tudorpopams
approved these changes
Mar 19, 2024
Hotell
reviewed
Mar 22, 2024
mltejera
force-pushed
the
user/matejera/dev-workflow-doc
branch
from
April 1, 2024 16:54
f0fef08 to
fffb75a
Compare
Hotell
reviewed
Apr 4, 2024
Hotell
reviewed
Apr 4, 2024
Hotell
reviewed
Apr 4, 2024
mltejera
force-pushed
the
user/matejera/dev-workflow-doc
branch
from
April 4, 2024 20:47
dc11563 to
b1879eb
Compare
robertpenner
pushed a commit
to robertpenner/fluentui
that referenced
this pull request
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a doc for the basic dev workflow loop.
Things to look for:
Addresses #30642