perf: exclude cypress test files from tsc Program for .d.ts generation and type-checking#30989
Merged
Hotell merged 1 commit intoApr 11, 2024
Conversation
1 task
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 31 | 30 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 620 | 614 | 5000 | |
| Button | mount | 301 | 308 | 5000 | |
| Field | mount | 1121 | 1185 | 5000 | |
| FluentProvider | mount | 686 | 712 | 5000 | |
| FluentProviderWithTheme | mount | 81 | 79 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 31 | 30 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 70 | 10 | |
| MakeStyles | mount | 848 | 828 | 50000 | |
| Persona | mount | 1766 | 1704 | 5000 | |
| SpinButton | mount | 1330 | 1413 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Collaborator
📊 Bundle size report✅ No changes found |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Merged
1 task
…ation and type-checking
Hotell
force-pushed
the
type-checking-perf/prerequirements/fix-cypress-tsc-slowdonws
branch
from
April 8, 2024 13:55
3eae6f9 to
86b5cdc
Compare
Hotell
marked this pull request as ready for review
April 8, 2024 14:27
Hotell
changed the title
.d.ts generation and type-checking
Hotell
changed the title
.d.ts generation and type-checking.d.ts generation and type-checking
layershifter
approved these changes
Apr 9, 2024
tudorpopams
self-requested a review
April 9, 2024 11:53
This was referenced Apr 9, 2024
sopranopillow
approved these changes
Apr 9, 2024
tudorpopams
approved these changes
Apr 10, 2024
Hotell
deleted the
type-checking-perf/prerequirements/fix-cypress-tsc-slowdonws
branch
April 11, 2024 09:39
robertpenner
pushed a commit
to robertpenner/fluentui
that referenced
this pull request
Apr 11, 2024
…ion and type-checking (microsoft#30989)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-requirements
.cy.files were touched #30988Previous Behavior
New Behavior
Related Issue(s)