Skip to content

Update IconDirectionContextProvider import to import from specific path #31006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomi-msft merged 16 commits into from
May 22, 2024
Merged

Update IconDirectionContextProvider import to import from specific path #31006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2fdfceb
Update IconDirectionContextProvider import to import from specific path
tomi-msft Apr 9, 2024
5a9f307
Merge branch 'master' into react-icons-entry-point-fix
tomi-msft Apr 9, 2024
8dbaf25
change file
tomi-msft Apr 9, 2024
109ab7c
Merge branch 'master' of https://github.com/microsoft/fluentui into r…
tomi-msft Apr 17, 2024
41bbbec
Merge branch 'master' of https://github.com/microsoft/fluentui into r…
tomi-msft Apr 18, 2024
8d60adf
Merge branch 'master' of https://github.com/microsoft/fluentui into r…
tomi-msft Apr 22, 2024
a15d8a6
update import to use lib
tomi-msft Apr 22, 2024
c3279a9
update import path for types file
tomi-msft Apr 23, 2024
5be0d4b
Merge branch 'master' of https://github.com/microsoft/fluentui into r…
tomi-msft Apr 23, 2024
f84c489
Merge branch 'master' of https://github.com/microsoft/fluentui into r…
tomi-msft Apr 23, 2024
07b4bae
Merge branch 'master' of https://github.com/microsoft/fluentui into r…
tomi-msft Apr 30, 2024
23aa354
api update
tomi-msft Apr 30, 2024
3b60cd4
Merge branch 'master' of https://github.com/microsoft/fluentui into r…
tomi-msft May 13, 2024
d72a6bc
Merge branch 'master' into react-icons-entry-point-fix
tomi-msft May 21, 2024
d0da31c
apply suggestions from code review
tomi-msft May 22, 2024
720b077
Merge branch 'react-icons-entry-point-fix' of https://github.com/tomi…
tomi-msft May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-provider-b4ae6507-5ab8-4993-a09e-817306d5b73e.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Comment thread
tomi-msft marked this conversation as resolved.
Comment thread
tomi-msft marked this conversation as resolved.
"type": "patch",
"comment": "fix: Update IconDirectionContextProvider imports to use export map",
"packageName": "@fluentui/react-provider",
"email": "ololubek@microsoft.com",
"dependentChangeType": "patch"
}
4 changes: 1 addition & 3 deletions packages/react-components/react-provider/etc/react-provider.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,10 @@

```ts

/// <reference types="react" />

import { ComponentProps } from '@fluentui/react-utilities';
import type { ComponentState } from '@fluentui/react-utilities';
import type { CustomStyleHooksContextValue_unstable } from '@fluentui/react-shared-contexts';
import type { IconDirectionContextValue } from '@fluentui/react-icons';
import type { IconDirectionContextValue } from '@fluentui/react-icons/lib/providers';
import { OverridesContextValue_unstable } from '@fluentui/react-shared-contexts';
import type { PartialTheme } from '@fluentui/react-theme';
import type { ProviderContextValue_unstable } from '@fluentui/react-shared-contexts';
Expand Down
7 changes: 6 additions & 1 deletion ...ges/react-components/react-provider/src/components/FluentProvider/FluentProvider.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
import type { IconDirectionContextValue } from '@fluentui/react-icons';
/*
IconDirectionContextValue is being imported as a leaf node import in order to prevent extra icons froms being
downloaded when trying to use the FluentProvider.
This issue has more context: https://github.com/microsoft/fluentui/issues/30909
*/
import type { IconDirectionContextValue } from '@fluentui/react-icons/lib/providers';
Comment thread
tomi-msft marked this conversation as resolved.
Comment thread
tomi-msft marked this conversation as resolved.
import type {
OverridesContextValue_unstable as OverridesContextValue,
ProviderContextValue_unstable as ProviderContextValue,
Expand Down
2 changes: 1 addition & 1 deletion ...es/react-components/react-provider/src/components/FluentProvider/renderFluentProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
CustomStyleHooksContextValue_unstable as CustomStyleHooksContextValue,
} from '@fluentui/react-shared-contexts';
import type { FluentProviderContextValues, FluentProviderState, FluentProviderSlots } from './FluentProvider.types';
import { IconDirectionContextProvider } from '@fluentui/react-icons';
import { IconDirectionContextProvider } from '@fluentui/react-icons/lib/providers';
Comment thread
tomi-msft marked this conversation as resolved.

/**
* Render the final JSX of FluentProvider
Expand Down