chore: register react-components nested folders to workspace and make storybook properly load split project stories #31145
Merged
Hotell merged 2 commits intoApr 29, 2024
Conversation
… split into /library and /stories within getPackageStoriesGlob()
…react-*/lib|stories
Hotell
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 630 | 623 | 5000 | |
| Button | mount | 295 | 297 | 5000 | |
| Field | mount | 1162 | 1117 | 5000 | |
| FluentProvider | mount | 716 | 700 | 5000 | |
| FluentProviderWithTheme | mount | 85 | 88 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 33 | 42 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 73 | 74 | 10 | |
| MakeStyles | mount | 840 | 830 | 50000 | |
| Persona | mount | 1749 | 1722 | 5000 | |
| SpinButton | mount | 1384 | 1395 | 5000 | |
| SwatchPicker | mount | 1524 | 1521 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| AccordionMinimalPerf.default | 80 | 93 | 0.86:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| TreeWith60ListItems.default | 103 | 89 | 1.16:1 |
| FormMinimalPerf.default | 230 | 203 | 1.13:1 |
| AvatarMinimalPerf.default | 104 | 95 | 1.09:1 |
| ListNestedPerf.default | 328 | 300 | 1.09:1 |
| BoxMinimalPerf.default | 206 | 191 | 1.08:1 |
| AnimationMinimalPerf.default | 299 | 280 | 1.07:1 |
| AttachmentMinimalPerf.default | 87 | 81 | 1.07:1 |
| CarouselMinimalPerf.default | 264 | 250 | 1.06:1 |
| LayoutMinimalPerf.default | 202 | 190 | 1.06:1 |
| RefMinimalPerf.default | 111 | 105 | 1.06:1 |
| ChatWithPopoverPerf.default | 201 | 191 | 1.05:1 |
| ListWith60ListItems.default | 377 | 360 | 1.05:1 |
| ProviderMinimalPerf.default | 209 | 199 | 1.05:1 |
| SkeletonMinimalPerf.default | 205 | 196 | 1.05:1 |
| HeaderSlotsPerf.default | 468 | 450 | 1.04:1 |
| LabelMinimalPerf.default | 215 | 207 | 1.04:1 |
| ListCommonPerf.default | 386 | 372 | 1.04:1 |
| PortalMinimalPerf.default | 86 | 83 | 1.04:1 |
| TextAreaMinimalPerf.default | 290 | 278 | 1.04:1 |
| CheckboxMinimalPerf.default | 1128 | 1094 | 1.03:1 |
| InputMinimalPerf.default | 546 | 529 | 1.03:1 |
| PopupMinimalPerf.default | 347 | 338 | 1.03:1 |
| SliderMinimalPerf.default | 731 | 713 | 1.03:1 |
| DatepickerMinimalPerf.default | 3592 | 3536 | 1.02:1 |
| DialogMinimalPerf.default | 443 | 433 | 1.02:1 |
| DropdownManyItemsPerf.default | 388 | 379 | 1.02:1 |
| EmbedMinimalPerf.default | 1859 | 1822 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 685 | 672 | 1.02:1 |
| ListMinimalPerf.default | 303 | 298 | 1.02:1 |
| RosterPerf.default | 1606 | 1579 | 1.02:1 |
| TableManyItemsPerf.default | 1111 | 1088 | 1.02:1 |
| ButtonMinimalPerf.default | 87 | 86 | 1.01:1 |
| CardMinimalPerf.default | 305 | 303 | 1.01:1 |
| GridMinimalPerf.default | 187 | 186 | 1.01:1 |
| MenuMinimalPerf.default | 496 | 492 | 1.01:1 |
| TableMinimalPerf.default | 227 | 225 | 1.01:1 |
| CustomToolbarPrototype.default | 1481 | 1461 | 1.01:1 |
| AlertMinimalPerf.default | 156 | 156 | 1:1 |
| ButtonOverridesMissPerf.default | 671 | 672 | 1:1 |
| MenuButtonMinimalPerf.default | 949 | 947 | 1:1 |
| SplitButtonMinimalPerf.default | 2234 | 2223 | 1:1 |
| TooltipMinimalPerf.default | 1264 | 1267 | 1:1 |
| DividerMinimalPerf.default | 198 | 200 | 0.99:1 |
| FlexMinimalPerf.default | 147 | 149 | 0.99:1 |
| HeaderMinimalPerf.default | 202 | 204 | 0.99:1 |
| StatusMinimalPerf.default | 387 | 392 | 0.99:1 |
| IconMinimalPerf.default | 375 | 378 | 0.99:1 |
| ToolbarMinimalPerf.default | 523 | 530 | 0.99:1 |
| ButtonSlotsPerf.default | 301 | 306 | 0.98:1 |
| ChatDuplicateMessagesPerf.default | 144 | 147 | 0.98:1 |
| DropdownMinimalPerf.default | 1395 | 1417 | 0.98:1 |
| RadioGroupMinimalPerf.default | 257 | 261 | 0.98:1 |
| TextMinimalPerf.default | 185 | 188 | 0.98:1 |
| SegmentMinimalPerf.default | 187 | 192 | 0.97:1 |
| TreeMinimalPerf.default | 468 | 484 | 0.97:1 |
| VideoMinimalPerf.default | 415 | 426 | 0.97:1 |
| ImageMinimalPerf.default | 219 | 229 | 0.96:1 |
| ProviderMergeThemesPerf.default | 634 | 657 | 0.96:1 |
| ReactionMinimalPerf.default | 200 | 209 | 0.96:1 |
| AttachmentSlotsPerf.default | 609 | 642 | 0.95:1 |
| ChatMinimalPerf.default | 413 | 436 | 0.95:1 |
| LoaderMinimalPerf.default | 181 | 192 | 0.94:1 |
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
📊 Bundle size report✅ No changes found |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 631 | 631 | 5000 | |
| Breadcrumb | mount | 1650 | 1671 | 1000 | |
| Checkbox | mount | 1665 | 1694 | 5000 | |
| CheckboxBase | mount | 1485 | 1476 | 5000 | |
| ChoiceGroup | mount | 2978 | 2956 | 5000 | |
| ComboBox | mount | 668 | 684 | 1000 | |
| CommandBar | mount | 6436 | 6439 | 1000 | |
| ContextualMenu | mount | 12432 | 12153 | 1000 | |
| DefaultButton | mount | 786 | 799 | 5000 | |
| DetailsRow | mount | 2210 | 2200 | 5000 | |
| DetailsRowFast | mount | 2244 | 2216 | 5000 | |
| DetailsRowNoStyles | mount | 2036 | 2019 | 5000 | |
| Dialog | mount | 2647 | 2702 | 1000 | |
| DocumentCardTitle | mount | 241 | 240 | 1000 | |
| Dropdown | mount | 1990 | 2026 | 5000 | |
| FocusTrapZone | mount | 1160 | 1151 | 5000 | |
| FocusZone | mount | 1080 | 1100 | 5000 | |
| GroupedList | mount | 38064 | 42554 | 2 | |
| GroupedList | virtual-rerender | 20277 | 20247 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50617 | 50853 | 2 | |
| GroupedListV2 | mount | 231 | 222 | 2 | |
| GroupedListV2 | virtual-rerender | 210 | 219 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 225 | 226 | 2 | |
| IconButton | mount | 1127 | 1132 | 5000 | |
| Label | mount | 345 | 346 | 5000 | |
| Layer | mount | 2787 | 2758 | 5000 | |
| Link | mount | 387 | 387 | 5000 | |
| MenuButton | mount | 990 | 962 | 5000 | |
| MessageBar | mount | 21114 | 21299 | 5000 | |
| Nav | mount | 2030 | 2025 | 1000 | |
| OverflowSet | mount | 784 | 792 | 5000 | |
| Panel | mount | 1816 | 1839 | 1000 | |
| Persona | mount | 742 | 746 | 1000 | |
| Pivot | mount | 903 | 896 | 1000 | |
| PrimaryButton | mount | 939 | 918 | 5000 | |
| Rating | mount | 4676 | 4652 | 5000 | |
| SearchBox | mount | 903 | 901 | 5000 | |
| Shimmer | mount | 1894 | 1927 | 5000 | |
| Slider | mount | 1333 | 1337 | 5000 | |
| SpinButton | mount | 3005 | 3013 | 5000 | |
| Spinner | mount | 396 | 390 | 5000 | |
| SplitButton | mount | 1864 | 1869 | 5000 | |
| Stack | mount | 409 | 425 | 5000 | |
| StackWithIntrinsicChildren | mount | 854 | 853 | 5000 | |
| StackWithTextChildren | mount | 2618 | 2680 | 5000 | |
| SwatchColorPicker | mount | 6271 | 6375 | 5000 | |
| TagPicker | mount | 1492 | 1439 | 5000 | |
| Text | mount | 379 | 371 | 5000 | |
| TextField | mount | 942 | 945 | 5000 | |
| ThemeProvider | mount | 839 | 847 | 5000 | |
| ThemeProvider | virtual-rerender | 592 | 594 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1281 | 1284 | 5000 | |
| Toggle | mount | 606 | 619 | 5000 | |
| buttonNative | mount | 188 | 188 | 5000 |
Hotell
marked this pull request as ready for review
April 23, 2024 12:02
tudorpopams
self-requested a review
April 23, 2024 12:10
tudorpopams
approved these changes
Apr 23, 2024
Hotell
deleted the
type-checking-perf/prerequirements/workspace-and-storybook-setup
branch
April 29, 2024 11:43
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
… storybook properly load split project stories (microsoft#31145)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Related Issue(s)