chore: move all stories from react-components package to public-docsite-v9 and remove storybook setup from suite package#31440
Merged
Hotell merged 8 commits intoMay 28, 2024
Conversation
Hotell
changed the title
Hotell
changed the title
Collaborator
📊 Bundle size report✅ No changes found |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 655 | 609 | 5000 | |
| Button | mount | 295 | 322 | 5000 | |
| Field | mount | 1162 | 1112 | 5000 | |
| FluentProvider | mount | 723 | 736 | 5000 | |
| FluentProviderWithTheme | mount | 76 | 86 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 37 | 35 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 79 | 75 | 10 | |
| MakeStyles | mount | 874 | 870 | 50000 | |
| Persona | mount | 1767 | 1707 | 5000 | |
| SpinButton | mount | 1388 | 1411 | 5000 | |
| SwatchPicker | mount | 1524 | 1513 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
17 tasks
Hotell
force-pushed
the
type-checking-perf/apply/suite-storybook-move
branch
from
May 22, 2024 14:59
36d819e to
aa921c6
Compare
Hotell
changed the title
Hotell
marked this pull request as ready for review
May 22, 2024 15:49
Hotell
force-pushed
the
type-checking-perf/apply/suite-storybook-move
branch
from
May 22, 2024 17:19
d500877 to
682c17d
Compare
george-cz
approved these changes
May 27, 2024
ling1726
approved these changes
May 27, 2024
…om migrated react-components suite
… by switching to v9 ruleset
…eact and suite /unstable occurences
Hotell
force-pushed
the
type-checking-perf/apply/suite-storybook-move
branch
from
May 28, 2024 12:24
682c17d to
e091b33
Compare
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
…te-v9 and remove storybook setup from suite package (microsoft#31440)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Based on previous discussion within v-build group:
public-docsite-v9
@griffel/react,@fluentui/react-components/unstable)react-components suite
assets/folder is removed as it's no longer relevantRelated Issue(s)