Skip to content

fix(web-components): add --noEmit for type-checking task#31452

Merged
Hotell merged 2 commits into
microsoft:masterfrom
Hotell:wc-3-followup/type-check-fix
May 22, 2024
Merged

fix(web-components): add --noEmit for type-checking task#31452
Hotell merged 2 commits into
microsoft:masterfrom
Hotell:wc-3-followup/type-check-fix

Conversation

@Hotell

@Hotell Hotell commented May 22, 2024

Copy link
Copy Markdown
Contributor

Previous Behavior

type check emits declarations

New Behavior

type check wont emit anything

Related Issue(s)

@github-actions github-actions Bot added this to the April Project Cycle Q1 2024 milestone May 22, 2024
@Hotell
Hotell marked this pull request as ready for review May 22, 2024 11:49
@Hotell
Hotell requested a review from a team as a code owner May 22, 2024 11:49
@fabricteam

fabricteam commented May 22, 2024

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

✅ No changes found

Comment thread packages/web-components/scripts/type-check.js
@codesandbox-ci

codesandbox-ci Bot commented May 22, 2024

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Hotell
Hotell force-pushed the wc-3-followup/type-check-fix branch from 640f5f0 to ae5bbb0 Compare May 22, 2024 12:21
@Hotell
Hotell enabled auto-merge (squash) May 22, 2024 12:42
@Hotell
Hotell merged commit 98bbbe9 into microsoft:master May 22, 2024
@Hotell
Hotell deleted the wc-3-followup/type-check-fix branch May 22, 2024 18:46
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants