Skip to content

fix: make type-check task run with --noEmit and return only void Promise on success and update recipes app tsconfig #31456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hotell merged 2 commits into from
May 22, 2024
Merged

fix: make type-check task run with --noEmit and return only void Promise on success and update recipes app tsconfig #31456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f51376
chore(recipes-react-component): remve exclude config to properly incl…
Hotell May 22, 2024
5d37184
fix(tasks): make type-check task run with --noEmit and return only vo…
Hotell May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/recipes-react-components/tsconfig.app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,5 @@
"declaration": true,
Comment thread
Hotell marked this conversation as resolved.
Comment thread
Hotell marked this conversation as resolved.
Comment thread
Hotell marked this conversation as resolved.
"inlineSources": true
},
"exclude": [],
"include": ["./src/**/*.ts", "./src/**/*.tsx"]
}
19 changes: 12 additions & 7 deletions scripts/tasks/src/type-check.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { exec } from 'just-scripts-utils';

import { type TsConfig, getTsPathAliasesConfig } from './utils';

export async function typeCheck() {
export function typeCheck(): Promise<void> | undefined {
const { isUsingTsSolutionConfigs, tsConfigs } = getTsPathAliasesConfig();

if (!isUsingTsSolutionConfigs) {
Expand All @@ -20,17 +20,22 @@ export async function typeCheck() {

const tsConfigsRefs = getTsConfigs(config, { spec: false, e2e: false });

const asyncQueue = [];
const asyncQueue: Array<ReturnType<typeof exec>> = [];

for (const ref of tsConfigsRefs) {
const program = `tsc -p ${ref} --pretty --baseUrl .`;
const program = `tsc -p ${ref} --pretty --baseUrl . --noEmit`;
asyncQueue.push(exec(program));
}

return Promise.all(asyncQueue).catch(err => {
console.error(err.stdout);
process.exit(1);
});
return Promise.all(asyncQueue)
.then(_ => {
logger.info('Type checking completed successfully');
return;
})
.catch(err => {
console.error(err.stdout);
process.exit(1);
});
}

function getTsConfigs(solutionConfig: TsConfig, exclude: { spec: boolean; e2e: boolean }) {
Expand Down