chore: re-enable lint rule#31459
Merged
layershifter merged 1 commit intoMay 27, 2024
Merged
Conversation
layershifter
force-pushed
the
chore/re-enable-lint-rules
branch
from
May 22, 2024 20:43
db128ee to
ce0401e
Compare
fabricteam
reviewed
May 22, 2024
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 623 | 641 | 5000 | |
| Button | mount | 306 | 290 | 5000 | |
| Field | mount | 1128 | 1161 | 5000 | |
| FluentProvider | mount | 723 | 726 | 5000 | |
| FluentProviderWithTheme | mount | 87 | 78 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 36 | 37 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 79 | 81 | 10 | |
| MakeStyles | mount | 887 | 864 | 50000 | |
| Persona | mount | 1764 | 1759 | 5000 | |
| SpinButton | mount | 1395 | 1443 | 5000 | |
| SwatchPicker | mount | 1564 | 1542 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AccordionMinimalPerf.default | 91 | 81 | 1.12:1 |
| LoaderMinimalPerf.default | 208 | 189 | 1.1:1 |
| ButtonSlotsPerf.default | 328 | 302 | 1.09:1 |
| ChatMinimalPerf.default | 470 | 433 | 1.09:1 |
| ChatWithPopoverPerf.default | 209 | 195 | 1.07:1 |
| DividerMinimalPerf.default | 212 | 198 | 1.07:1 |
| PortalMinimalPerf.default | 88 | 82 | 1.07:1 |
| ProviderMinimalPerf.default | 213 | 199 | 1.07:1 |
| RefMinimalPerf.default | 118 | 110 | 1.07:1 |
| TextMinimalPerf.default | 202 | 188 | 1.07:1 |
| AnimationMinimalPerf.default | 305 | 288 | 1.06:1 |
| ListCommonPerf.default | 407 | 383 | 1.06:1 |
| ListNestedPerf.default | 344 | 325 | 1.06:1 |
| RadioGroupMinimalPerf.default | 272 | 256 | 1.06:1 |
| SkeletonMinimalPerf.default | 200 | 189 | 1.06:1 |
| TreeWith60ListItems.default | 91 | 86 | 1.06:1 |
| AttachmentMinimalPerf.default | 88 | 84 | 1.05:1 |
| ChatDuplicateMessagesPerf.default | 155 | 148 | 1.05:1 |
| DropdownMinimalPerf.default | 1468 | 1401 | 1.05:1 |
| HeaderMinimalPerf.default | 209 | 200 | 1.05:1 |
| LabelMinimalPerf.default | 229 | 218 | 1.05:1 |
| SegmentMinimalPerf.default | 204 | 195 | 1.05:1 |
| CarouselMinimalPerf.default | 273 | 262 | 1.04:1 |
| GridMinimalPerf.default | 193 | 185 | 1.04:1 |
| TextAreaMinimalPerf.default | 301 | 289 | 1.04:1 |
| VideoMinimalPerf.default | 459 | 443 | 1.04:1 |
| BoxMinimalPerf.default | 203 | 198 | 1.03:1 |
| ButtonOverridesMissPerf.default | 660 | 643 | 1.03:1 |
| PopupMinimalPerf.default | 352 | 341 | 1.03:1 |
| ProviderMergeThemesPerf.default | 657 | 640 | 1.03:1 |
| AttachmentSlotsPerf.default | 646 | 633 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 706 | 689 | 1.02:1 |
| MenuMinimalPerf.default | 506 | 497 | 1.02:1 |
| SliderMinimalPerf.default | 761 | 747 | 1.02:1 |
| SplitButtonMinimalPerf.default | 2281 | 2239 | 1.02:1 |
| IconMinimalPerf.default | 396 | 387 | 1.02:1 |
| TreeMinimalPerf.default | 496 | 488 | 1.02:1 |
| AvatarMinimalPerf.default | 106 | 105 | 1.01:1 |
| CardMinimalPerf.default | 298 | 295 | 1.01:1 |
| DropdownManyItemsPerf.default | 399 | 397 | 1.01:1 |
| InputMinimalPerf.default | 550 | 545 | 1.01:1 |
| ListMinimalPerf.default | 311 | 307 | 1.01:1 |
| ListWith60ListItems.default | 383 | 379 | 1.01:1 |
| StatusMinimalPerf.default | 389 | 386 | 1.01:1 |
| CheckboxMinimalPerf.default | 1148 | 1149 | 1:1 |
| DatepickerMinimalPerf.default | 3642 | 3656 | 1:1 |
| DialogMinimalPerf.default | 445 | 446 | 1:1 |
| HeaderSlotsPerf.default | 467 | 468 | 1:1 |
| TableManyItemsPerf.default | 1096 | 1095 | 1:1 |
| ToolbarMinimalPerf.default | 538 | 538 | 1:1 |
| EmbedMinimalPerf.default | 1876 | 1898 | 0.99:1 |
| FlexMinimalPerf.default | 156 | 157 | 0.99:1 |
| FormMinimalPerf.default | 218 | 220 | 0.99:1 |
| MenuButtonMinimalPerf.default | 953 | 961 | 0.99:1 |
| RosterPerf.default | 1543 | 1553 | 0.99:1 |
| ReactionMinimalPerf.default | 211 | 214 | 0.99:1 |
| ButtonMinimalPerf.default | 90 | 92 | 0.98:1 |
| TableMinimalPerf.default | 232 | 236 | 0.98:1 |
| CustomToolbarPrototype.default | 1466 | 1490 | 0.98:1 |
| ImageMinimalPerf.default | 222 | 232 | 0.96:1 |
| LayoutMinimalPerf.default | 194 | 203 | 0.96:1 |
| TooltipMinimalPerf.default | 1259 | 1311 | 0.96:1 |
| AlertMinimalPerf.default | 146 | 164 | 0.89:1 |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
📊 Bundle size report✅ No changes found |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 616 | 644 | 5000 | |
| Breadcrumb | mount | 1662 | 1663 | 1000 | |
| Checkbox | mount | 1690 | 1717 | 5000 | |
| CheckboxBase | mount | 1473 | 1464 | 5000 | |
| ChoiceGroup | mount | 2921 | 3001 | 5000 | |
| ComboBox | mount | 682 | 692 | 1000 | |
| CommandBar | mount | 6420 | 6456 | 1000 | |
| ContextualMenu | mount | 11767 | 11754 | 1000 | |
| DefaultButton | mount | 800 | 801 | 5000 | |
| DetailsRow | mount | 2223 | 2209 | 5000 | |
| DetailsRowFast | mount | 2183 | 2184 | 5000 | |
| DetailsRowNoStyles | mount | 2041 | 2010 | 5000 | |
| Dialog | mount | 2687 | 2662 | 1000 | |
| DocumentCardTitle | mount | 216 | 235 | 1000 | |
| Dropdown | mount | 1989 | 2009 | 5000 | |
| FocusTrapZone | mount | 1120 | 1161 | 5000 | |
| FocusZone | mount | 1091 | 1128 | 5000 | |
| GroupedList | mount | 41799 | 42085 | 2 | |
| GroupedList | virtual-rerender | 18025 | 19975 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50596 | 50664 | 2 | |
| GroupedListV2 | mount | 222 | 227 | 2 | |
| GroupedListV2 | virtual-rerender | 208 | 220 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 223 | 226 | 2 | |
| IconButton | mount | 1116 | 1140 | 5000 | |
| Label | mount | 341 | 333 | 5000 | |
| Layer | mount | 2728 | 2748 | 5000 | |
| Link | mount | 401 | 399 | 5000 | |
| MenuButton | mount | 964 | 977 | 5000 | |
| MessageBar | mount | 21693 | 21537 | 5000 | |
| Nav | mount | 2028 | 2014 | 1000 | |
| OverflowSet | mount | 800 | 787 | 5000 | |
| Panel | mount | 1809 | 1773 | 1000 | |
| Persona | mount | 709 | 763 | 1000 | |
| Pivot | mount | 909 | 871 | 1000 | |
| PrimaryButton | mount | 920 | 928 | 5000 | |
| Rating | mount | 4745 | 4731 | 5000 | |
| SearchBox | mount | 913 | 923 | 5000 | |
| Shimmer | mount | 1908 | 1861 | 5000 | |
| Slider | mount | 1352 | 1342 | 5000 | |
| SpinButton | mount | 2992 | 3002 | 5000 | |
| Spinner | mount | 402 | 399 | 5000 | |
| SplitButton | mount | 1872 | 1853 | 5000 | |
| Stack | mount | 406 | 418 | 5000 | |
| StackWithIntrinsicChildren | mount | 859 | 874 | 5000 | |
| StackWithTextChildren | mount | 2651 | 2661 | 5000 | |
| SwatchColorPicker | mount | 6320 | 6372 | 5000 | |
| TagPicker | mount | 1477 | 1474 | 5000 | |
| Text | mount | 368 | 393 | 5000 | |
| TextField | mount | 953 | 958 | 5000 | |
| ThemeProvider | mount | 840 | 840 | 5000 | |
| ThemeProvider | virtual-rerender | 601 | 575 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1285 | 1281 | 5000 | |
| Toggle | mount | 631 | 595 | 5000 | |
| buttonNative | mount | 189 | 192 | 5000 |
layershifter
force-pushed
the
chore/re-enable-lint-rules
branch
2 times, most recently
from
May 23, 2024 09:10
5fb13af to
83323df
Compare
layershifter
marked this pull request as ready for review
May 23, 2024 09:10
ling1726
approved these changes
May 24, 2024
spmonahan
approved these changes
May 24, 2024
layershifter
enabled auto-merge (squash)
May 27, 2024 10:34
layershifter
force-pushed
the
chore/re-enable-lint-rules
branch
from
May 27, 2024 11:45
93fc6c9 to
6374f10
Compare
fabricteam
reviewed
May 27, 2024
fabricteam
reviewed
May 27, 2024
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 28, 2024
* master: (49 commits) Update focus order in sankey chart for vertical navigation (microsoft#31469) chore: use new performant 'type-check' for v9 libaries (microsoft#31454) applying package updates fix(Timepicker-compat): clearIcon not working in freeform (microsoft#31324) chore: re-enable lint rule (microsoft#31459) feat(react-tag-picker): adds text property to TagPickerOption (microsoft#31474) feat(recipes): create package with initial implementation (moved from /apps) (microsoft#31386) applying package updates applying package updates chore: revert globals changes (microsoft#31470) (web-components) Use `ElementInternals` for TextInput elements (microsoft#31201) chore:(docs) Update and migrate component implementation guide (microsoft#31398) disallow all globals in Fluent v9 (microsoft#30967) chore:(react-nav-preview) Recomposing more components and some pixel pushing (microsoft#31387) fix(pr-deploy-site): explicitly set types to not include whole @types/* globals which are causing issues with addition of @types/web (microsoft#31465) fix(recipes-react-components): explicitly set types to not include whole @types/* globals which are cauising issues with addition of @types/web (microsoft#31463) applying package updates applying package updates applying package updates Update IconDirectionContextProvider import to import from specific path (microsoft#31006) ...
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Behavior
Follow up for #31258 where
deprecation/deprecationhave been disabled for files that containedshorthands.*().Related Issue(s)
Fixes #31318.