chore(react-components): split react libraries in two (/library and /stories) - teams-prg#31582
Closed
Hotell wants to merge 6 commits into
Closed
chore(react-components): split react libraries in two (/library and /stories) - teams-prg#31582Hotell wants to merge 6 commits into
Hotell wants to merge 6 commits into
Conversation
Hotell
force-pushed
the
type-checking-perf/apply/teams
branch
from
June 5, 2024 14:22
3c83373 to
e5ec9ed
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
fabricteam
reviewed
Jun 5, 2024
| @@ -144,7 +144,8 @@ packages/merge-styles @dzearing @microsoft/cxe-red | |||
| packages/monaco-editor @microsoft/fluentui-v8-website | |||
Collaborator
There was a problem hiding this comment.
🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots
Accordion 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Accordion.Size.normal.chromium.png | 2 | Changed |
| Accordion.Size - RTL.normal.chromium.png | 2 | Changed |
| Accordion.Size - Dark Mode.normal.chromium.png | 2 | Changed |
Avatar 5 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar.Active Appearance - Dark Mode.normal.chromium.png | 2 | Changed |
| Avatar.Active Appearance.normal.chromium.png | 10 | Changed |
| Avatar.Color.normal.chromium.png | 1 | Changed |
| Avatar.Active.normal.chromium.png | 5 | Changed |
| Avatar.Color - RTL.normal.chromium.png | 1 | Changed |
Badge 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Badge.Shape.normal.chromium.png | 1 | Changed |
| Badge.Appearance.normal.chromium.png | 1 | Changed |
| Badge.Size.normal.chromium.png | 6 | Changed |
| Badge.Appearance - Dark Mode.normal.chromium.png | 15 | Changed |
| Badge.Default.normal.chromium.png | 1 | Changed |
| Badge.Color.normal.chromium.png | 1 | Changed |
Button 15 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Button.Large Icon Only.default.chromium.png | 5 | Changed |
| Button.Large Icon Only - Dark Mode.pressed.chromium.png | 5 | Changed |
| Button.Large Icon Only.hover.chromium.png | 4 | Changed |
| Button.Large Icon Only.pressed.chromium.png | 3 | Changed |
| Button.Large With Icon - Dark Mode.default.chromium.png | 4 | Changed |
| Button.Large With Icon - Dark Mode.pressed.chromium.png | 5 | Changed |
| Button.Large With Icon.default.chromium.png | 5 | Changed |
| Button.Large With Icon.hover.chromium.png | 4 | Changed |
| Button.Large Icon Only - Dark Mode.hover.chromium.png | 3 | Changed |
| Button.Large With Icon - Dark Mode.hover.chromium.png | 3 | Changed |
| Button.Large With Icon - RTL.default.chromium.png | 5 | Changed |
| Button.Large With Icon - RTL.pressed.chromium.png | 3 | Changed |
| Button.Large With Icon.pressed.chromium.png | 3 | Changed |
| Button.Large Icon Only - Dark Mode.default.chromium.png | 4 | Changed |
| Button.Large With Icon - RTL.hover.chromium.png | 4 | Changed |
Divider 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Divider.With Svg.normal.chromium.png | 3 | Changed |
| Divider.With Svg - RTL.normal.chromium.png | 3 | Changed |
| Divider.Vertical With Svg.normal.chromium.png | 4 | Changed |
MenuList 16 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| MenuList.Checkbox With Icons - RTL.normal.chromium.png | 4 | Changed |
| MenuList.Checkbox.2nd selected.chromium.png | 1 | Changed |
| MenuList.Checkbox With Icons - RTL.1st selected.chromium.png | 4 | Changed |
| MenuList.Checkbox With Icons - RTL.2nd selected.chromium.png | 5 | Changed |
| MenuList.Checkbox With Icons.2nd selected.chromium.png | 5 | Changed |
| MenuList.Checkbox - RTL.2nd selected.chromium.png | 1 | Changed |
| MenuList.Checkbox With Icons.normal.chromium.png | 4 | Changed |
| MenuList.Radio With Icons.2nd selected.chromium.png | 4 | Changed |
| MenuList.Radio With Icons - RTL.1st selected.chromium.png | 4 | Changed |
| MenuList.Radio With Icons.1st selected.chromium.png | 4 | Changed |
| MenuList.Radio With Icons - RTL.normal.chromium.png | 4 | Changed |
| MenuList.Radio With Icons - RTL.2nd selected.chromium.png | 4 | Changed |
| MenuList.Radio With Icons.normal.chromium.png | 4 | Changed |
| MenuList.Checkbox With Icons.1st selected.chromium.png | 4 | Changed |
| MenuList.With Icons.normal.chromium.png | 4 | Changed |
| MenuList.With Icons.hover menuitem.chromium.png | 3 | Changed |
Slider 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Slider.Size Small.normal.chromium.png | 1 | Changed |
| Slider.Size Small.rightArrow.chromium.png | 1 | Changed |
Switch 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Switch.Checked.hover.chromium.png | 1 | Changed |
| Switch.Checked - RTL.hover.chromium.png | 1 | Changed |
Text 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Text.Block.normal.chromium.png | 995 | Changed |
TextInput 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| TextInput.Size Large.normal.chromium.png | 2 | Changed |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 611 | 623 | 5000 | |
| Button | mount | 310 | 325 | 5000 | |
| Field | mount | 1116 | 1129 | 5000 | |
| FluentProvider | mount | 712 | 707 | 5000 | |
| FluentProviderWithTheme | mount | 89 | 80 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 38 | 35 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 79 | 10 | |
| MakeStyles | mount | 873 | 867 | 50000 | |
| Persona | mount | 1735 | 1724 | 5000 | |
| SpinButton | mount | 1377 | 1386 | 5000 | |
| SwatchPicker | mount | 1515 | 1500 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ButtonMinimalPerf.default | 96 | 85 | 1.13:1 |
| FlexMinimalPerf.default | 161 | 144 | 1.12:1 |
| PortalMinimalPerf.default | 86 | 77 | 1.12:1 |
| ButtonSlotsPerf.default | 329 | 297 | 1.11:1 |
| ImageMinimalPerf.default | 227 | 206 | 1.1:1 |
| TextAreaMinimalPerf.default | 301 | 274 | 1.1:1 |
| VideoMinimalPerf.default | 456 | 418 | 1.09:1 |
| AttachmentMinimalPerf.default | 83 | 77 | 1.08:1 |
| TableMinimalPerf.default | 247 | 231 | 1.07:1 |
| BoxMinimalPerf.default | 203 | 191 | 1.06:1 |
| CardMinimalPerf.default | 307 | 289 | 1.06:1 |
| DividerMinimalPerf.default | 211 | 199 | 1.06:1 |
| FormMinimalPerf.default | 232 | 219 | 1.06:1 |
| TextMinimalPerf.default | 194 | 183 | 1.06:1 |
| AvatarMinimalPerf.default | 108 | 103 | 1.05:1 |
| CarouselMinimalPerf.default | 263 | 250 | 1.05:1 |
| ChatDuplicateMessagesPerf.default | 152 | 145 | 1.05:1 |
| DropdownManyItemsPerf.default | 386 | 367 | 1.05:1 |
| LayoutMinimalPerf.default | 196 | 187 | 1.05:1 |
| InputMinimalPerf.default | 560 | 539 | 1.04:1 |
| ListMinimalPerf.default | 315 | 303 | 1.04:1 |
| PopupMinimalPerf.default | 358 | 345 | 1.04:1 |
| ChatMinimalPerf.default | 455 | 441 | 1.03:1 |
| LabelMinimalPerf.default | 221 | 215 | 1.03:1 |
| AlertMinimalPerf.default | 158 | 155 | 1.02:1 |
| GridMinimalPerf.default | 187 | 183 | 1.02:1 |
| ListCommonPerf.default | 394 | 385 | 1.02:1 |
| SkeletonMinimalPerf.default | 196 | 192 | 1.02:1 |
| CustomToolbarPrototype.default | 1461 | 1426 | 1.02:1 |
| ToolbarMinimalPerf.default | 544 | 534 | 1.02:1 |
| DatepickerMinimalPerf.default | 3569 | 3522 | 1.01:1 |
| DropdownMinimalPerf.default | 1413 | 1398 | 1.01:1 |
| HeaderSlotsPerf.default | 459 | 454 | 1.01:1 |
| ListNestedPerf.default | 310 | 308 | 1.01:1 |
| MenuMinimalPerf.default | 504 | 500 | 1.01:1 |
| MenuButtonMinimalPerf.default | 945 | 935 | 1.01:1 |
| ProviderMergeThemesPerf.default | 654 | 649 | 1.01:1 |
| RefMinimalPerf.default | 112 | 111 | 1.01:1 |
| SliderMinimalPerf.default | 765 | 757 | 1.01:1 |
| TooltipMinimalPerf.default | 1268 | 1250 | 1.01:1 |
| DialogMinimalPerf.default | 435 | 434 | 1:1 |
| EmbedMinimalPerf.default | 1829 | 1827 | 1:1 |
| ItemLayoutMinimalPerf.default | 717 | 714 | 1:1 |
| RosterPerf.default | 1533 | 1529 | 1:1 |
| ProviderMinimalPerf.default | 205 | 204 | 1:1 |
| ReactionMinimalPerf.default | 215 | 216 | 1:1 |
| TableManyItemsPerf.default | 1081 | 1079 | 1:1 |
| AnimationMinimalPerf.default | 284 | 287 | 0.99:1 |
| ButtonOverridesMissPerf.default | 630 | 639 | 0.99:1 |
| ChatWithPopoverPerf.default | 197 | 200 | 0.99:1 |
| RadioGroupMinimalPerf.default | 251 | 254 | 0.99:1 |
| SegmentMinimalPerf.default | 186 | 188 | 0.99:1 |
| AttachmentSlotsPerf.default | 633 | 649 | 0.98:1 |
| HeaderMinimalPerf.default | 199 | 203 | 0.98:1 |
| SplitButtonMinimalPerf.default | 2235 | 2280 | 0.98:1 |
| TreeMinimalPerf.default | 475 | 487 | 0.98:1 |
| CheckboxMinimalPerf.default | 1101 | 1131 | 0.97:1 |
| ListWith60ListItems.default | 365 | 375 | 0.97:1 |
| IconMinimalPerf.default | 388 | 402 | 0.97:1 |
| TreeWith60ListItems.default | 89 | 92 | 0.97:1 |
| LoaderMinimalPerf.default | 189 | 196 | 0.96:1 |
| StatusMinimalPerf.default | 392 | 407 | 0.96:1 |
| AccordionMinimalPerf.default | 75 | 79 | 0.95:1 |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 641 | 624 | 5000 | |
| Breadcrumb | mount | 1693 | 1678 | 1000 | |
| Checkbox | mount | 1687 | 1705 | 5000 | |
| CheckboxBase | mount | 1476 | 1458 | 5000 | |
| ChoiceGroup | mount | 2984 | 2990 | 5000 | |
| ComboBox | mount | 651 | 670 | 1000 | |
| CommandBar | mount | 6461 | 6479 | 1000 | |
| ContextualMenu | mount | 12363 | 12891 | 1000 | |
| DefaultButton | mount | 785 | 791 | 5000 | |
| DetailsRow | mount | 2226 | 2232 | 5000 | |
| DetailsRowFast | mount | 2196 | 2233 | 5000 | |
| DetailsRowNoStyles | mount | 2024 | 2037 | 5000 | |
| Dialog | mount | 2754 | 2830 | 1000 | |
| DocumentCardTitle | mount | 232 | 215 | 1000 | |
| Dropdown | mount | 2010 | 2009 | 5000 | |
| FocusTrapZone | mount | 1102 | 1147 | 5000 | |
| FocusZone | mount | 1078 | 1068 | 5000 | |
| GroupedList | mount | 42289 | 42176 | 2 | |
| GroupedList | virtual-rerender | 20180 | 20170 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51407 | 51336 | 2 | |
| GroupedListV2 | mount | 223 | 230 | 2 | |
| GroupedListV2 | virtual-rerender | 203 | 209 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 218 | 223 | 2 | |
| IconButton | mount | 1149 | 1117 | 5000 | |
| Label | mount | 337 | 344 | 5000 | |
| Layer | mount | 2803 | 2764 | 5000 | |
| Link | mount | 390 | 407 | 5000 | |
| MenuButton | mount | 966 | 1027 | 5000 | |
| MessageBar | mount | 21206 | 21501 | 5000 | |
| Nav | mount | 2016 | 2020 | 1000 | |
| OverflowSet | mount | 777 | 772 | 5000 | |
| Panel | mount | 1804 | 1877 | 1000 | |
| Persona | mount | 747 | 742 | 1000 | |
| Pivot | mount | 889 | 898 | 1000 | |
| PrimaryButton | mount | 948 | 924 | 5000 | |
| Rating | mount | 4644 | 4729 | 5000 | |
| SearchBox | mount | 917 | 939 | 5000 | |
| Shimmer | mount | 1885 | 1920 | 5000 | |
| Slider | mount | 1308 | 1324 | 5000 | |
| SpinButton | mount | 2966 | 3012 | 5000 | |
| Spinner | mount | 389 | 404 | 5000 | |
| SplitButton | mount | 1882 | 1877 | 5000 | |
| Stack | mount | 413 | 411 | 5000 | |
| StackWithIntrinsicChildren | mount | 843 | 872 | 5000 | |
| StackWithTextChildren | mount | 2685 | 2629 | 5000 | |
| SwatchColorPicker | mount | 6324 | 6315 | 5000 | |
| TagPicker | mount | 1447 | 1487 | 5000 | |
| Text | mount | 375 | 379 | 5000 | |
| TextField | mount | 931 | 944 | 5000 | |
| ThemeProvider | mount | 854 | 836 | 5000 | |
| ThemeProvider | virtual-rerender | 592 | 582 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1325 | 1300 | 5000 | |
| Toggle | mount | 622 | 600 | 5000 | |
| buttonNative | mount | 194 | 191 | 5000 |
fabricteam
reviewed
Jun 5, 2024
| @@ -144,7 +144,8 @@ packages/merge-styles @dzearing @microsoft/cxe-red | |||
| packages/monaco-editor @microsoft/fluentui-v8-website | |||
Collaborator
There was a problem hiding this comment.
🕵 fluentuiv9 Open the Visual Regressions report to inspect the affected screenshots
Avatar Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.badgeMask.normal.chromium.png | 3 | Changed |
Card Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Card Converged.appearance - RTL.normal.chromium.png | 0 | Added |
Card Converged - Interactive 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Card Converged - Interactive.appearance interactive - Filled - High Contrast.click.chromium.png | 0 | Added |
| Card Converged - Interactive.appearance interactive - Filled - High Contrast.hover.chromium.png | 0 | Added |
| Card Converged - Interactive.appearance interactive - Filled - High Contrast.normal.chromium.png | 0 | Added |
Card Converged - Selectable 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Card Converged - Selectable.appearance selectable - Outline - Dark Mode.click.chromium.png | 0 | Removed |
| Card Converged - Selectable.appearance selectable - Outline - Dark Mode.hover.chromium.png | 0 | Removed |
| Card Converged - Selectable.appearance selectable - Outline - Dark Mode.normal.chromium.png | 0 | Removed |
| Card Converged - Selectable.appearance selectable - Outline - Dark Mode.selected.chromium.png | 0 | Removed |
…y and /stories) - teams-prg
17 tasks
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
fabricteam
reviewed
Jun 5, 2024
| @@ -144,7 +144,8 @@ packages/merge-styles @dzearing @microsoft/cxe-red | |||
| packages/monaco-editor @microsoft/fluentui-v8-website | |||
Collaborator
There was a problem hiding this comment.
🕵 fluentuiv8 Open the Visual Regressions report to inspect the affected screenshots
Pivot - Overflow 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Pivot - Overflow.Root.Narrow - Last tab selected.chromium.png | 0 | Removed |
| Pivot - Overflow.Root.Narrow - Overflow menu.chromium.png | 0 | Removed |
| Pivot - Overflow.Tabs - RTL.Narrow - Last tab selected.chromium.png | 0 | Removed |
| Pivot - Overflow.Tabs - RTL.Narrow - Overflow menu.chromium.png | 0 | Removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Note
Based on RFC v9 react packages are split in two: #30514
Package/Scaffold changes:
yarn nx g @fluentui/workspace-plugin:split-library-in-two --project @fluentui/react-<name>Related Issue(s)