You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Visual regression tool reports visual regressions in Drawer:
All of them related to a missing box-shadow which should be tokens.shadow64. To confirm it, I went to a PR deployment & real docsite and changed value of --shadow64 token to rgb(85, 91, 255) 0px 0px 0px 3px, rgb(31, 193, 27) 0px 0px 0px 6px, rgb(255, 217, 19) 0px 0px 0px 9px, rgb(255, 156, 85) 0px 0px 0px 12px, rgb(255, 85, 85) 0px 0px 0px 15px:
@layershifter There is also a Motion Disabled stories example that is not working anymore. How can we implement a way to disable animations on the user side?
@layershifter There is also a Motion Disabled stories example that is not working anymore. How can we implement a way to disable animations on the user side?
Good catch 👍 This should be supported with #30700.
Considering that there are at least three items related to #30700 in this PR, IMO it makes sense to implement first it.
@marcosmoura I will put this PR on hold and will work on #30700. Thanks for feedback ❤️
@layershifter Might be for another PR, but another thing is the Multiple Levels example. Since we are moving the whole Drawer package to not use the hooks anymore, we should start thinking of a way to achieve a similar experience using the new Motion API.
@layershifter There is also a Motion Disabled stories example that is not working anymore. How can we implement a way to disable animations on the user side?
@marcosmoura updated it, it's just null now 🙌 See an example below (the story was also updated 💪):
@layershifter Might be for another PR, but another thing is the Multiple Levels example. Since we are moving the whole Drawer package to not use the hooks anymore, we should start thinking of a way to achieve a similar experience using the new Motion API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
@fluentui/react-draweruses@fluentui/react-motion-preview.New Behavior
@fluentui/react-draweruses@fluentui/react-motion💪OverlayDrawergetsbackdropMotion&surfaceMotionslots,InlineDrawergetssurfaceMotionfor customizing motionsRelated Issue(s)
Fixes #30696.
Note on VR regressions
Visual regression tool reports visual regressions in
Drawer:All of them related to a missing
box-shadowwhich should betokens.shadow64. To confirm it, I went to a PR deployment & real docsite and changed value of--shadow64token torgb(85, 91, 255) 0px 0px 0px 3px, rgb(31, 193, 27) 0px 0px 0px 6px, rgb(255, 217, 19) 0px 0px 0px 9px, rgb(255, 156, 85) 0px 0px 0px 12px, rgb(255, 85, 85) 0px 0px 0px 15px:And the result matches:
Seems to be a glitch with VR tool 💥