chore: migrate to ts v5.0.4 by mainframev · Pull Request #31898 · microsoft/fluentui

mainframev · 2024-07-02T11:58:25Z

Previous Behavior

release-note v 4.9

New Behavior

Typescript migration to v5.
release-note v 5.0

Build and type-check speed:

No perf wins. The build isn't quite accurate as few projects were normalized on testing branch, but the type-check is and it's quite the same to the current master.

v8 bundle size is affected:

example diff between v 4.9 and 5.0 in DetailsList

example diff between v 4.9 and 5.0 in Pickers

The increase is very minimal in total, about 445 bytes

I removed forceConsistenCasingInFileNames option, as it's a default since v5.
I kept experimentalDecorators as it will continue to exist for the foreseeable future and better will be to solve it later separately.

Related Issue(s)

Closes [Feature]: migrate repo to TypeScript 5.0 #31857
Unblocks @tsconfig/node20, mentioned in chore: bump @types/node types to v20 and @tsconfig to v18 #31510

fabricteam · 2024-07-02T12:07:15Z

📊 Bundle size report

Package & Exports	Baseline (minified/GZIP)	PR	Change
`react` Announced	`38.419 kB` `13.288 kB`	`38.423 kB` `13.289 kB`	`4 B` `1 B`
`react` Autofill	`15.365 kB` `4.743 kB`	`15.373 kB` `4.746 kB`	`8 B` `3 B`
`react` Breadcrumb	`202.005 kB` `60.362 kB`	`202.087 kB` `60.438 kB`	`82 B` `76 B`
`react` Button	`195.473 kB` `56.558 kB`	`195.543 kB` `56.617 kB`	`70 B` `59 B`
`react` ButtonGrid	`180.416 kB` `54.61 kB`	`180.472 kB` `54.65 kB`	`56 B` `40 B`
`react` Calendar	`121.67 kB` `36.976 kB`	`121.686 kB` `36.985 kB`	`16 B` `9 B`
`react` ColorPicker	`133.113 kB` `41.536 kB`	`133.171 kB` `41.577 kB`	`58 B` `41 B`
`react` ComboBox	`251.89 kB` `72.222 kB`	`251.985 kB` `72.313 kB`	`95 B` `91 B`
`react` CommandBar	`203.042 kB` `60.075 kB`	`203.124 kB` `60.14 kB`	`82 B` `65 B`
`react` ContextualMenu	`154.998 kB` `48.158 kB`	`155.014 kB` `48.169 kB`	`16 B` `11 B`
`react` DatePicker	`184.067 kB` `56.121 kB`	`184.109 kB` `56.156 kB`	`42 B` `35 B`
`react` DetailsList	`229.54 kB` `65.708 kB`	`229.727 kB` `65.873 kB`	`187 B` `165 B`
`react` Dialog	`211.329 kB` `63.082 kB`	`211.399 kB` `63.147 kB`	`70 B` `65 B`
`react` DocumentCard	`217.014 kB` `64.363 kB`	`217.08 kB` `64.437 kB`	`66 B` `74 B`
`react` DraggableZone	`34.241 kB` `11.491 kB`	`34.243 kB` `11.492 kB`	`2 B` `1 B`
`react` Dropdown	`233.935 kB` `68.547 kB`	`234.032 kB` `68.66 kB`	`97 B` `113 B`
`react` ExtendedPicker	`96.693 kB` `27.85 kB`	`96.737 kB` `27.87 kB`	`44 B` `20 B`
`react` Facepile	`210.59 kB` `63.132 kB`	`210.672 kB` `63.201 kB`	`82 B` `69 B`
`react` FloatingPicker	`242.06 kB` `68.931 kB`	`242.128 kB` `69.006 kB`	`68 B` `75 B`
`react` FocusZone	`54.972 kB` `17.442 kB`	`54.988 kB` `17.451 kB`	`16 B` `9 B`
`react` Grid	`180.416 kB` `54.61 kB`	`180.472 kB` `54.65 kB`	`56 B` `40 B`
`react` GroupedList	`134.857 kB` `40.65 kB`	`134.954 kB` `40.74 kB`	`97 B` `90 B`
`react` GroupedListV2	`122.474 kB` `37.757 kB`	`122.543 kB` `37.84 kB`	`69 B` `83 B`
`react` HoverCard	`97.097 kB` `30.782 kB`	`97.109 kB` `30.808 kB`	`12 B` `26 B`
`react` KeytipLayer	`103.406 kB` `32.004 kB`	`103.41 kB` `32.006 kB`	`4 B` `2 B`
`react` Keytips	`106.174 kB` `33.006 kB`	`106.178 kB` `33.006 kB`	`4 B`
`react` List	`39.304 kB` `12.441 kB`	`39.333 kB` `12.455 kB`	`29 B` `14 B`
`react` MarqueeSelection	`74.449 kB` `22.441 kB`	`74.473 kB` `22.448 kB`	`24 B` `7 B`
`react` MessageBar	`190.52 kB` `57.042 kB`	`190.576 kB` `57.086 kB`	`56 B` `44 B`
`react` Modal	`93.568 kB` `30.235 kB`	`93.57 kB` `30.232 kB`	`2 B` `-3 B`
`react` Nav	`187.998 kB` `56.464 kB`	`188.076 kB` `56.538 kB`	`78 B` `74 B`
`react` Panel	`201.04 kB` `59.952 kB`	`201.135 kB` `60.045 kB`	`95 B` `93 B`
`react` Persona	`114.745 kB` `36.478 kB`	`114.755 kB` `36.483 kB`	`10 B` `5 B`
`react` PersonaCoin	`114.745 kB` `36.478 kB`	`114.755 kB` `36.483 kB`	`10 B` `5 B`
`react` Pickers	`293.845 kB` `82.288 kB`	`293.963 kB` `82.41 kB`	`118 B` `122 B`
`react` Pivot	`188.912 kB` `57.213 kB`	`188.968 kB` `57.254 kB`	`56 B` `41 B`
`react` ProgressIndicator	`39.414 kB` `13.548 kB`	`39.424 kB` `13.548 kB`	`10 B`
`react` Rating	`81.89 kB` `26.097 kB`	`81.906 kB` `26.107 kB`	`16 B` `10 B`
`react` Fluent UI React (entire library)	`1.013 MB` `281.443 kB`	`1.014 MB` `281.888 kB`	`526 B` `445 B`
`react` ScrollablePane	`55.457 kB` `17.735 kB`	`55.463 kB` `17.74 kB`	`6 B` `5 B`
`react` SearchBox	`188.795 kB` `56.649 kB`	`188.851 kB` `56.695 kB`	`56 B` `46 B`
`react` SelectedItemsList	`232.559 kB` `67.863 kB`	`232.625 kB` `67.938 kB`	`66 B` `75 B`
`react` Selection	`42.38 kB` `12.255 kB`	`42.4 kB` `12.278 kB`	`20 B` `23 B`
`react` ShimmeredDetailsList	`240.315 kB` `68.463 kB`	`240.502 kB` `68.626 kB`	`187 B` `163 B`
`react` SpinButton	`192.523 kB` `57.748 kB`	`192.579 kB` `57.798 kB`	`56 B` `50 B`
`react` Spinner	`41.704 kB` `14.479 kB`	`41.706 kB` `14.477 kB`	`2 B` `-2 B`
`react` Sticky	`32.541 kB` `10.49 kB`	`32.555 kB` `10.494 kB`	`14 B` `4 B`
`react` SwatchColorPicker	`190.742 kB` `58.094 kB`	`190.798 kB` `58.14 kB`	`56 B` `46 B`
`react` TeachingBubble	`205.795 kB` `60.984 kB`	`205.855 kB` `61.023 kB`	`60 B` `39 B`
`react` TextField	`80.683 kB` `25.303 kB`	`80.709 kB` `25.324 kB`	`26 B` `21 B`
`react` TimePicker	`241.694 kB` `69.983 kB`	`241.76 kB` `70.063 kB`	`66 B` `80 B`
`react` Tooltip	`87.264 kB` `28.207 kB`	`87.274 kB` `28.206 kB`	`10 B` `-1 B`
`react` WeeklyDayPicker	`101.814 kB` `31.796 kB`	`101.84 kB` `31.805 kB`	`26 B` `9 B`

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`510 B` `328 B`
`global-context` createContextSelector	`537 B` `339 B`
`keyboard-key` keyboard-key package	`3.746 kB` `1.928 kB`
`priority-overflow` createOverflowManager	`4.457 kB` `1.856 kB`
`react` ActivityItem	`71.147 kB` `23.33 kB`
`react` Callout	`84.236 kB` `27.607 kB`
`react` Check	`53.091 kB` `17.837 kB`
`react` Checkbox	`59.879 kB` `19.865 kB`
`react` ChoiceGroup	`65.404 kB` `21.469 kB`
`react` ChoiceGroupOption	`58.659 kB` `19.356 kB`
`react` Coachmark	`93.065 kB` `29.412 kB`
`react` Color	`7.737 kB` `3.106 kB`
`react` DateTimeUtilities	`5.244 kB` `1.849 kB`
`react` Divider	`19.531 kB` `6.862 kB`
`react` DragDrop	`8.343 kB` `2.724 kB`
`react` Fabric	`41.665 kB` `14.358 kB`
`react` FocusTrapZone	`16.979 kB` `5.921 kB`
`react` Icon	`51.772 kB` `17.252 kB`
`react` Icons	`66.309 kB` `24.381 kB`
`react` Image	`46.829 kB` `15.701 kB`
`react` Keytip	`81.61 kB` `26.75 kB`
`react` KeytipData	`13.973 kB` `4.573 kB`
`react` Label	`38.266 kB` `13.244 kB`
`react` Layer	`48.015 kB` `16.337 kB`
`react` Link	`39.616 kB` `13.649 kB`
`react` OverflowSet	`33.319 kB` `11.317 kB`
`react` Overlay	`40.822 kB` `14.083 kB`
`react` PersonaPresence	`57.961 kB` `19.359 kB`
`react` Popup	`12.242 kB` `4.181 kB`
`react` Positioning	`22.736 kB` `7.685 kB`
`react` PositioningContainer	`73.775 kB` `23.762 kB`
`react` ResizeGroup	`13.286 kB` `4.365 kB`
`react` ResponsiveMode	`8.078 kB` `2.95 kB`
`react` SelectableOption	`724 B` `413 B`
`react` Separator	`35.315 kB` `12.157 kB`
`react` Shimmer	`49.177 kB` `16.256 kB`
`react` Slider	`57.577 kB` `19.194 kB`
`react` Stack	`41.675 kB` `14.283 kB`
`react` Styling	`45.981 kB` `15.121 kB`
`react` Text	`36.851 kB` `12.828 kB`
`react` Theme	`43.449 kB` `14.169 kB`
`react` ThemeGenerator	`12.34 kB` `4.106 kB`
`react` Toggle	`46.148 kB` `15.96 kB`
`react` Utilities	`82.623 kB` `25.106 kB`
`react` Viewport	`23.831 kB` `7.638 kB`
`react` WindowProvider	`1.059 kB` `541 B`
`react-accordion` Accordion (including children components)	`99.097 kB` `30.197 kB`
`react-avatar` Avatar	`49.301 kB` `15.838 kB`
`react-avatar` AvatarGroup	`20.107 kB` `7.973 kB`
`react-avatar` AvatarGroupItem	`63.445 kB` `20.061 kB`
`react-badge` Badge	`25.952 kB` `8.614 kB`
`react-badge` CounterBadge	`26.731 kB` `8.887 kB`
`react-badge` PresenceBadge	`25.719 kB` `9.485 kB`
`react-breadcrumb` @fluentui/react-breadcrumb - package	`113.657 kB` `31.532 kB`
`react-button` Button	`37.105 kB` `10.785 kB`
`react-button` CompoundButton	`43.516 kB` `12.076 kB`
`react-button` MenuButton	`41.912 kB` `12.137 kB`
`react-button` SplitButton	`49.924 kB` `13.73 kB`
`react-button` ToggleButton	`53.035 kB` `12.546 kB`
`react-calendar-compat` Calendar Compat	`149.533 kB` `39.867 kB`
`react-card` Card - All	`100.845 kB` `28.873 kB`
`react-card` Card	`93.629 kB` `27.077 kB`
`react-card` CardFooter	`14.356 kB` `5.798 kB`
`react-card` CardHeader	`16.879 kB` `6.664 kB`
`react-card` CardPreview	`14.42 kB` `5.934 kB`
`react-checkbox` Checkbox	`35.105 kB` `12.112 kB`
`react-combobox` Combobox (including child components)	`103.623 kB` `34.007 kB`
`react-combobox` Dropdown (including child components)	`104.209 kB` `33.914 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`69.141 kB` `20.157 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`211.741 kB` `60.957 kB`
`react-components` react-components: FluentProvider & webLightTheme	`44.442 kB` `14.607 kB`
`react-components` react-components: entire library	`1.095 MB` `270.91 kB`
`react-datepicker-compat` DatePicker Compat	`223.009 kB` `63.141 kB`
`react-dialog` Dialog (including children components)	`99.002 kB` `29.835 kB`
`react-divider` Divider	`21.328 kB` `7.965 kB`
`react-field` Field	`23.384 kB` `8.903 kB`
`react-image` Image	`15.362 kB` `6.248 kB`
`react-input` Input	`28.015 kB` `9.456 kB`
`react-jsx-runtime` Classic Pragma	`1.057 kB` `530 B`
`react-jsx-runtime` JSX Dev Runtime	`3.781 kB` `1.646 kB`
`react-jsx-runtime` JSX Runtime	`4.377 kB` `1.881 kB`
`react-label` Label	`14.672 kB` `6.002 kB`
`react-link` Link	`17.193 kB` `6.993 kB`
`react-menu` Menu (including children components)	`151.246 kB` `45.708 kB`
`react-menu` Menu (including selectable components)	`153.932 kB` `46.201 kB`
`react-message-bar` MessageBar (all components)	`24.596 kB` `9.18 kB`
`react-motion` @fluentui/react-motion - createMotionComponent()	`4.173 kB` `1.847 kB`
`react-motion` @fluentui/react-motion - createPresenceComponent()	`4.846 kB` `2.132 kB`
`react-motion` @fluentui/react-motion - PresenceGroup	`1.714 kB` `819 B`
`react-northstar` Accordion	`85.392 kB` `26.518 kB`
`react-northstar` Alert	`87.45 kB` `26.902 kB`
`react-northstar` Animation	`55.34 kB` `17.829 kB`
`react-northstar` Attachment	`86.844 kB` `26.692 kB`
`react-northstar` Avatar	`80.279 kB` `24.629 kB`
`react-northstar` Box	`75.248 kB` `23.806 kB`
`react-northstar` Breadcrumb	`79.92 kB` `24.709 kB`
`react-northstar` Button	`83.16 kB` `25.947 kB`
`react-northstar` Card	`82.705 kB` `25.023 kB`
`react-northstar` Carousel	`105.182 kB` `31.871 kB`
`react-northstar` Chat	`154.09 kB` `46.847 kB`
`react-northstar` Checkbox	`79.807 kB` `25.078 kB`
`react-northstar` Datepicker	`186.651 kB` `56.973 kB`
`react-northstar` Debug	`8.801 kB` `3.594 kB`
`react-northstar` Design	`36.589 kB` `12.067 kB`
`react-northstar` Dialog	`112.058 kB` `33.615 kB`
`react-northstar` Divider	`76.619 kB` `24.129 kB`
`react-northstar` Dropdown	`198.211 kB` `60.214 kB`
`react-northstar` Embed	`81.477 kB` `25.417 kB`
`react-northstar` Flex	`47.728 kB` `15.438 kB`
`react-northstar` Form	`92.527 kB` `28.879 kB`
`react-northstar` Grid	`70.584 kB` `22.278 kB`
`react-northstar` Header	`74.756 kB` `23.461 kB`
`react-northstar` Image	`73.591 kB` `23.329 kB`
`react-northstar` Input	`88.346 kB` `27.78 kB`
`react-northstar` ItemLayout	`78.231 kB` `24.454 kB`
`react-northstar` Label	`77.92 kB` `24.41 kB`
`react-northstar` Layout	`75.393 kB` `23.798 kB`
`react-northstar` List	`88.493 kB` `27.547 kB`
`react-northstar` Loader	`78.616 kB` `24.729 kB`
`react-northstar` Menu	`128.602 kB` `40.717 kB`
`react-northstar` MenuButton	`163.008 kB` `49.606 kB`
`react-northstar` Pill	`83.722 kB` `26.069 kB`
`react-northstar` Popup	`135.316 kB` `42.242 kB`
`react-northstar` Portal	`58.338 kB` `18.852 kB`
`react-northstar` Provider	`93.138 kB` `29.63 kB`
`react-northstar` RadioGroup	`83.282 kB` `26.053 kB`
`react-northstar` Reaction	`77.28 kB` `24.122 kB`
`react-northstar` Segment	`76.209 kB` `23.892 kB`
`react-northstar` Skeleton	`77.765 kB` `24.2 kB`
`react-northstar` Slider	`84.27 kB` `26.737 kB`
`react-northstar` SplitButton	`178.246 kB` `53.42 kB`
`react-northstar` Status	`76.272 kB` `24.05 kB`
`react-northstar` SvgIcon	`36.823 kB` `11.743 kB`
`react-northstar` Table	`80.796 kB` `25.154 kB`
`react-northstar` Text	`74.114 kB` `23.507 kB`
`react-northstar` TextArea	`74.248 kB` `23.492 kB`
`react-northstar` Toolbar	`175.057 kB` `52.832 kB`
`react-northstar` Tooltip	`109.973 kB` `35.227 kB`
`react-northstar` Tree	`87.855 kB` `27.217 kB`
`react-northstar` Video	`75.411 kB` `23.799 kB`
`react-overflow` hooks only	`12.821 kB` `4.813 kB`
`react-persona` Persona	`56.192 kB` `17.728 kB`
`react-popover` Popover	`127.198 kB` `39.776 kB`
`react-portal` Portal	`14.563 kB` `5.118 kB`
`react-portal-compat` PortalCompatProvider	`8.39 kB` `2.64 kB`
`react-positioning` usePositioning	`26.489 kB` `9.552 kB`
`react-progress` ProgressBar	`17.086 kB` `6.906 kB`
`react-provider` FluentProvider	`24.618 kB` `8.906 kB`
`react-radio` Radio	`32.673 kB` `10.351 kB`
`react-radio` RadioGroup	`15.76 kB` `6.433 kB`
`react-select` Select	`27.723 kB` `10.131 kB`
`react-slider` Slider	`37.17 kB` `12.547 kB`
`react-spinbutton` SpinButton	`36.102 kB` `11.85 kB`
`react-spinner` Spinner	`25.246 kB` `8.554 kB`
`react-swatch-picker` @fluentui/react-swatch-picker - package	`103.69 kB` `30.094 kB`
`react-switch` Switch	`35.301 kB` `11.348 kB`
`react-table` DataGrid	`160.297 kB` `45.656 kB`
`react-table` Table (Primitives only)	`42.482 kB` `13.868 kB`
`react-table` Table as DataGrid	`131.102 kB` `36.346 kB`
`react-table` Table (Selection only)	`70.336 kB` `20.028 kB`
`react-table` Table (Sort only)	`68.979 kB` `19.633 kB`
`react-tag-picker` @fluentui/react-tag-picker - package	`181.187 kB` `54.484 kB`
`react-tags` InteractionTag	`15.167 kB` `6.135 kB`
`react-tags` Tag	`28.996 kB` `9.52 kB`
`react-tags` TagGroup	`82.084 kB` `24.34 kB`
`react-text` Text - Default	`17.063 kB` `6.733 kB`
`react-text` Text - Wrappers	`20.235 kB` `7.064 kB`
`react-textarea` Textarea	`26.572 kB` `9.769 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`35.666 kB` `7.453 kB`
`react-theme` Teams: Light theme	`19.642 kB` `5.549 kB`
`react-timepicker-compat` TimePicker	`106.611 kB` `35.546 kB`
`react-toast` Toast (including Toaster)	`97.608 kB` `29.358 kB`
`react-tooltip` Tooltip	`54.558 kB` `19.23 kB`
`react-utilities` SSRProvider	`180 B` `160 B`

_{🤖 This report was generated against 878e1756c4cb8e6ae0c6388472ce107368cf7a16}

fabricteam · 2024-07-02T12:11:36Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	620	655	5000
Button	mount	308	304	5000
Field	mount	1123	1181	5000
FluentProvider	mount	703	717	5000
FluentProviderWithTheme	mount	78	85	10
FluentProviderWithTheme	virtual-rerender	36	43	10
FluentProviderWithTheme	virtual-rerender-with-unmount	77	73	10
MakeStyles	mount	876	866	50000
Persona	mount	1777	1752	5000
SpinButton	mount	1352	1397	5000
SwatchPicker	mount	1647	1668	5000

fabricteam · 2024-07-02T12:14:24Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ 3 potential perf regressions detected

Potential regressions comparing to master

Scenario	Current PR Ticks	Baseline Ticks	Ratio	Regression Analysis
AlertMinimalPerf.default	166	152	1.09:1	analysis
PortalMinimalPerf.default	88	82	1.07:1	analysis
AttachmentMinimalPerf.default	81	78	1.04:1	analysis

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
TreeWith60ListItems.default	92	81	1.14:1
ChatWithPopoverPerf.default	215	198	1.09:1
LoaderMinimalPerf.default	203	186	1.09:1
AvatarMinimalPerf.default	114	107	1.07:1
HeaderMinimalPerf.default	217	204	1.06:1
RefMinimalPerf.default	118	111	1.06:1
ChatDuplicateMessagesPerf.default	150	143	1.05:1
ButtonOverridesMissPerf.default	687	663	1.04:1
DividerMinimalPerf.default	211	203	1.04:1
FormMinimalPerf.default	224	215	1.04:1
PopupMinimalPerf.default	357	344	1.04:1
ProviderMinimalPerf.default	207	199	1.04:1
ToolbarMinimalPerf.default	547	527	1.04:1
AttachmentSlotsPerf.default	643	624	1.03:1
ChatMinimalPerf.default	450	438	1.03:1
FlexMinimalPerf.default	164	159	1.03:1
ListNestedPerf.default	327	316	1.03:1
MenuMinimalPerf.default	509	495	1.03:1
MenuButtonMinimalPerf.default	952	925	1.03:1
SegmentMinimalPerf.default	204	199	1.03:1
VideoMinimalPerf.default	444	433	1.03:1
DropdownMinimalPerf.default	1433	1403	1.02:1
ItemLayoutMinimalPerf.default	693	678	1.02:1
RadioGroupMinimalPerf.default	255	250	1.02:1
TreeMinimalPerf.default	485	477	1.02:1
AccordionMinimalPerf.default	76	75	1.01:1
AnimationMinimalPerf.default	301	297	1.01:1
BoxMinimalPerf.default	191	190	1.01:1
CarouselMinimalPerf.default	257	254	1.01:1
DialogMinimalPerf.default	442	437	1.01:1
LabelMinimalPerf.default	222	220	1.01:1
SkeletonMinimalPerf.default	197	196	1.01:1
TableManyItemsPerf.default	1107	1092	1.01:1
TooltipMinimalPerf.default	1262	1255	1.01:1
CheckboxMinimalPerf.default	1123	1119	1:1
DatepickerMinimalPerf.default	3571	3577	1:1
DropdownManyItemsPerf.default	384	385	1:1
ListCommonPerf.default	382	382	1:1
ProviderMergeThemesPerf.default	657	656	1:1
TextAreaMinimalPerf.default	277	276	1:1
CardMinimalPerf.default	300	304	0.99:1
EmbedMinimalPerf.default	1896	1916	0.99:1
InputMinimalPerf.default	522	529	0.99:1
LayoutMinimalPerf.default	188	189	0.99:1
SliderMinimalPerf.default	739	746	0.99:1
SplitButtonMinimalPerf.default	2208	2223	0.99:1
StatusMinimalPerf.default	389	391	0.99:1
TableMinimalPerf.default	235	238	0.99:1
TextMinimalPerf.default	194	195	0.99:1
GridMinimalPerf.default	186	190	0.98:1
IconMinimalPerf.default	381	390	0.98:1
CustomToolbarPrototype.default	1448	1481	0.98:1
ButtonSlotsPerf.default	296	304	0.97:1
RosterPerf.default	1509	1560	0.97:1
ListMinimalPerf.default	297	310	0.96:1
HeaderSlotsPerf.default	447	470	0.95:1
ImageMinimalPerf.default	222	234	0.95:1
ButtonMinimalPerf.default	83	88	0.94:1
ReactionMinimalPerf.default	210	223	0.94:1
ListWith60ListItems.default	350	378	0.93:1

fabricteam · 2024-07-02T12:15:51Z

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam · 2024-07-02T12:24:15Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	632	647	5000
Breadcrumb	mount	1708	1708	1000
Checkbox	mount	1714	1708	5000
CheckboxBase	mount	1467	1548	5000
ChoiceGroup	mount	2960	2937	5000
ComboBox	mount	679	713	1000
CommandBar	mount	6803	6707	1000
ContextualMenu	mount	err	15879	1000
DefaultButton	mount	802	821	5000
DetailsRow	mount	2222	2203	5000
DetailsRowFast	mount	2218	2254	5000
DetailsRowNoStyles	mount	2065	2037	5000
Dialog	mount	2806	2735	1000
DocumentCardTitle	mount	230	239	1000
Dropdown	mount	2005	2005	5000
FocusTrapZone	mount	1169	1139	5000
FocusZone	mount	1079	1068	5000
GroupedList	mount	38283	42763	2
GroupedList	virtual-rerender	20424	20499	2
GroupedList	virtual-rerender-with-unmount	51765	51866	2
GroupedListV2	mount	240	235	2
GroupedListV2	virtual-rerender	212	210	2
GroupedListV2	virtual-rerender-with-unmount	226	238	2
IconButton	mount	1131	1154	5000
Label	mount	330	341	5000
Layer	mount	2769	2774	5000
Link	mount	401	395	5000
MenuButton	mount	976	988	5000
MessageBar	mount	21373	21383	5000
Nav	mount	2044	2099	1000
OverflowSet	mount	810	769	5000
Panel	mount	1844	1804	1000
Persona	mount	763	756	1000
Pivot	mount	885	908	1000
PrimaryButton	mount	959	940	5000
Rating	mount	4710	4698	5000
SearchBox	mount	917	913	5000
Shimmer	mount	1872	1897	5000
Slider	mount	1360	1358	5000
SpinButton	mount	2988	3032	5000
Spinner	mount	406	391	5000
SplitButton	mount	1870	1898	5000
Stack	mount	433	423	5000
StackWithIntrinsicChildren	mount	864	885	5000
StackWithTextChildren	mount	2771	2829	5000
SwatchColorPicker	mount	6411	6385	5000
TagPicker	mount	1508	1464	5000
Text	mount	381	388	5000
TextField	mount	971	964	5000
ThemeProvider	mount	849	850	5000
ThemeProvider	virtual-rerender	592	585	5000
ThemeProvider	virtual-rerender-with-unmount	1295	1279	5000
Toggle	mount	613	601	5000
buttonNative	mount	199	198	5000

fabricteam · 2024-07-04T14:54:18Z

🕵 fluentuiv8 No visual regressions between this PR and main

Hotell

🚀

fabricteam reviewed Jul 2, 2024

View reviewed changes

Comment thread package.json

mainframev commented Jul 2, 2024

View reviewed changes

Comment thread package.json

mainframev changed the title ~~chore: migrate to ts v5~~ chore: migrate to ts v5.0 Jul 2, 2024

mainframev changed the title ~~chore: migrate to ts v5.0~~ chore: migrate to ts v5.0.4 Jul 2, 2024

mainframev force-pushed the chore/migrate-to-ts-5 branch from 67ba4cb to 9b4daab Compare July 2, 2024 12:55

mainframev commented Jul 3, 2024

View reviewed changes

Comment thread packages/web-components/docs/api-report.md

mainframev force-pushed the chore/migrate-to-ts-5 branch 2 times, most recently from 502765f to 33b8d2b Compare July 4, 2024 08:55

fabricteam reviewed Jul 4, 2024

View reviewed changes

Comment thread .devops/templates/build-test-lint.yml

mainframev force-pushed the chore/migrate-to-ts-5 branch 4 times, most recently from 69a0a32 to f16213d Compare July 4, 2024 14:08

mainframev commented Jul 4, 2024

View reviewed changes

Comment thread .devops/templates/build-test-lint.yml Outdated

mainframev commented Jul 4, 2024

View reviewed changes

Comment thread tsconfig.base.all.json

mainframev marked this pull request as ready for review July 8, 2024 13:02

mainframev requested review from a team as code owners July 8, 2024 13:02

Hotell reviewed Jul 8, 2024

View reviewed changes

Comment thread package.json Outdated

mainframev force-pushed the chore/migrate-to-ts-5 branch 2 times, most recently from 50d4e41 to ef93c9e Compare July 8, 2024 14:09

Hotell approved these changes Jul 8, 2024

View reviewed changes

layershifter approved these changes Jul 8, 2024

View reviewed changes

janechu approved these changes Jul 8, 2024

View reviewed changes

mainframev force-pushed the chore/migrate-to-ts-5 branch from ef93c9e to 54aa260 Compare July 9, 2024 13:00

mainframev added 7 commits July 10, 2024 11:49

chore: migrate typescript to 5.0

2ecd049

chore: bump @microsoft/api-extractor and @microsoft/api-extractor-model

77d27ab

chore(react-accordion): regenerate api.md

7b1e6fd

chore(react-provider): regenerate api.md

226e235

chore: forceConsistenCasingInFileNames is default true

73d3a66

chore: update change files

448b376

chore(generators): update tsconfig-base-all generator

ab25c3a

mainframev force-pushed the chore/migrate-to-ts-5 branch from 54aa260 to ab25c3a Compare July 10, 2024 09:49

mainframev added the Area: Typescript label Jul 10, 2024

mainframev self-assigned this Jul 10, 2024

mainframev added the Area: Build System label Jul 10, 2024

TristanWatanabe approved these changes Jul 10, 2024

View reviewed changes

mainframev merged commit ff2c813 into microsoft:master Jul 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: migrate to ts v5.0.4#31898

chore: migrate to ts v5.0.4#31898
mainframev merged 7 commits into
microsoft:masterfrom
mainframev:chore/migrate-to-ts-5

mainframev commented Jul 2, 2024 •

edited

Loading

Uh oh!

fabricteam commented Jul 2, 2024 •

edited

Loading

Uh oh!

Uh oh!

fabricteam commented Jul 2, 2024 •

edited

Loading

Uh oh!

fabricteam commented Jul 2, 2024 •

edited

Loading

Uh oh!

fabricteam commented Jul 2, 2024 •

edited

Loading

Uh oh!

Uh oh!

fabricteam commented Jul 2, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fabricteam commented Jul 4, 2024 •

edited

Loading

Uh oh!

Uh oh!

Hotell left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

mainframev commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Previous Behavior

New Behavior

Related Issue(s)

Uh oh!

fabricteam commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

Uh oh!

fabricteam commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Potential regressions comparing to master

Uh oh!

fabricteam commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 FluentUIV0 No visual regressions between this PR and main

Uh oh!

Uh oh!

fabricteam commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fabricteam commented Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

Uh oh!

Hotell left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mainframev commented Jul 2, 2024 •

edited

Loading

fabricteam commented Jul 2, 2024 •

edited

Loading

fabricteam commented Jul 2, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Jul 2, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Jul 2, 2024 •

edited

Loading

fabricteam commented Jul 2, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react`)

fabricteam commented Jul 4, 2024 •

edited

Loading