Skip to content

chore(vr-tests-react-components): Convert stories to CSF - #31939

Merged
dmytrokirpa merged 11 commits into
microsoft:masterfrom
dmytrokirpa:convert-vr-tests-stories-to-csf
Jul 18, 2024
Merged

chore(vr-tests-react-components): Convert stories to CSF#31939
dmytrokirpa merged 11 commits into
microsoft:masterfrom
dmytrokirpa:convert-vr-tests-stories-to-csf

Conversation

@dmytrokirpa

Copy link
Copy Markdown
Contributor

Previous Behavior

Visual regression tests stories (V9) utilized the storiesOf format, now deprecated in Storybook version 7 and beyond.

New Behavior

Visual regression tests stories (V9) have adopted the CSF syntax, ensuring compatibility with Storybook version 7 and later.

Related Issue(s)

@dmytrokirpa
dmytrokirpa requested a review from Hotell July 8, 2024 10:40
@dmytrokirpa dmytrokirpa self-assigned this Jul 8, 2024
@dmytrokirpa dmytrokirpa mentioned this pull request Jul 8, 2024
12 tasks
@fabricteam

fabricteam commented Jul 8, 2024

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

✅ No changes found

Comment thread apps/vr-tests-react-components/.storybook/preview.js
@dmytrokirpa dmytrokirpa changed the title chore(vr-tests-react-components): convert VR tests stories to CSF chore(vr-tests-react-components): Convert stories to CSF Jul 8, 2024
@dmytrokirpa
dmytrokirpa marked this pull request as ready for review July 8, 2024 15:29
@dmytrokirpa
dmytrokirpa requested a review from a team as a code owner July 8, 2024 15:29
@dmytrokirpa
dmytrokirpa force-pushed the convert-vr-tests-stories-to-csf branch from e5998a3 to 4f6bf69 Compare July 10, 2024 20:02
@dmytrokirpa
dmytrokirpa marked this pull request as draft July 10, 2024 20:34
@dmytrokirpa
dmytrokirpa force-pushed the convert-vr-tests-stories-to-csf branch 2 times, most recently from 0f5f65e to 6db1cfb Compare July 15, 2024 21:59
@dmytrokirpa
dmytrokirpa force-pushed the convert-vr-tests-stories-to-csf branch from 92205f7 to 6f18705 Compare July 16, 2024 11:53

@Hotell Hotell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff, some action is required for /utilities. ty

Comment thread apps/vr-tests-react-components/src/utilities/withStoryWrightSteps.tsx Outdated
Comment thread apps/vr-tests-react-components/src/utilities/getStoryVariant.tsx Outdated
Comment thread apps/vr-tests-react-components/src/utilities/utilities.test.tsx Outdated
Comment thread apps/vr-tests-react-components/src/utilities/TestWrapperDecorator.tsx Outdated
@dmytrokirpa
dmytrokirpa requested a review from Hotell July 17, 2024 16:26
@dmytrokirpa dmytrokirpa mentioned this pull request Jul 17, 2024
5 tasks

@Hotell Hotell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread apps/vr-tests-react-components/src/utilities/getStoryVariant.tsx
@dmytrokirpa
dmytrokirpa merged commit 705085a into microsoft:master Jul 18, 2024
@dmytrokirpa
dmytrokirpa deleted the convert-vr-tests-stories-to-csf branch July 18, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants